💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1296940262)
GHActions have no such a feature by default. It should be a separated workflow that processes [`pull_request.synchronize`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request) event and terminates other workflows. However, I'm not sure about the exact implementation for now.

💬 hebasto commented on pull request "ci: Refactor: Remove CI_USE_APT_INSTALL":
(https://github.com/bitcoin/bitcoin/pull/28278#issuecomment-1681955501)
Maybe also address the following comments:
- https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1294434738
- https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1294895367

in this PR?

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1296945030)
So if someone (honestly) pushes to a pull request a few times in a few minutes, it will block CI progress on all other pulls, assuming a few more tasks are run on GHA and the "free" limit is reached?

💬 ajtowns commented on pull request "Fix potential network stalling bug":
(https://github.com/bitcoin/bitcoin/pull/27981#issuecomment-1681958726)
ACK 3388e523a129ad9c7aef418c9f57491f8c2d9df8

Test case looks good; seems reasonable to do the `sendmsgtopeer` change in a separate PR though.

💬 vasild commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-1681962937)
`ae75114975...d31cb74c44`: rebase for CI

💬 vasild commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#issuecomment-1681971680)
`be7ae7b1ec...e92b7dee6d`: rebase for CI

🚀 fanquake merged a pull request: "p2p: Drop m_recently_announced_invs bloom filter"
(https://github.com/bitcoin/bitcoin/pull/27675)

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1296986807)
> Yea, looks like caching doesn't work at all here?

It [works](https://github.com/bitcoin/bitcoin/actions/runs/5878420889/job/15940465042).

> I think it works when there are no pull requests. It should be possible to fix this in a follow-up.

Yes, pull requests should not create their own caches. Going to address this issue shortly.

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1681991436)
Looks like it is now even harder to re-run tasks, if there is an intermittent network issue (for example if GH or GHA is down, which happens ~daily).

At least, all I can do is download the log, whereas on Cirrus, I can re-run my own pull.


💬 fanquake commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1681993763)
> Looks like it is now even harder to re-run tasks,

So there is no way for developers to re-run there own PRs at all, with GitHub Actions? Other than I assume force pushing?

💬 MarcoFalke commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#issuecomment-1681999949)
Are you still working on this?

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1682003373)
> > Looks like it is now even harder to re-run tasks,
>
> So there is no way for developers to re-run there own PRs at all, with GitHub Actions? Other than I assume force pushing?

Docs are not super clear about that: https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs.

💬 eriknylund commented on pull request "test: verify spend from 999-of-999 taproot multisig wallet":
(https://github.com/bitcoin/bitcoin/pull/28212#discussion_r1297001150)
Thanks for the comments. 🙏 I added the comma, rebased onto master and force pushed to trigger a new build to get the mac CI through.

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1682007407)
That page says "People with write permissions to a repository can re-run workflows in the repository." Maybe someone else *without* write access can confirm whether they can re-run on Cirrus?

💬 ismaelsadeeq commented on pull request "test doc: tests `acceptstalefeeestimates` option is only supported on regtest chain":
(https://github.com/bitcoin/bitcoin/pull/28157#issuecomment-1682010377)
rebased

💬 fanquake commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1682018059)
> That page says "People with write permissions to a repository can re-run workflows in the repository."

Hopefully not. If this really is the case, that's another downside to GH Actions, and going to be a wrose developer experience (we can't give write access to all contributors just to re-run CI). Would have been good if these things had been explained in the PR description, or discussion.

> can confirm whether they can re-run on Cirrus?

Contributors can definitely re-run Cirrus jobs.
...

🚀 fanquake merged a pull request: "ci: Move tidy to persistent worker"
(https://github.com/bitcoin/bitcoin/pull/28214)

📝 hebasto opened a pull request: "ci: Ensure that only a single workflow processes `github.ref` at a time"
(https://github.com/bitcoin/bitcoin/pull/28282)
This PR ensures that only a single workflow processes any push or pull request at a time.

A new push will be queued.

For a new pull request update, the previous in-progress one will be cancelled.

Address https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295144563.

💬 dergoegge commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1682031077)
> Maybe someone else without write access can confirm whether they can re-run on Cirrus?

I can't re-run GH actions tasks but am able to re-run cirrus jobs.

👍 theStack approved a pull request: "Break up script/standard.{h/cpp}"
(https://github.com/bitcoin/bitcoin/pull/28244#pullrequestreview-1582307974)
Code-review ACK 91d924ede1b421df31c895f4f43359e453a09ca5