💬 hebasto commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295550323)
fae6642af234cad6063945bcba7958168bf2687c, style nit, suggesting to set environment variables consistently throughout the entire `ci.yml` file, wherever possible:

```suggestion
env:
BASE_ROOT_DIR: ${{ github.workspace }}
run: ./ci/test_run_all.sh
```

💬 Sjors commented on issue "Raise maximum -dbcache setting":
(https://github.com/bitcoin/bitcoin/issues/28249#issuecomment-1680180842)
@sipa I ran an IBD as part of testing #27596. Since I did a restart after the cache initially hit 1 GB, the data is not accurate, but the cache reached 13,334 MiB at block at block 798,000. A month earlier at 794,000 the log shows it as 12,766 MiB. So the memory footprint is growing ~7 GB per year (and that's not even the worst month, see [chart I linked to above](https://statoshi.info/d/000000009/unspent-transaction-output-set?orgId=1&from=now%2Fy&to=now&refresh=5s&viewPanel=8)).

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295561963)
Thanks, removed.

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295562542)
Thanks, adjusted style

👍 hebasto approved a pull request: "ci: Move tidy to persistent worker"
(https://github.com/bitcoin/bitcoin/pull/28214#pullrequestreview-1580082893)
re-ACK faaa0794b24f250f787bc9b9605270108ea101a0

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#issuecomment-1680189483)




> Re-run of the Cirrus task builds the depends packages regardless of caching: https://cirrus-ci.com/task/5981899345100800

Good catch. The folder was empty. Should be fixed now.

💬 fanquake commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295570969)
Yea, looks like caching doesn't work at all here?

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295573475)
> Yea, looks like caching doesn't work at all here?

- https://github.com/bitcoin/bitcoin/issues/21552
- https://github.com/bitcoin/bitcoin/pull/24620

💬 fanquake commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295574797)
If it doesn't work, why was any of this added to the CI template?

💬 Sjors commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#issuecomment-1680204877)
ACK 91d924ede1b421df31c895f4f43359e453a09ca5

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295577353)
I think it works when there are no pull requests. It should be possible to fix this in a follow-up.

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295578085)
> If it doesn't work, why was any of this added to the CI template?

Ccache regression, introduced in https://github.com/bitcoin/bitcoin/pull/19683, should be fixed. It is not related to the CI template that is correct.

💬 stickies-v commented on pull request "ci: label docker images and prune dangling images selectively":
(https://github.com/bitcoin/bitcoin/pull/27793#discussion_r1295578392)
Thanks Dropped the README.md commit, don't feel like spending more time on this. @Sjors feel free to follow up if you think it's important.

💬 russeree commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1680212205)
> * "What if we do it in the worst way possible? What if we store it in the UTXO set?"

He is wrong about this, the worst way possible would be to use P2PK instead of P2MS since it would increase the number of outpoints per arbitrary data TX by 3x.

> @russeree, your response is a red herring because you're distracting from the fact that Mike openly states that he's _"polluting the UTXO set"_ with _"toxic waste"_:

This is actually a proper response, thanks citing sources and facts. My co
...

💬 hebasto commented on pull request "build: Fix ccache behavior when cross-compiling for darwin hosts":
(https://github.com/bitcoin/bitcoin/pull/24620#issuecomment-1680215229)
> ~0. I'm still not convinced this is a good change, or even something that _needs_ to be solved at the cost of introducing more platform specific hacks / complication into our build system. It's surprising that there is no way for us to fix this for our use case given the multitude of ccache configuration options / settings, and it's support for additional compiler wrappers. Have we opened an issue upstream to document our use case, and why ccache doesn't currently work with it?

Considering
...

💬 fanquake commented on pull request "build: Fix ccache behavior when cross-compiling for darwin hosts":
(https://github.com/bitcoin/bitcoin/pull/24620#issuecomment-1680218377)
> It's surprising that there is no way for us to fix this for our use case given the multitude of ccache configuration options / settings, and it's support for additional compiler wrappers.

> Have we opened an issue upstream to document our use case, and why ccache doesn't currently work with it?

📝 ggauzin opened a pull request: "Update Bitcoin Core integration/staging tree documentation"
(https://github.com/bitcoin/bitcoin/pull/28277)
This commit updates the documentation for the Bitcoin Core integration/staging tree. The changes include minor text edits and formatting improvements to enhance readability and clarity.

- Updated the formatting of headings for consistency.
- Added missing punctuation in the "License" section.
- Clarified the role of the master branch and its stability in the "Development Process" section.
- Clarified the purpose of the https://github.com/bitcoin-core/gui repository.
- Improved the descrip
...

✅ fanquake closed a pull request: "Update Bitcoin Core integration/staging tree documentation"
(https://github.com/bitcoin/bitcoin/pull/28277)

💬 ggauzin commented on pull request "Update Bitcoin Core integration/staging tree documentation":
(https://github.com/bitcoin/bitcoin/pull/28277#issuecomment-1680221923)
why is it closed

💬 ajtowns commented on pull request "[no merge, meta] refactor: net/net processing split":
(https://github.com/bitcoin/bitcoin/pull/28252#issuecomment-1680222391)
I think I might be coming across as disagreeing more than I actually do? I'm all for modularisation and better testing, and getting things tightly focussed so that you don't need to keep huge amounts of context in your head; but I think the way we've been doing that in `net_processing` in many places is adding complexity and interrelationships rather than reducing them.

> Perhaps a competing PR/design doc of what you are thinking about would help? I've thought about the design in this PR so m
...