💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678588386)
What is `gettransaction 16e...`?

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678590452)
>

```bash
{
"amount": 0.00000000,
"fee": -0.00001692,
"confirmations": 6,
"blockhash": "1db6dbff417219a6858d532c42bb670fb418fb26e48fbc44e586133af8ecfccd",
"blockheight": 232,
"blockindex": 2,
"blocktime": 1692031801,
"txid": "16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e",
"wtxid": "9926759aedc24a9e4fd627e7e12168872caa8062e17380c3a15d27111f34cbb7",
"walletconflicts": [
],
"time": 1692031024,
"timereceived": 1692031024,
"bip125-rep
...

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678591764)
> What is `gettransaction 16e...`?

{
"amount": 0.00000000,
"fee": -0.00001692,
"confirmations": 6,
"blockhash": "1db6dbff417219a6858d532c42bb670fb418fb26e48fbc44e586133af8ecfccd",
"blockheight": 232,
"blockindex": 2,
"blocktime": 1692031801,
"txid": "16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e",
"wtxid": "9926759aedc24a9e4fd627e7e12168872caa8062e17380c3a15d27111f34cbb7",
"walletconflicts": [
],
"time": 1692031024,
"timereceived": 169
...

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678595188)
And `gettxout 16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e 0`?

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678595995)
>

Nothing.

<img width="935" alt="image" src="https://github.com/bitcoin/bitcoin/assets/3801362/5093fb56-c682-4f67-9865-fddbe0659930">

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678603308)
And `listsinceblock 1db6dbff417219a6858d532c42bb670fb418fb26e48fbc44e586133af8ecfccd`?

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678604890)
> And `listsinceblock 1db6dbff417219a6858d532c42bb670fb418fb26e48fbc44e586133af8ecfccd`?

```bash
{
"transactions": [
{
"address": "bcrt1qd7dahmn7plurwne07ncwd2lmt2hd23v62zz2y0",
"category": "send",
"amount": -0.00198790,
"label": "",
"vout": 0,
"fee": -0.00001210,
"confirmations": 0,
"trusted": true,
"txid": "2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc",
"wtxid": "0a3881070849fd239993efd953fdb4
...

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678611825)
And `getrawtransaction 2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc 2`?

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678621341)
> And `getrawtransaction 2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc 2` (or `1`)?


**getrawtransaction 2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc 2**

```bash
{
"txid": "2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc",
"hash": "0a3881070849fd239993efd953fdb4286fc6746d8402d3d7773bb7a194f90fe5",
"version": 2,
"size": 192,
"vsize": 110,
"weight": 438,
"locktime": 0,
"vin": [
{
"txid": "16e0b64735
...

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678622826)
If you spend an output, it will be no longer unspent, thus `listunspent` won't return it

👍 dergoegge approved a pull request: "fuzz: fix a couple incorrect assertions in the `coins_view` target"
(https://github.com/bitcoin/bitcoin/pull/28215#pullrequestreview-1578199732)
Code review ACK e417c988f61bf9d3948d5c8e169626922fe6e24c

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678623985)
Closing for now. Let us know if you have any other questions.

✅ MarcoFalke closed an issue: "Regtest mode loses unspents after day"
(https://github.com/bitcoin/bitcoin/issues/28262)

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678625120)
> If you spend an output, it will be no longer unspent, thus `listunspent` won't return it



> If you spend an output, it will be no longer unspent, thus `listunspent` won't return it

Obviously but I have not spent any. The address **bcrt1qlmxyvxl4akf0nz54tw0hpu5vzdasj37ef7hm4s** should contain the results that I sent yesterday but today it does not.

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678625497)
> Closing for now. Let us know if you have any other questions.

I don't know why you close it, if it hasn't been solved...

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678626141)
Txid `2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc`, created 9 hours ago, spent the `16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e : 0` output.

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678629158)
> Txid `2a98703475934131304b5d1a3cfae4795b8f83709e6965771bdf02f600bfaffc`, created 9 hours ago, spent the `16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e : 0` output.

Okay, we're going to check it again. Thanks for your help.

💬 MarcoFalke commented on pull request "blockstorage: Drop legacy -txindex check":
(https://github.com/bitcoin/bitcoin/pull/28195#issuecomment-1678652452)
> though I lack historical context to really judge the second commit

The basic idea is that the legacy txindex was stored inside the block index db. Then a new `src/index/` infrastructure was added and there was migration code. Then, the migration code was removed and a warning was added that a previous version is needed (or a full `-reindex`) to do the migration. Now that all those previous versions are EOL, and thus there should no one be left, who needs a migration, the warning can be remo
...

💬 MarcoFalke commented on pull request "util: Type-safe transaction identifiers":
(https://github.com/bitcoin/bitcoin/pull/28107#discussion_r1294386567)
> Yea I think this makes sense while we are converting, otherwise I suspect there'll be more churn (similar to the comparisons).

It is fine, if reviewers prefer this. Though, I wouldn't call it "type-safe" and it would be better to at least add a comment about the trade-offs you are making.

> But how would you suggest to forbid this?

It can be forbidden by not allowing it. If you are asking how to do it in C++, something like this should work:

```cpp
class transaction_identifier{

...

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#discussion_r1294410716)
Removed in this pull. Should be trivial to re-ACK.