💬 Symphonic3 commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1678354752)
> First seen is the existing default. I'm of the personal opinion it's probably a worse default in a vacuum, but the decision isn't being made in a vacuum, and changing defaults to influence policy toward personal preference, even if I'm confident in that preference, is quite different in my view to something being the default because there was not previously another option.

This philosophy is antithetical to any kind of development at all.

> It is not possible for a setting to be "unset"
...

💬 russeree commented on issue "Any JavaScript functional test for this repo?":
(https://github.com/bitcoin/bitcoin/issues/28270#issuecomment-1678396749)
This would not be possible without a large refactor. The Bitcoin-core npm package is very good for communicating with the bitcoind server to run RPC commands, the internal testing suite of python code spins up various instances of bitcoind with different flags and executes commands against those instances.

All in all the npm Bitcoin core package would not be a good candidate as a wrapper for test_runner.py

This issue should be closed.

✅ fanquake closed an issue: "Any JavaScript functional test for this repo?"
(https://github.com/bitcoin/bitcoin/issues/28270)

🤔 stratospher reviewed a pull request: "crypto: more `Span<std::byte>` modernization & follow-ups"
(https://github.com/bitcoin/bitcoin/pull/28100#pullrequestreview-1570882712)
ACK baf93fb. neat c++!

💬 stratospher commented on pull request "crypto: more `Span<std::byte>` modernization & follow-ups":
(https://github.com/bitcoin/bitcoin/pull/28100#discussion_r1293430357)
bc0a714:
```suggestion
void Crypt(Span<const std::byte> in_bytes, Span<std::byte> out_bytes) noexcept;
```

💬 stratospher commented on pull request "crypto: more `Span<std::byte>` modernization & follow-ups":
(https://github.com/bitcoin/bitcoin/pull/28100#discussion_r1294172858)
bc0a714: did https://github.com/bitcoin/bitcoin/pull/26153#discussion_r1129318294 mean clearing `m_buffer` too when `m_bufleft` is 0?

💬 stratospher commented on pull request "crypto: more `Span<std::byte>` modernization & follow-ups":
(https://github.com/bitcoin/bitcoin/pull/28100#discussion_r1293541985)
bc0a714: maybe include ChaCha20 in the headers?

💬 MarcoFalke commented on pull request "lint: fix custom mypy cache dir setting":
(https://github.com/bitcoin/bitcoin/pull/28184#issuecomment-1678489503)
Are you still working on this? If not, could close, so that someone else can pick it up?

💬 MarcoFalke commented on pull request "Descriptor unit tests and simplifications":
(https://github.com/bitcoin/bitcoin/pull/24361#issuecomment-1678490489)
@sipa ^

💬 MarcoFalke commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#discussion_r1294251278)
> On the other hand, it's possible to delete images, so it wouldn't be too crazy to "abuse" GHCR for passing CI images and still avoid without eating storage without a limit.

Ah, looks like this is something that should probably be done either way, because untagged images are also kept around. So even if only images for the master branch are used, it would be good to delete "stale tags" (that is, untagged images).

💬 LarryRuane commented on pull request "test: rpc: add last block announcement time to getpeerinfo result":
(https://github.com/bitcoin/bitcoin/pull/27052#issuecomment-1678501363)
Force pushed from becf38061b2625bcc629293fec0dce7c27292e14 to
- efc2e70f1763c6bf3f6b246202adb9d5f1f798ee [diff](https://github.com/bitcoin/bitcoin/compare/becf38061b2625bcc629293fec0dce7c27292e14..efc2e70f1763c6bf3f6b246202adb9d5f1f798ee) -- needed rebase
- 16d2903b8a9e6e980e24e04ab2d86c7e778f5764 [diff](https://github.com/bitcoin/bitcoin/compare/efc2e70f1763c6bf3f6b246202adb9d5f1f798ee..16d2903b8a9e6e980e24e04ab2d86c7e778f5764) -- make the suggested review changes
- 2e80e3bdcd9cac7878c0d1495
...

👋 LarryRuane's pull request is ready for review: "test: rpc: add last block announcement time to getpeerinfo result"
(https://github.com/bitcoin/bitcoin/pull/27052)

🤔 MarcoFalke reviewed a pull request: "test: display abrupt shutdown errors in console output"
(https://github.com/bitcoin/bitcoin/pull/28253#pullrequestreview-1578062646)
Ok, so this will only be hit when Bitcoin Core is completely non-functional and completely refuses to start (in create_cache.py)? In all other cases, this should already be printed.

💬 MarcoFalke commented on pull request "test: display abrupt shutdown errors in console output":
(https://github.com/bitcoin/bitcoin/pull/28253#discussion_r1294258580)
Why not append your message to this message?

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678577902)
Hello guys! **11 hours** have passed, here it is 10:19 CET and the result is as follows:

<img width="914" alt="image" src="https://github.com/bitcoin/bitcoin/assets/3801362/d3af1d55-5528-4993-8d51-b70a71256511">

```bash
debian@vps-b4e8a731:~$ bitcoin-core.cli -rpcport=10001 -rpcuser=bitcoin -rpcpassword=bitcoin getbestblockhash
2432724b29f73abdb2fc345db5e47a19d0ed286f7b7b85ad3485e2a53764f9b6
debian@vps-b4e8a731:~$ bitcoin-core.cli -rpcport=10001 -rpcuser=bitcoin -rpcpassword=bitcoin lis
...

💬 MarcoFalke commented on pull request "crypto: more `Span<std::byte>` modernization & follow-ups":
(https://github.com/bitcoin/bitcoin/pull/28100#issuecomment-1678582726)
ACK baf93fbd47058b182643c5a11fe9a8928276b05f 🙉

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK baf93fbd47058b182643c5a11
...

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678588386)
What is `gettransaction 16e...`?

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678590452)
>

```bash
{
"amount": 0.00000000,
"fee": -0.00001692,
"confirmations": 6,
"blockhash": "1db6dbff417219a6858d532c42bb670fb418fb26e48fbc44e586133af8ecfccd",
"blockheight": 232,
"blockindex": 2,
"blocktime": 1692031801,
"txid": "16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e",
"wtxid": "9926759aedc24a9e4fd627e7e12168872caa8062e17380c3a15d27111f34cbb7",
"walletconflicts": [
],
"time": 1692031024,
"timereceived": 1692031024,
"bip125-rep
...

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678591764)
> What is `gettransaction 16e...`?

{
"amount": 0.00000000,
"fee": -0.00001692,
"confirmations": 6,
"blockhash": "1db6dbff417219a6858d532c42bb670fb418fb26e48fbc44e586133af8ecfccd",
"blockheight": 232,
"blockindex": 2,
"blocktime": 1692031801,
"txid": "16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e",
"wtxid": "9926759aedc24a9e4fd627e7e12168872caa8062e17380c3a15d27111f34cbb7",
"walletconflicts": [
],
"time": 1692031024,
"timereceived": 169
...

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1678595188)
And `gettxout 16e0b64735f1e4748a88ef414ec7b70861c4467ffef0dba1e628cc21a312507e 0`?