👍 MarcoFalke approved a pull request: "test: refactor: support sending funds with outpoint result"
(https://github.com/bitcoin/bitcoin/pull/28264#pullrequestreview-1577126645)
lgtm, two nits only

💬 MarcoFalke commented on pull request "test: refactor: support sending funds with outpoint result":
(https://github.com/bitcoin/bitcoin/pull/28264#discussion_r1293647505)
```suggestion
utxos = self.create_outpoints(self.nodes[0], outputs=[{node1_addr: 13},{node2_addr: 13},
])
```

💬 MarcoFalke commented on pull request "test: refactor: support sending funds with outpoint result":
(https://github.com/bitcoin/bitcoin/pull/28264#discussion_r1293649848)
```suggestion
def create_outpoints(self, node, *, outputs):
```

nit: I guess it is also fine to omit the named arg for node.

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1677589589)
What are the exact steps to reproduce with mocktime?

📝 hebasto opened a pull request: "ci: Drop no longer needed `macos_sdk_cache`"
(https://github.com/bitcoin/bitcoin/pull/28269)
It has been cached in the Docker image since https://github.com/bitcoin/bitcoin/pull/27028.

💬 MarcoFalke commented on pull request "test: display abrupt shutdown errors in console output":
(https://github.com/bitcoin/bitcoin/pull/28253#issuecomment-1677604972)
The CI uses the combine logs helper. Can you link to a CI output before and after?

🤔 MarcoFalke reviewed a pull request: "ci: Drop no longer needed `macos_sdk_cache`"
(https://github.com/bitcoin/bitcoin/pull/28269#pullrequestreview-1577164611)
lgtm. Can use `GLOBAL_TASK_TEMPLATE` now?

💬 hebasto commented on pull request "ci: Drop no longer needed `macos_sdk_cache`":
(https://github.com/bitcoin/bitcoin/pull/28269#issuecomment-1677619333)
> Can use `GLOBAL_TASK_TEMPLATE` now?

Thanks! Updated.

💬 MarcoFalke commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1677624891)
@Retropex Are you still working on this? If yes, it would be good to include a *technical* summary of the discussion here, including how it affects other software/BIPs. Ideally, also mention raw p2pk in your summary and present real-world data points.

The current description "This would strengthen the Bitcoin ecosystem by encouraging the use of compliant transactions." appears to be non-technical, personal opinion.

If you are no loner working on this, it would be good to close this pull re
...

💬 MarcoFalke commented on pull request "ci: Drop no longer needed `macos_sdk_cache`":
(https://github.com/bitcoin/bitcoin/pull/28269#issuecomment-1677625620)
lgtm ACK c2a87bd302585c242d0d66db72c6ce6c60f81b78

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1677633291)
@achow101 @fanquake Anything left to be done here? The "macOS 13 native arm64" Cirrus task will stop working in two weeks, so it would be good to do something about it. If you disagree with this change, it would be good to leave a comment.

💬 hebasto commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1677637498)
> I guess your issue is about the GUI choose-direcory dialog?

FWIW, this dialog is enabled by default during the first run of the Bitcoin Core GUI.

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1677666102)
> What are the exact steps to reproduce with mocktime?

Sincerely I don't know I understood you correctly, but these were my steps:

**Set system time:**

`bitcoin-core.cli setmocktime 0`

Then

`bitcoin-core.cli listunspent 0 9999999 [\"bcrt1qnh6pt6ztvsz93u95drnwxlk452kfhc5ad9uk6z\"]`

💬 hebasto commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#issuecomment-1677693482)
> > One question below and also I'm wondering if the output of "include-what-you-use" is used at all? It makes a lot of suggestions but none of that counts as errors?
>
> Yeah, that is on purpose and unchanged in this pull. Currently iwyu still has bugs (_false_ negatives and _false_ positives) and there are also trillion _true_ positives and the _true_ negatives sometimes lead to compile errors down the line in other modules.
>
> I think for now it is best to check the iwyu output during
...

💬 vasild commented on pull request "Use shared_ptr for CNode inside CConnman":
(https://github.com/bitcoin/bitcoin/pull/28222#issuecomment-1677719961)
What about calling `FinalizeNode()` from the destructor of `CNode`? This ensures it will be called exactly once by some thread after no other threads are referencing it. Is this not what we want?

<details>
<summary>[patch] FinalizeNode() from ~CNode()</summary>

```diff
diff --git i/src/net.h w/src/net.h
index 1ea0ad868a..587d907c3a 100644
--- i/src/net.h
+++ w/src/net.h
@@ -412,13 +412,12 @@ public:
/** fSuccessfullyConnected is set to true on receiving VERACK from the peer. */
...

💬 sipa commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1677748686)
Do you have 100 blocks on top of the one that created your UTXO? Without that it'll be immature, and possibly not listed.

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1677757108)
> Do you have 100 blocks on top of the one that created your UTXO? Without that it'll be immature, and possibly not listed.

It has nothing to do because as I said above, after moving the funds and executing the **listunspent** command, it returns the inputs perfectly. After a day, I run the **listunspent** command again and I get empty.

💬 vasild commented on issue "Auto detect IPv6 connectivity":
(https://github.com/bitcoin/bitcoin/issues/28061#issuecomment-1677758907)
That is the case currently as well: `ifconfig eth0 up/down` and IPv4 or IPv6 connectivity comes and goes. Tor or I2P or CJDNS router restart - same, at runtime.

💬 sipa commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1677761038)
Apologies, I should have read more. If something actually disappears from `listunspent` (without being reorged out), that sounds like a bug.

💬 samyan commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1677768605)
> Apologies, I should have read more. If something actually disappears from `listunspent` (without being reorged out), that sounds like a bug.

Don't worry. I also think it seems to be a bug but I don't know... So I will continue to do more tests.