💬 samyan commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676912956)
Anyways you can install the program in C and put the node database in other drive.

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#discussion_r1293164677)
Yes, I'll remove it in a follow-up

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#issuecomment-1676923241)
> I also ran the task locally (although on macOS I had to enter the container and manually install clang with arm support).

Yeah, that's unrelated, because I only modify the cirrus yml, not the CI task config. Maybe create a separate issue, though I won't be able to help, since I don't have or use macOS.



> One question below and also I'm wondering if the output of "include-what-you-use" is used at all? It makes a lot of suggestions but none of that counts as errors?

Yeah, that is on
...

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#discussion_r1293174314)
The reason is that the ENV only sets one env var, which can (and is) also be done directly in the screen command.

`RESTART_CI_DOCKER_BEFORE_RUN=1 screen cirrus ...`

💬 MarcoFalke commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676939986)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base. General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.

💬 MarcoFalke commented on pull request "crypto: BIP324 ciphersuite follow-up":
(https://github.com/bitcoin/bitcoin/pull/28267#discussion_r1293191092)
When touching this file, could add the missing include?

```
bip324.h should add these lines:
#include <array>

💬 MarcoFalke commented on pull request "crypto: BIP324 ciphersuite follow-up":
(https://github.com/bitcoin/bitcoin/pull/28267#discussion_r1293193336)
See the full iwyu output: https://api.cirrus-ci.com/v1/task/4946847257591808/logs/ci.log (Search for `$filename should ` or `$filename has the correct`)

(Same for `crypto/chacha20poly1305.cpp`)

💬 Rlavington commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676972723)
> Anyways you can install the program in C and put the node database in other drive.

That's exactly what I do. Because I don't want to use up all of the space on my computer's hard drive.

Untill the price of SSDs come down, I will upgrade.

💬 MarcoFalke commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676978866)
I guess your issue is about the GUI choose-direcory dialog? If yes, mind creating an issue in the GUI repo? Or even better, a pull request with your suggested changes?

💬 Sjors commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#discussion_r1293214524)
Or we could just drop testnet3 :-P

I find the difference in color useful enough.

💬 MarcoFalke commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#issuecomment-1676981483)
So this is needed for the gui-qml repo to upload assets? Are there any other tasks that need this feature?

💬 MarcoFalke commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#discussion_r1293217412)
> I find the difference in color useful enough.

Then, it would be better to have a tiny script in the build process to create the `.ico`, no? This would make it reproducible, documented and easily modifiable, without on each modification bloating the git repo by 50kb

💬 Sjors commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#discussion_r1293221976)
Done for testnet and signet. I didn't touch `Name "@PACKAGE_NAME@ (64-bit)"` though, not sure if that's safe.

💬 MarcoFalke commented on pull request "test: refactor: support sending funds with outpoint result":
(https://github.com/bitcoin/bitcoin/pull/28264#discussion_r1293224263)
```suggestion
def create_outpoints(*, node, outputs):
```

Maybe take and return an array? Also, could force named args? Finally, could make this a member of TestFramework or TestNode? (It is not an independent util, but requires a node/wallet, ...)

💬 MarcoFalke commented on issue "Regtest mode loses unspents after day":
(https://github.com/bitcoin/bitcoin/issues/28262#issuecomment-1676996179)
Is the best block the same? See the `getblockchaininfo` RPC.

💬 Sjors commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#discussion_r1293226964)
The incantation is in the commit message. Adding a script makes sense, but I'm not familiar enough with the (native) build tools to know where to add it. This particular command would also add a dependency to imagemagick (if we don't use it already), though I'm sure the operation can be done with other tools if needed.

💬 hebasto commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#issuecomment-1677022714)
> So this is needed for the gui-qml repo to upload assets?

Yes. But this is not the only reason of moving to GHA.

Other reasons are:
- GHA are quicker and cheaper (free) than Cirrus CI. [Consider](https://cirrus-ci.com/task/4735741025058816):

- GHA are quicker and cheaper (free) than self-hosted permanent Cirrus CI workers. [Consider](https://cirrus-ci.com/task/5538452293287936):
![imag
...

💬 MarcoFalke commented on pull request "ci: Use hard-coded root path for CI containers (bugfix)":
(https://github.com/bitcoin/bitcoin/pull/28185#issuecomment-1677028729)
I used the commands in the pull request description to re-test this is still a bugfix on current master.

💬 MarcoFalke commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#discussion_r1293265119)
Forgot to remove the Cirrus task?

💬 MarcoFalke commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#discussion_r1293269776)
What is the cache limit and the inner working?