💬 sipa commented on pull request "net: transport abstraction":
(https://github.com/bitcoin/bitcoin/pull/28165#discussion_r1292945676)
The `header` argument no longer exists (as the caller doesn't have any notion of headers anymore, that's local to the transport implementation). Instead there is an `m_header_to_send` variable, but it's reused across messages, so (repeated) reserving makes no sense.

📝 stratospher opened a pull request: "crypto: BIP324 ciphersuite follow-up"
(https://github.com/bitcoin/bitcoin/pull/28267)
follow-up to #28008.
* move `dummy_tag` variable in FSChaCha20Poly1305 crypto_tests outside of the loop to be reused every time
* use easy to read `cipher.last()` in `AEADChaCha20Poly1305::Decrypt()`
* comment for initiator in `BIP324Cipher::Initialize()`
* systematically damage ciphertext with bit positions in bip324_tests
* use 4095 max bytes for `aad` in bip324 fuzz test

💬 stratospher commented on pull request "Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305":
(https://github.com/bitcoin/bitcoin/pull/28263#issuecomment-1676634167)
so split off the last commit into #28267 since they aren't related to the fuzz test. (included https://github.com/bitcoin/bitcoin/pull/28008#discussion_r1277460913 and https://github.com/bitcoin/bitcoin/pull/28008#discussion_r1283327643 there)

thinking about https://github.com/bitcoin/bitcoin/pull/28263#discussion_r1292869677. will address it soon.

💬 stratospher commented on pull request "BIP324 ciphersuite":
(https://github.com/bitcoin/bitcoin/pull/28008#discussion_r1292949591)
done in #28267.

💬 stratospher commented on pull request "BIP324 ciphersuite":
(https://github.com/bitcoin/bitcoin/pull/28008#discussion_r1292949659)
done in #28267.

💬 jonatack commented on pull request "p2p: bugfixes, logic and logging improvements":
(https://github.com/bitcoin/bitcoin/pull/28248#issuecomment-1676644423)
Updated to propose fixes for the issues observed with the improved logging.

💬 sipa commented on pull request "crypto: BIP324 ciphersuite follow-up":
(https://github.com/bitcoin/bitcoin/pull/28267#issuecomment-1676645268)
utACK d22d5d925c000bf25ad2410ca66c4c21eea75004

⚠️ Rlavington opened an issue: "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. "
(https://github.com/bitcoin/bitcoin/issues/28268)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

Hello developers,

I know that you probably think that this is so obvious and basic but it needs to be said.

When a new person wants to run a full BTC node on their computer for the first time can you make it very obvious to that person that the Bitcoin Core program needs to be downloaded and installed onto their "C" drive o
...

💬 BitcoinErrorLog commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1676755450)
> Do you have an actual example of a real-world online merchant that accepts unconfirmed transactions for something of value immediately? Please provide a URL so we can check. I _still_ have not found such an example. GAP600 has claimed to have such customers. But so far their claims have not checked out. Without such an example your claim that you "personally value onchain payment use cases" is not relevant.

Many examples of 0conf acceptance have been provided, with consistency across years.
...

💬 fanquake commented on pull request "crypto: BIP324 ciphersuite follow-up":
(https://github.com/bitcoin/bitcoin/pull/28267#issuecomment-1676834229)
cc @theStack

💬 glozow commented on pull request "test: tx orphan handling":
(https://github.com/bitcoin/bitcoin/pull/28199#discussion_r1293136573)
Good point, moved from TestFramework to TestNode

💬 samyan commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676912956)
Anyways you can install the program in C and put the node database in other drive.

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#discussion_r1293164677)
Yes, I'll remove it in a follow-up

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#issuecomment-1676923241)
> I also ran the task locally (although on macOS I had to enter the container and manually install clang with arm support).

Yeah, that's unrelated, because I only modify the cirrus yml, not the CI task config. Maybe create a separate issue, though I won't be able to help, since I don't have or use macOS.



> One question below and also I'm wondering if the output of "include-what-you-use" is used at all? It makes a lot of suggestions but none of that counts as errors?

Yeah, that is on
...

💬 MarcoFalke commented on pull request "ci: Move tidy to persistent worker":
(https://github.com/bitcoin/bitcoin/pull/28214#discussion_r1293174314)
The reason is that the ENV only sets one env var, which can (and is) also be done directly in the screen command.

`RESTART_CI_DOCKER_BEFORE_RUN=1 screen cirrus ...`

💬 MarcoFalke commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676939986)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base. General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.

💬 MarcoFalke commented on pull request "crypto: BIP324 ciphersuite follow-up":
(https://github.com/bitcoin/bitcoin/pull/28267#discussion_r1293191092)
When touching this file, could add the missing include?

```
bip324.h should add these lines:
#include <array>

💬 MarcoFalke commented on pull request "crypto: BIP324 ciphersuite follow-up":
(https://github.com/bitcoin/bitcoin/pull/28267#discussion_r1293193336)
See the full iwyu output: https://api.cirrus-ci.com/v1/task/4946847257591808/logs/ci.log (Search for `$filename should ` or `$filename has the correct`)

(Same for `crypto/chacha20poly1305.cpp`)

💬 Rlavington commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676972723)
> Anyways you can install the program in C and put the node database in other drive.

That's exactly what I do. Because I don't want to use up all of the space on my computer's hard drive.

Untill the price of SSDs come down, I will upgrade.

💬 MarcoFalke commented on issue "Make it very obvious to the new people that the Bitcoin Core program first needs to be installed and run on the "C" drive. ":
(https://github.com/bitcoin/bitcoin/issues/28268#issuecomment-1676978866)
I guess your issue is about the GUI choose-direcory dialog? If yes, mind creating an issue in the GUI repo? Or even better, a pull request with your suggested changes?