💬 ChrisMartl commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1729376836)
#https://github.com/luke-jr/bitcoin/pull/10/commits/669cdb01e75c432501f096e752a0342caf08d4a0

💬 ChrisMartl commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1729401962)
#https://github.com/luke-jr/bitcoin/pull/10

💬 ChrisMartl commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#discussion_r1334435950)
Also with this #https://github.com/bitcoin/bitcoin/pull/28408#discussion_r1332912845 suggestion?

💬 maflcko commented on pull request "AssumeUTXO follow-ups":
(https://github.com/bitcoin/bitcoin/pull/28562#discussion_r1386889955)
Another report, which could replicate the crash, see #https://github.com/bitcoin/bitcoin/pull/28791

💬 maflcko commented on pull request "Use serialization parameters for CTransaction":
(https://github.com/bitcoin/bitcoin/pull/28438#issuecomment-1818877296)
> SpanReader

Done in #28912. I guess the `CDataStream` one can be done as part of #https://github.com/bitcoin/bitcoin/pull/28451

💬 sr-gi commented on pull request "test: adds outbound eviction functional tests, updates comment in ConsiderEviction":
(https://github.com/bitcoin/bitcoin/pull/29122#discussion_r1537843593)
Fixed it by popping from `last_message`, may open a followup simplifying it after #https://github.com/bitcoin/bitcoin/issues/18614 gets fixed

💬 maflcko commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-2069109399)
> Can you add a note to `doc/build-osx.md` that users of macOS < 13 need to install `clang` via homebrew?

#https://github.com/bitcoin/bitcoin/issues/29918 is an unrelated issue existing on current master, so I think a separate pull request would be more appropriate. Also, I don't have or use macOS/Apple, so someone else creating that pull request would be beneficial.

💬 maflcko commented on pull request "WIP: Fix coinstatsindex overflow issue":
(https://github.com/bitcoin/bitcoin/pull/26426#issuecomment-2199292529)
Closing for now due to inactivity for 1.5 years. #https://github.com/bitcoin/bitcoin/issues/26362 remains open and can be used for discussion. This change can be reopened or recreated as a new pull request.

💬 Sjors commented on pull request "wallet: fix crash during migration due to invalid multisig descriptors":
(https://github.com/bitcoin/bitcoin/pull/31378#issuecomment-2553194280)
Is this now pending #31495 instead of the closed #https://github.com/bitcoin/bitcoin/pull/30328?

💬 maflcko commented on issue "Assertion pindexPrev && pindexPrev == chainstate.m_chain.Tip() when running regtest":
(https://github.com/bitcoin/bitcoin/issues/31562#issuecomment-2561221830)
Thx, #https://github.com/bitcoin/bitcoin/pull/31563 should fix the assert crash

📝 rkrux opened a pull request: "wallet: remove redundant `Assert` call when block is disconnected"
(https://github.com/bitcoin/bitcoin/pull/32153)
It was highlighted in a PR discussion previously that the recently moved `Assert` macro call inside the block disconnected loop had been redundant for quite a while because of the presence of the `assert` macro call at the start of the function. Therefore, it is removed now.

refs #https://github.com/bitcoin/bitcoin/pull/31757#discussion_r1995416821

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
...

💬 hodlinator commented on pull request "wallet: remove redundant `Assert` call when block is disconnected":
(https://github.com/bitcoin/bitcoin/pull/32153#discussion_r2017695755)
If you re-touch, I think it would be more correct to remove the `#` in the commit message at the beginning of
`refs #https://github.com/bitcoin/bitcoin/pull/31757#discussion_r1995416821`
since it is a link and not a PR/Issue number.