💬 jonatack commented on pull request "Remove C-style const-violating cast, Use reinterpret_cast":
(https://github.com/bitcoin/bitcoin/pull/28127#issuecomment-1646980929)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/28127#issuecomment-1646980929)
Concept ACK
💬 Ayms commented on pull request "Remove arbitrary restrictions on OP_RETURN by default":
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1646981789)
@luke-jr the idea is not to store a video on bitcoin but indeed a reference to it like bittorrent
Now if someone wants to store things in a full block nobody can avoid this
Then this change just make things easier to avoid unwanted practices
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1646981789)
@luke-jr the idea is not to store a video on bitcoin but indeed a reference to it like bittorrent
Now if someone wants to store things in a full block nobody can avoid this
Then this change just make things easier to avoid unwanted practices
📝 bitcoinfinancier converted_to_draft a pull request: "v 25.0.3"
(https://github.com/bitcoin/bitcoin/pull/28135)
semgrep ci integration for security and optimized images with AI to reduce storage and enhance quality.
(https://github.com/bitcoin/bitcoin/pull/28135)
semgrep ci integration for security and optimized images with AI to reduce storage and enhance quality.
👋 bitcoinfinancier's pull request is ready for review: "v 25.0.3"
(https://github.com/bitcoin/bitcoin/pull/28135)
(https://github.com/bitcoin/bitcoin/pull/28135)
📝 bitcoinfinancier converted_to_draft a pull request: "v 25.0.3"
(https://github.com/bitcoin/bitcoin/pull/28135)
semgrep ci integration for security and optimized images with AI to reduce storage and enhance quality.
(https://github.com/bitcoin/bitcoin/pull/28135)
semgrep ci integration for security and optimized images with AI to reduce storage and enhance quality.
💬 russeree commented on issue "Bitcoin Core v25.0 Crashes":
(https://github.com/bitcoin/bitcoin/issues/28119#issuecomment-1646990896)
Corrupted timechain or hardware issue.
```
2023-07-23T14:28:38Z ERROR: ReadBlockFromDisk: Deserialize or I/O error - AutoFile::read: fread failed: iostream error at FlatFilePos(nFile=9, nPos=53762556)
2023-07-23T14:28:38Z *** Failed to read block
2023-07-23T14:28:38Z Error: A fatal internal error occurred, see debug.log for details
```
Rhe broken file is nfile = is the blk0009.dat. This could be a software or hardware issue.
To debug and fix this issue there are few possible solut
...
(https://github.com/bitcoin/bitcoin/issues/28119#issuecomment-1646990896)
Corrupted timechain or hardware issue.
```
2023-07-23T14:28:38Z ERROR: ReadBlockFromDisk: Deserialize or I/O error - AutoFile::read: fread failed: iostream error at FlatFilePos(nFile=9, nPos=53762556)
2023-07-23T14:28:38Z *** Failed to read block
2023-07-23T14:28:38Z Error: A fatal internal error occurred, see debug.log for details
```
Rhe broken file is nfile = is the blk0009.dat. This could be a software or hardware issue.
To debug and fix this issue there are few possible solut
...
💬 ariard commented on pull request "Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1646993842)
On the first line of arguments, I think zero-conf business acceptance have the option to deploy additional full-nodes with good transaction-relay peering to obtain a reasonable view of network mempools, and therefore increase their odds of seeing a double-spend of a confirmation of interest. In practice, zero-conf applications have risk threshold, once those thresholds are reached they will deactivate zero-conf acceptance.
On the second line or arguments, mempool consistency with miners is be
...
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1646993842)
On the first line of arguments, I think zero-conf business acceptance have the option to deploy additional full-nodes with good transaction-relay peering to obtain a reasonable view of network mempools, and therefore increase their odds of seeing a double-spend of a confirmation of interest. In practice, zero-conf applications have risk threshold, once those thresholds are reached they will deactivate zero-conf acceptance.
On the second line or arguments, mempool consistency with miners is be
...
💬 ariard commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1271603144)
> Can you give a concrete example of a future extended format that might interfere with the 0x00 + unstructured proposal?
Sure any future serialization format where the semantic “tag” is encoded on more than 8-bit to allow more than 256 types of payload without having to picked up which are the “most-used” 256 one when the consensus change. This is actually the serialization format on which the TLV proposal of the annex (with some other discussed tweaks for the length), see comment above `Va
...
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1271603144)
> Can you give a concrete example of a future extended format that might interfere with the 0x00 + unstructured proposal?
Sure any future serialization format where the semantic “tag” is encoded on more than 8-bit to allow more than 256 types of payload without having to picked up which are the “most-used” 256 one when the consensus change. This is actually the serialization format on which the TLV proposal of the annex (with some other discussed tweaks for the length), see comment above `Va
...
💬 ariard commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1271606493)
> If it isn't that much of an increase, is it worth adding extra code for it?
From my experience of DoS discussion on the Core-side, even if we’re able to come with sound evaluation of the worst-case inputs payload one might submit during a time period, the host performance are always an unknown as you have low perf Umbrel and Raspy, and somehow preserving their processing capabilities has always been pursued during Bitcoin Core development for technical decentralization purpose, from my unde
...
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1271606493)
> If it isn't that much of an increase, is it worth adding extra code for it?
From my experience of DoS discussion on the Core-side, even if we’re able to come with sound evaluation of the worst-case inputs payload one might submit during a time period, the host performance are always an unknown as you have low perf Umbrel and Raspy, and somehow preserving their processing capabilities has always been pursued during Bitcoin Core development for technical decentralization purpose, from my unde
...
💬 ariard commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1271609885)
For the timelocked vaults, yes there is a single party using presigned txes so it shouldn’t apply. For the other use-case e.g anchoring symbolic data in the chain, I think you might have multiple parties contributing to the transaction, though I’m less knowledgeable about those use-cases to be honest.
If there is the current annex deployment is not targeted for multi-party protocols, yes we don’t have discuss of the impact of annex DoS on fee-bumping reserve.
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1271609885)
For the timelocked vaults, yes there is a single party using presigned txes so it shouldn’t apply. For the other use-case e.g anchoring symbolic data in the chain, I think you might have multiple parties contributing to the transaction, though I’m less knowledgeable about those use-cases to be honest.
If there is the current annex deployment is not targeted for multi-party protocols, yes we don’t have discuss of the impact of annex DoS on fee-bumping reserve.
✅ achow101 closed a pull request: "v 25.0.3"
(https://github.com/bitcoin/bitcoin/pull/28135)
(https://github.com/bitcoin/bitcoin/pull/28135)
📝 achow101 locked a pull request: "v 25.0.3"
(https://github.com/bitcoin/bitcoin/pull/28135)
semgrep ci integration for security and optimized images with AI to reduce storage and enhance quality.
(https://github.com/bitcoin/bitcoin/pull/28135)
semgrep ci integration for security and optimized images with AI to reduce storage and enhance quality.
💬 ariard commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#issuecomment-1647044629)
> I agree that use cases can help guide the decision making in this PR. That's why I created the demo/explanation mentioned in the PR description: https://github.com/joostjager/annex-covenants.
I understand how the spend transaction can be re-built from the `annex-covenant` stateless tool, and on my side I can opine on the interest of using the chain as a reliable backup fro critical information enabling vaulted funds to be rebuilt, only from standard tools.
I still have a concern on the e
...
(https://github.com/bitcoin/bitcoin/pull/27926#issuecomment-1647044629)
> I agree that use cases can help guide the decision making in this PR. That's why I created the demo/explanation mentioned in the PR description: https://github.com/joostjager/annex-covenants.
I understand how the spend transaction can be re-built from the `annex-covenant` stateless tool, and on my side I can opine on the interest of using the chain as a reliable backup fro critical information enabling vaulted funds to be rebuilt, only from standard tools.
I still have a concern on the e
...
📝 jonatack opened a pull request: "refactor: move GetServicesNames from rpc/util.{h,cpp} to rpc/net.cpp"
(https://github.com/bitcoin/bitcoin/pull/28136)
Move `GetServicesNames()` from `rpc/util.{h,cpp}` to `rpc/net.cpp`, as it is only called from that compilation unit and has no related functions where it is currently, which further allows not including `protocol.h` in that util lib.
This alleviates needlessly compiling both `GetServicesNames()` and the 500 lines of `protocol.h` in the 36 other files that include `rpc/util.h`.
(https://github.com/bitcoin/bitcoin/pull/28136)
Move `GetServicesNames()` from `rpc/util.{h,cpp}` to `rpc/net.cpp`, as it is only called from that compilation unit and has no related functions where it is currently, which further allows not including `protocol.h` in that util lib.
This alleviates needlessly compiling both `GetServicesNames()` and the 500 lines of `protocol.h` in the 36 other files that include `rpc/util.h`.
👋 jonatack's pull request is ready for review: "refactor: move GetServicesNames from rpc/util.{h,cpp} to rpc/net.cpp"
(https://github.com/bitcoin/bitcoin/pull/28136)
(https://github.com/bitcoin/bitcoin/pull/28136)
💬 MarcoFalke commented on issue "Bitcoin Core v25.0 Crashes":
(https://github.com/bitcoin/bitcoin/issues/28119#issuecomment-1647289947)
> Delete all files blk0009.dat and greater. Then also delete rev0009.dat and every rev*.dat with a greater number. This method is essentially will force you to redownload the corrupt file and every block after. This should work with certainty.
There is no need, nor recommendation, to do this manually. A simple `-reindex` (instead of `-reindex-chainstate`) is enough to do rewrite and check all block files on storage.
(https://github.com/bitcoin/bitcoin/issues/28119#issuecomment-1647289947)
> Delete all files blk0009.dat and greater. Then also delete rev0009.dat and every rev*.dat with a greater number. This method is essentially will force you to redownload the corrupt file and every block after. This should work with certainty.
There is no need, nor recommendation, to do this manually. A simple `-reindex` (instead of `-reindex-chainstate`) is enough to do rewrite and check all block files on storage.
💬 MarcoFalke commented on pull request "Remove C-style const-violating cast, Use reinterpret_cast":
(https://github.com/bitcoin/bitcoin/pull/28127#issuecomment-1647295139)
> Can clang-tidy or other tools be helpful in catching such cases in the future?
Yeah, you can use `cppcoreguidelines-pro-type-cstyle-cast` if you want. But that will produce some more warnings in places where a `const` is intentionally and correctly removed. Also, it will warn in some places that should use a `Span` instead. However, I think using `Span` in more places or other fixes can be left for follow-ups.
(https://github.com/bitcoin/bitcoin/pull/28127#issuecomment-1647295139)
> Can clang-tidy or other tools be helpful in catching such cases in the future?
Yeah, you can use `cppcoreguidelines-pro-type-cstyle-cast` if you want. But that will produce some more warnings in places where a `const` is intentionally and correctly removed. Also, it will warn in some places that should use a `Span` instead. However, I think using `Span` in more places or other fixes can be left for follow-ups.
💬 MarcoFalke commented on pull request "fuzz: Re-enable symbolize=1 in ASAN_OPTIONS":
(https://github.com/bitcoin/bitcoin/pull/28124#issuecomment-1647302661)
@emc99 Usually the issue tracker is used to track technical issues and code changes related to the Bitcoin Core code base. General (bitcoin) questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.
(https://github.com/bitcoin/bitcoin/pull/28124#issuecomment-1647302661)
@emc99 Usually the issue tracker is used to track technical issues and code changes related to the Bitcoin Core code base. General (bitcoin) questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.
💬 russeree commented on issue "Bitcoin Core v25.0 Crashes":
(https://github.com/bitcoin/bitcoin/issues/28119#issuecomment-1647309700)
> > Delete all files blk0009.dat and greater. Then also delete rev0009.dat and every rev*.dat with a greater number. This method is essentially will force you to redownload the corrupt file and every block after. This should work with certainty.
>
> There is no need, nor recommendation, to do this manually. A simple `-reindex` (instead of `-reindex-chainstate`) is enough to do rewrite and check all block files on storage.
Does this still work if the actual disk sector is corrupt or would
...
(https://github.com/bitcoin/bitcoin/issues/28119#issuecomment-1647309700)
> > Delete all files blk0009.dat and greater. Then also delete rev0009.dat and every rev*.dat with a greater number. This method is essentially will force you to redownload the corrupt file and every block after. This should work with certainty.
>
> There is no need, nor recommendation, to do this manually. A simple `-reindex` (instead of `-reindex-chainstate`) is enough to do rewrite and check all block files on storage.
Does this still work if the actual disk sector is corrupt or would
...
💬 MarcoFalke commented on issue "ci: Future of macOS and Windows MSVC CI tasks":
(https://github.com/bitcoin/bitcoin/issues/28098#issuecomment-1647312889)
> CircleCI looks better than others
Can you elaborate on this? The free plan would give less than 10 hours of macOS and Windows per month. And the paid plan doesn't look cheaper than Cirrus CI, does it?
(https://github.com/bitcoin/bitcoin/issues/28098#issuecomment-1647312889)
> CircleCI looks better than others
Can you elaborate on this? The free plan would give less than 10 hours of macOS and Windows per month. And the paid plan doesn't look cheaper than Cirrus CI, does it?