✅ fanquake closed an issue: "libsecp CI failure [no wallet, libbitcoinkernel] [focal]"
(https://github.com/bitcoin/bitcoin/issues/28079)

🚀 fanquake merged a pull request: "subtree: update libsecp256k1 to latest master"
(https://github.com/bitcoin/bitcoin/pull/28093)

💬 hebasto commented on issue "guix: re-enable exported symbol checking for RISC-V":
(https://github.com/bitcoin/bitcoin/issues/28095#issuecomment-1641848538)
Historically, symbol checking for RISC-V was skipped from the [beginning](https://github.com/bitcoin/bitcoin/pull/13724) for the following [reason](https://github.com/bitcoin/bitcoin/pull/13724#issuecomment-413652059):
> Need to skip RISC-V for now, the linker would export so many symbols.

💬 fanquake commented on issue "guix: re-enable exported symbol checking for RISC-V":
(https://github.com/bitcoin/bitcoin/issues/28095#issuecomment-1641850050)
I don't think that's relevant anymore? I've listed the exported symbols above. It's 3.

⚠️ fanquake opened an issue: "win: non-static libssp in libbitcoinconsensus DLL"
(https://github.com/bitcoin/bitcoin/issues/28104)
If you Guix build for Windows, and call objdump on `libbitcoinconsensus-0.dll`, you'll find it uses a non-static libssp:
```bash
objdump -x src/.libs/libbitcoinconsensus-0.dll
...
The Import Tables (interpreted .idata section contents)
vma: Hint Time Forward DLL First
Table Stamp Chain Name Thunk
00263000 00263050 00000000 00000000 0026409c 00263490

DLL Name: libssp-0.dll
vma: Hint/Ord Member-Name Bound-To
2638d0 3 _
...

💬 MarcoFalke commented on pull request "test: move remaining rand code from util/setup_common to util/random":
(https://github.com/bitcoin/bitcoin/pull/27425#issuecomment-1641903050)
My suggestion, for future reference:

```diff
commit bfaa758ca1e690ad6d2ea34b0213f7aedc2645bb
Author: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Wed Jul 19 12:41:00 2023 +0200

scripted-diff: Rename global test random context to g_mock_rand

Instead of calling it "insecure", clarify that it is mocked, so that
test failures due to the seed are hopefully more obviously attributed to
it.

-BEGIN VERIFY SCRIPT-
sed -i 's/g_insecure_rand_ctx/g_moc
...

🚀 fanquake merged a pull request: "rpc: doc: Added `longpollid` and `data` params to `template_request`"
(https://github.com/bitcoin/bitcoin/pull/28056)

✅ fanquake closed an issue: "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate"
(https://github.com/bitcoin/bitcoin/issues/27998)

📝 MarcoFalke opened a pull request: "doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC"
(https://github.com/bitcoin/bitcoin/pull/28105)
This is a follow-up to commit 7b850bc2a1cd8547a2dbb5a18173f53439601220. While the test case no longer reproduces, the general class of `-fstack-reuse` bugs still exists in all versions of GCC. The workaround can never be removed, unless the whole class of bugs is fixed.

🚀 fanquake merged a pull request: "test: remove race in the user-agent reception check"
(https://github.com/bitcoin/bitcoin/pull/27986)

👍 fanquake approved a pull request: "test: Add missing `set -ex` to ci/lint/06_script.sh"
(https://github.com/bitcoin/bitcoin/pull/28103#pullrequestreview-1536890199)
ACK ffff4b5dc57c32bf759b705530c1368de4aa787e

🚀 fanquake merged a pull request: "depends: xcb-proto 1.15.2"
(https://github.com/bitcoin/bitcoin/pull/28097)

💬 jonatack commented on pull request "test: move remaining rand code from util/setup_common to util/random":
(https://github.com/bitcoin/bitcoin/pull/27425#issuecomment-1641941150)
> My suggestion, for future reference:

Thank you, will have a look.

📝 MarcoFalke converted_to_draft a pull request: "ci: Use qemu-user through container engine"
(https://github.com/bitcoin/bitcoin/pull/28087)
Currently the CI containers always run on the host architecture, and only wrap `bitcoind` into `qemu-user` when needed. This has many issues:

* The `i386` tasks can not be run on non-x86 hosts.
* `config.guess` isn't present when building the CI image, which is fine. But it prints a warning, see https://github.com/bitcoin/bitcoin/pull/27739#pullrequestreview-1446580353
* The python tests are run on the host architecture, making it harder to find architecture specific bugs. See for example h
...

💬 pinheadmz commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1267962992)
thanks, that is leftover from older version

💬 pinheadmz commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1267964112)
sure thanks

💬 jonatack commented on pull request "I2P: also sleep after errors in Accept() & destroy the session if we get "Session was closed"":
(https://github.com/bitcoin/bitcoin/pull/28077#issuecomment-1641960701)
> this unexpected behavior causes Bitcoin Core to log way too many messages.

The log flooding rate is very high, but perhaps the more severe issue fixed here is that the I2P connections remain down until the router is manually stopped and then restarted, during which time the log flooding continues, and for anyone running `onlynet=i2p`, it would mean their node is effectively offline until they notice it and take action.

With this fix, the connections recover on their own, like they do for
...

💬 jonatack commented on pull request "validation: use noexcept instead of deprecated throw()":
(https://github.com/bitcoin/bitcoin/pull/28090#issuecomment-1641966462)
Post-merge ack

💬 pinheadmz commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1267981369)
done thanks. agreed about the smell. lets lock down the expected behavior with tests and then we can clean up in future PR.

💬 stickies-v commented on pull request "net processing, refactor: Decouple PeerManager from gArgs":
(https://github.com/bitcoin/bitcoin/pull/27499#discussion_r1267987502)
As discussed offline, what I meant with "leave it as is" is to not move banman in this PR, i.e. reverting the change in this PR.