💬 sipa commented on pull request "Add support for RFC8439 variant of ChaCha20":
(https://github.com/bitcoin/bitcoin/pull/27985#issuecomment-1627726804)
@theStack Cherrypicked the first commit. I don't think the second one adds that much, as presumably there is no way the output can be correct if the internal state is wrong.

💬 furszy commented on issue "migratewallet crashes (wallet/scriptpubkeyman.cpp:1915: std::optional<MigrationData> wallet::LegacyScriptPubKeyMan::MigrateToDescriptor(): Assertion `IsMine(desc_spk) != ISMINE_NO' failed.)":
(https://github.com/bitcoin/bitcoin/issues/28057#issuecomment-1627746019)
To recover from the error, use the wallet backup. Can find it inside the directory of the wallet that you are trying to migrate e.g. `/wallets/wallet_name/wallet_name-<timestamp>.legacy.bak`.

The issue seems to be related to one of your imported scripts. Would be good to gather more information about the script type. So we can check under which circumstances the legacy spkm `IsMine` return false for a script contained by the wallet.

If you can, try applying this patch and re-run the migrat
...

💬 iemafzalhassan commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1627748360)
hey i am a newbie can anyone guide me what to do next to become a first contributor (this is my first project)

💬 jonatack commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1627763433)
> hey i am a newbie can anyone guide me what to do next to become a first contributor (this is my first project)

Hi @iemafzalhassan (and other future contributors), I suggest the articles section of https://jonatack.github.io.

💬 iemafzalhassan commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1627775797)
> > hey i am a newbie can anyone guide me what to do next to become a first contributor (this is my first project)
>
> Hi @iemafzalhassan (and other future contributors), I suggest the articles section of https://jonatack.github.io.

Thnkew so much 🤩🥳

💬 ItIsOHM commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1627778706)
> > hey i am a newbie can anyone guide me what to do next to become a first contributor (this is my first project)
>
> Hi @iemafzalhassan (and other future contributors), I suggest the articles section of https://jonatack.github.io.

Thanks a lot for this @jonatack!

💬 ItIsOHM commented on pull request "[WIP] rpc: doc: Added `longpollid` and `data` params to `template_request` #27998":
(https://github.com/bitcoin/bitcoin/pull/28056#issuecomment-1627779352)
> This doesn't compile. Ideally, you compile and test any changes locally before opening a pull request.

I see, I'll try to compile it on my end and will let you know if there's any issue. Also, can you please check the description for the new parameters added if they need any changes?

👍 theStack approved a pull request: "test: make assumeUTXO test capture the expected fatal error"
(https://github.com/bitcoin/bitcoin/pull/28050#pullrequestreview-1520939942)
Tested ACK 3e8bf2e10c26ef9c2f58307b523e4b674ac97a2c

💬 luke-jr commented on pull request "blockstorage: XOR blocksdir *.dat files":
(https://github.com/bitcoin/bitcoin/pull/28052#issuecomment-1627785475)
AFAIK there is software which reads these files intentionally. IMO they can be expected to adapt, but having the option to disable it seems like a good idea in case they aren't ready right away.

💬 luke-jr commented on pull request "[WIP] rpc: doc: Added `longpollid` and `data` params to `template_request` #27998":
(https://github.com/bitcoin/bitcoin/pull/28056#discussion_r1257521442)
```suggestion
{"longpollid", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Delay processing request until the result would vary significantly from the \"longpollid\" of a prior template."},
```

It doesn't necessarily imply the previous template is expired.

💬 luke-jr commented on pull request "[WIP] rpc: doc: Added `longpollid` and `data` params to `template_request` #27998":
(https://github.com/bitcoin/bitcoin/pull/28056#discussion_r1257521831)
```suggestion
{"data", RPCResult::Type::STR_HEX, RPCArg::Optional::OMITTED, "Proposed block data to check, encoded in hexadecimal; valid only for mode=\"proposal\""},
```

✅ Brotcrunsher closed a pull request: "Supporting parameter "h" and "?" in -netinfo."
(https://github.com/bitcoin/bitcoin/pull/27830)

💬 ItIsOHM commented on pull request "[WIP] rpc: doc: Added `longpollid` and `data` params to `template_request` #27998":
(https://github.com/bitcoin/bitcoin/pull/28056#issuecomment-1627802501)
> This doesn't compile. Ideally, you compile and test any changes locally before opening a pull request.

Hey so I was trying to build it after adding the changes you suggested, but i'm getting this error in VS, as I'm building on Windows 11. Can you please help what this means?

I followed [this](https://github.com/bitcoin/bitcoin/blob/master/build_msvc/README.md) guide and opened `bitcoin.s
...

💬 sipa commented on pull request "[WIP] rpc: doc: Added `longpollid` and `data` params to `template_request` #27998":
(https://github.com/bitcoin/bitcoin/pull/28056#issuecomment-1627806159)
I strongly recommend not building in Windows/MSVC, as it's a venture on its own to get that to work. In a Linux VM, or WSL2, it should be fairly straightforward.

💬 ItIsOHM commented on pull request "[WIP] rpc: doc: Added `longpollid` and `data` params to `template_request` #27998":
(https://github.com/bitcoin/bitcoin/pull/28056#issuecomment-1627807815)
> I strongly recommend not building in Windows/MSVC, as it's a venture on its own to get that to work. In a Linux VM, or WSL2, it should be fairly straightforward.

Ohh I see! Then I'll install WSL2 and try building it from there. I suppose [this](https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md) guide should be enough to get it working?

💬 techy2 commented on pull request "fix: delay in TimeOffset applied to AdjustedTime caused by send/receive message queues, correct pointer alignment issue":
(https://github.com/bitcoin/bitcoin/pull/28010#issuecomment-1627833757)
Hola Marco
Sorry, I've been away for a while. Please continue discussion as required

📝 Dindin1992 opened a pull request: "Dindin"
(https://github.com/bitcoin/bitcoin/pull/28058)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ Dindin1992 closed a pull request: "Dindin"
(https://github.com/bitcoin/bitcoin/pull/28058)

📝 fanquake locked a pull request: "Dindin"
(https://github.com/bitcoin/bitcoin/pull/28058)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 denavila commented on pull request "wallet: Deniability API (Unilateral Transaction Meta-Privacy)":
(https://github.com/bitcoin/bitcoin/pull/27792#issuecomment-1628080840)
Hi @ishaanam and thank you for looking at my PR.
I do agree the implementation can be improved and your feedback helps me greatly.

Here are my thoughts regarding your concerns:
1) I thought about this problem too and indeed spending deniabilized outputs is somewhat challenging.
Obviously, if the user just HODLs, or spends less than a deniabilized UTXO, then all is good.
However if they spend larger amounts, more than one UTXOs would get picked up and that would reveal that they belong
...