💬 MarcoFalke commented on issue "The destructor of CCheckQueueControl may throw a exception ":
(https://github.com/bitcoin/bitcoin/issues/28033#issuecomment-1623201981)
What is `condition_error`?

💬 MarcoFalke commented on issue "The destructor of CCheckQueueControl may throw a exception ":
(https://github.com/bitcoin/bitcoin/issues/28033#issuecomment-1623240274)
Closing for now, but can be reopened when the outstanding questions have been answered.

✅ MarcoFalke closed an issue: "The destructor of CCheckQueueControl may throw a exception "
(https://github.com/bitcoin/bitcoin/issues/28033)

💬 MarcoFalke commented on issue "Unable to send funds":
(https://github.com/bitcoin/bitcoin/issues/28001#issuecomment-1623243536)
Closing for now. Leave a comment if this is still an issue.

✅ MarcoFalke closed an issue: "Unable to send funds"
(https://github.com/bitcoin/bitcoin/issues/28001)

💬 fanquake commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1623245433)
@FelixWeis were you able to perform a bisect here?

✅ fanquake closed a pull request: "Gitignore auto-generated Secp256k1 files"
(https://github.com/bitcoin/bitcoin/pull/28032)

💬 willcl-ark commented on issue "depends build fails macOS intel":
(https://github.com/bitcoin/bitcoin/issues/27977#issuecomment-1623264853)
Seems to work just fine out of the box on my macbook with clang16? Although technically this is not a totally fresh install of macos...

<details>
<summary> log </summary>

```sh
will@MBP in …/src/bitcoin/depends on  master [$?⇡]
₿ make NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 -j 4
Building native_ds_store...
running build
running build_py
creating build
creating build/lib
creating build/lib/ds_store
copying ds_store/store.py -> build/lib/ds_store
copying ds_store/__ini
...

💬 fanquake commented on issue "depends build fails macOS intel":
(https://github.com/bitcoin/bitcoin/issues/27977#issuecomment-1623269757)
Haven't looked into the issue here yet, but note that these packages will be removed as part of #27099.

👍 vasild approved a pull request: "net: support unix domain sockets for -proxy and -onion"
(https://github.com/bitcoin/bitcoin/pull/27375#pullrequestreview-1516100277)
ACK c3b0f137a9ccd894f2f1d287ccdab26310b3aaf2

Would be an excellent addition, thank you!

📝 MarcoFalke opened a pull request: "ci: Print full lscpu output"
(https://github.com/bitcoin/bitcoin/pull/28034)
Seems odd to withhold the other output, given that it may be useful to debug issues?

👍 vasild approved a pull request: "p2p: Diversify automatic outbound connections with respect to networks"
(https://github.com/bitcoin/bitcoin/pull/27213#pullrequestreview-1516160146)
ACK 1e65aae8068ecf313a7c3b176dfc1326b3b67fbe

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1623362830)
What is (was?) the reason for https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1611194968?

🚀 glozow merged a pull request: "wallet: Give deprecation warning when loading a legacy wallet"
(https://github.com/bitcoin/bitcoin/pull/27869)

💬 fanquake commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1623377574)
Now that #27869 has been merged. It might be time to no-longer mark the `migratewallet` RCP as "EXPERIMENTAL".

💬 MarcoFalke commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1623395575)
@fanquake Does it not need the performance fix for bdb wallets with a lot of keys first?

💬 fanquake commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1623400014)
> @fanquake Does it not need the performance fix for bdb wallets with a lot of keys first?

I'm not sure. However if we are going to ship this warning that instructs users to use `migratewallet`, I don't think we can leave it marked as experimental.

📝 MarcoFalke opened a pull request: "test: Ignore UTF-8 errors in assert_debug_log"
(https://github.com/bitcoin/bitcoin/pull/28035)
Fix two bugs:

* `debug_log_bytes` returned "an opaque number when in text mode" (https://docs.python.org/3/tutorial/inputoutput.html#methods-of-file-objects), not the number of bytes.
* `read()` fails in text mode when the unicode hasn't been fully written yet. Fixes https://github.com/bitcoin/bitcoin/issues/28030

Fix both bugs by using `"rb"` instead of `"utf-8"`, and by using a non-throwing decode helper.

💬 fanquake commented on pull request "guix: use GCC 12.2.0 to build releases":
(https://github.com/bitcoin/bitcoin/pull/27897#issuecomment-1623409890)
Sent some additional patches upstream, to update packages we use: https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00159.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00138.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00104.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00171.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00169.html.

💬 MarcoFalke commented on issue "wallet_importdescriptors.py: can't decode bytes in position 228861-228863: unexpected end of data":
(https://github.com/bitcoin/bitcoin/issues/28030#issuecomment-1623410610)
https://cirrus-ci.com/task/4872686879375360?logs=ci#L1867

```
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 440222: unexpected end of data