💬 fanquake commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618131355)
These are in a subtree. Which you can't modify. You'll need to send your changes upstream.

✅ fanquake closed a pull request: "typos on src files"
(https://github.com/bitcoin/bitcoin/pull/28022)

💬 hebasto commented on pull request "Drop macOS ForceActivation workaround":
(https://github.com/bitcoin-core/gui/pull/744#issuecomment-1618182696)
I think we can drop `-DOBJC_OLD_DISPATCH_PROTOTYPES=0` now. At least, the code compiles for me natively on macOS Ventura (arm64) and when cross-building on Ubuntu 23.04.

💬 criadoperez commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618230646)
Thanks @fanquake.
Can you please specify where I need to send the changes instead?

📝 chandrasekarachan opened a pull request: "Create bitcoinv"
(https://github.com/bitcoin/bitcoin/pull/28023)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 chandrasekarachan commented on pull request "Create bitcoinv":
(https://github.com/bitcoin/bitcoin/pull/28023#issuecomment-1618231058)
bitcoin

✅ fanquake closed a pull request: "Create bitcoinv"
(https://github.com/bitcoin/bitcoin/pull/28023)

📝 fanquake locked a pull request: "Create bitcoinv"
(https://github.com/bitcoin/bitcoin/pull/28023)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618232083)
> Can you please specify where I need to send the changes instead?

https://github.com/bitcoin-core/secp256k1

💬 criadoperez commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618234145)
I'll do that then. Thanks!

💬 willcl-ark commented on pull request "init: deduplicate added connections":
(https://github.com/bitcoin/bitcoin/pull/27804#issuecomment-1618247262)
Thanks Luke, I mostly agree (that this is a bit hacky). Implemented here currently is the "simplest" (could also read "dumbest") fix to the issue, whilst trying to avoid any using more mutexes and possibly introducing new thread safety issues etc.

As I see it the root cause is that we use two threads to make outbound connections simultaneously with no way of deduplicating except _after_ the connection is successful and the node is pushed onto `m_nodes`. This allows the race on node connection
...

💬 ItIsOHM commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1618251162)
> Absolutely, just open the PR whenever you feel ready, or ask away here if you have any problems you can't figure out.

Hey @stickies-v! So as a starter, I don't have bitcoin-cli working, so to do that I'm building the core with Visual Studio by following this guide : https://github.com/bitcoin/bitcoin/blob/master/build_msvc/README.md, is that alright or do I need to follow some other step to use `bitcoin-cli`?

📝 MarcoFalke opened a pull request: "ci: Remove deprecated container.greedy"
(https://github.com/bitcoin/bitcoin/pull/28024)
The option is to be phased out, so remove it to avoid relying on it. Update container.cpu and timeouts where needed.

💬 Ayush170-Future commented on pull request "init: adding check for : for -torcontrol flag":
(https://github.com/bitcoin/bitcoin/pull/28018#issuecomment-1618315720)
Tested this locally.

1. Any string that is not of the type `<host>:<port>` is rejected.
Example: `./src/bitcoind -torcontrol=1`.

2. Also works for Domain names.
Example: `./src/bitcoind -torcontrol=localhost:9051` is accepted.

3. But multiple instances of `:` are also accepted.
Example: `./src/bitcoind -torcontrol=localhost:9051:23` is also accepted.
This should also be avoided, right?


> Also another thing I wanted to clarify is that will `-torcontrol` always be in the forma
...

💬 hebasto commented on pull request "ci: Remove deprecated container.greedy":
(https://github.com/bitcoin/bitcoin/pull/28024#issuecomment-1618317711)
> The option is to be phased out,

It is still mentioned in https://cirrus-ci.org/guide/linux/#linux-containers.

💬 ItIsOHM commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1618323403)
Update: I downloaded and installed `Bitcoin Core`, which then helped me to run `bitcoind` and `bitcoin-cli`. I'll try to make the changes to a new branch :D

💬 stickies-v commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1618332163)
MSVC is one option, WSL another. See also https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md.

Build questions are a bit out of scope for this issue though, there's a fair amount of documentation online. Just downloading the binaries isn't enough to work on this, you need to compile it yourself to verify the changes are correct.

💬 Ayush170-Future commented on pull request "init: adding check for : for -torcontrol flag":
(https://github.com/bitcoin/bitcoin/pull/28018#discussion_r1250929352)
I believe here. You might additionally check the count of `:` characters in `socket_addr` and return an error if they are more than one.

🤔 Sjors reviewed a pull request: "[WIP] add a stratum v2 template provider"
(https://github.com/bitcoin/bitcoin/pull/27854#pullrequestreview-1511170547)
The PR description could use instructions on how to test this. Specifically I'd like to try it on mainnet against my vintage S9 with BraiinsOS+ (not sure which pools already support job negotiation/ announcement). This can of course point to existing documentation. [Config D](https://stratumprotocol.org/getting-started/#config-d-sv1-firmware--translation-proxy-jn-job-negotiator--sv2-pool) is close but it assumes regtest and running your own pool.

It will also be easier to test and review this
...

💬 Sjors commented on pull request "[WIP] add a stratum v2 template provider":
(https://github.com/bitcoin/bitcoin/pull/27854#discussion_r1250873859)
This should also mention the testnet, regtest and signet ports.