💬 Xekyo commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1247203795)
Thanks, went with your suggestion

💬 Xekyo commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1247221538)
I tried this change, and remembered why I put in the "discount" in the first place: I think I have incorporated the bump fees in the effective values before, so I need to know whether there is a difference between the sum of the bump fees and the combined inputs’ bump fee. I have an idea how to incorporate your suggestion, but I gotta try tomorrow.

📝 jonatack opened a pull request: "script, test: python typing and linter updates"
(https://github.com/bitcoin/bitcoin/pull/28009)
With these updates, `./test/lint/lint-python.py` and `./test/lint/lint-spelling.py` should be green again for developers using relatively recent Python dependencies, in particular mypy 0.991 (released 11/2022) and later. Please see the commit messages for details.

💬 achow101 commented on pull request "Fix transaction view/table":
(https://github.com/bitcoin-core/gui/pull/662#issuecomment-1613900091)
Reopening was requested.

📝 achow101 reopened a pull request: "Fix transaction view/table"
(https://github.com/bitcoin-core/gui/pull/662)
#204 reverted a necessary bugfix, and #205 introduced regressions since `setModel` resets column widths. Note that you need to delete your saved GUI config to see the fix, otherwise the prior widths are restored.

Before regressions:


After regressions / current master:

![Screenshot_20220905_233054 branch-22](https://user-images.githubusercontent
...

💬 luke-jr commented on pull request "Fix transaction view/table":
(https://github.com/bitcoin-core/gui/pull/662#issuecomment-1613900449)
Re-confirmed bug still exists, and rebased this fix.

💬 luke-jr commented on pull request "Bugfix: Address broken things around Peers detail view":
(https://github.com/bitcoin-core/gui/pull/677#discussion_r1247249570)
Doesn't seem worth splitting up such a minor change IMO

💬 luke-jr commented on pull request "Improve 'Requested Payments History' Multiselect":
(https://github.com/bitcoin-core/gui/pull/684#issuecomment-1613909123)
Would prefer the refactoring split into a different commit

💬 achow101 commented on pull request "Intro: Never change the prune checkbox after the user has touched it":
(https://github.com/bitcoin-core/gui/pull/658#issuecomment-1613914077)
Reopening by request

📝 achow101 reopened a pull request: "Intro: Never change the prune checkbox after the user has touched it"
(https://github.com/bitcoin-core/gui/pull/658)
Re-PR from https://github.com/bitcoin/bitcoin/pull/18729

Now includes a bugfix too (`-prune=2+` disabled the checkbox, but `-prune=0/1` did not; this behaviour is necessary since `-prune` overrides GUI settings)

💬 luke-jr commented on pull request "Intro: Never change the prune checkbox after the user has touched it":
(https://github.com/bitcoin-core/gui/pull/658#issuecomment-1613914668)
Rebased

💬 luke-jr commented on pull request "Intro: Never change the prune checkbox after the user has touched it":
(https://github.com/bitcoin-core/gui/pull/658#discussion_r1247255336)
Yes, removed it

💬 achow101 commented on pull request "net: do not `break` when `addr` is not from a distinct network group":
(https://github.com/bitcoin/bitcoin/pull/27863#issuecomment-1613921442)
ACK 5fa4055452861ca1700008e1761815e88b29fae7

Agree that `continue` makes sense if we're simply unlucky.

🚀 achow101 merged a pull request: "net: do not `break` when `addr` is not from a distinct network group"
(https://github.com/bitcoin/bitcoin/pull/27863)

💬 techy2 commented on pull request "fix: delay in TimeOffset applied to AdjustedTime caused by send/recei…":
(https://github.com/bitcoin/bitcoin/pull/28007#issuecomment-1613931101)
Pointer offset error not flagged in my build. Will close this pull and open a new one with issue resolved.
Testing solution now.

✅ techy2 closed a pull request: "fix: delay in TimeOffset applied to AdjustedTime caused by send/recei…"
(https://github.com/bitcoin/bitcoin/pull/28007)

💬 luke-jr commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1247267535)
Won't this result in the undo files not getting flushed when expected?

💬 mzumsande commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1247276703)
See https://github.com/bitcoin/bitcoin/pull/27039#pullrequestreview-1320217718 for my thoughts on this, a similar explanation was added to the OP.

💬 ryanofsky commented on pull request "refactor: Move sock from util to common":
(https://github.com/bitcoin/bitcoin/pull/27989#issuecomment-1613966139)
Concept -0. I don't think it's a good thing to remove everything from util that isn't used by the kernel. I think util/ is a good home for general purpose code providing basic data structures and cross platform capabilities, and I think common/ is good home for project-specific code that needs to be shared between bitcoind, bitcoin-cli, and bitcoin-wallet.

It can make sense to move code from util/ to common/ if the code relies on an external dependency, or has global variables, or something e
...

📝 techy2 opened a pull request: "fix: delay in TimeOffset applied to AdjustedTime caused by send/receive message queues, correct pointer alignment issue"
(https://github.com/bitcoin/bitcoin/pull/28010)
On busy VPS and shared host with limited resources, the time between when a messages is sent to the tcpip send or receive
queue and when it is sent in the case of send queue, or when it is processed (ProcessMessage) can be in excess of 30 seconds.
This delay introduces a skew in AdjustedTime.

For the receive queue, the post processing uses the receive time prior to entering the queue to calculate TimeOffset rather than Now() which currently includes the delay in the queue.

For the sen
...