💬 MarcoFalke commented on pull request "refactor: Continue moving application data from CNode to Peer":
(https://github.com/bitcoin/bitcoin/pull/26621#issuecomment-1611188048)
Needs rebase if still relevant

💬 MarcoFalke commented on pull request "p2p: Drop m_recently_announced_invs bloom filter":
(https://github.com/bitcoin/bitcoin/pull/27675#issuecomment-1611189572)
Could rebase for CI?

💬 MarcoFalke commented on pull request "wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction":
(https://github.com/bitcoin/bitcoin/pull/25273#issuecomment-1611191360)
Needs rebase if still relevant

💬 fanquake commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1245046746)
Applied.

💬 MarcoFalke commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1611194968)
CI failure in feature_proxy.py:

https://cirrus-ci.com/task/4981950109188096?logs=ci#L5325

```
node0 stderr net.cpp:1142:113: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'value_type' (aka 'unsigned int')
#0 0x55dbd8047436 in CConnman::DisconnectNodes() src/net.cpp:1142:113
#1 0x55dbd807d233 in CConnman::ThreadSocketHandler() src/net.cpp:1393:9
#2 0x55dbd807d233 in CConnman::Start(CScheduler&, CConnman::Options const&)::$_1::operator()() con
...

💬 vasild commented on pull request "test: remove race in the user-agent reception check":
(https://github.com/bitcoin/bitcoin/pull/27986#issuecomment-1611195730)
`44d71cfd0e...9c46f3ba19`: do https://github.com/bitcoin/bitcoin/pull/27986#discussion_r1244951363

💬 vasild commented on pull request "test: remove race in the user-agent reception check":
(https://github.com/bitcoin/bitcoin/pull/27986#discussion_r1245048980)
Done!

👍 fanquake approved a pull request: "http: update libevent workaround to correct version"
(https://github.com/bitcoin/bitcoin/pull/27949#pullrequestreview-1502843856)
ACK 79d343a642f985801da463b03a0627a59a095238

💬 fanquake commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-1611216402)
> though there are others popping up as well ...

I think at least for the (windows) ones coming out of leveldb, we could filter them out, as we do with other warnings there.

💬 MarcoFalke commented on pull request "util: Don't derive secure_allocator from std::allocator":
(https://github.com/bitcoin/bitcoin/pull/27930#issuecomment-1611219016)
> > I'm guessing we should consider doing the same for [`zero_after_free_allocator`](https://github.com/bitcoin/bitcoin/blob/0c84a0e4841f00d931aa7339e9aa8f26eb2f3a61/src/support/allocators/zeroafterfree.h#L15)? Even though it doesn't seem to be affected by this particular issue.
>
> That's probably a good idea, yes.

Looks like this wasn't addressed yet?

🚀 fanquake merged a pull request: "http: update libevent workaround to correct version"
(https://github.com/bitcoin/bitcoin/pull/27949)

💬 fanquake commented on pull request "test: various USDT functional test cleanups (27831 follow-ups)":
(https://github.com/bitcoin/bitcoin/pull/27944#issuecomment-1611232273)
cc @virtu

💬 fanquake commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1611235566)
```bash
7851f08737a0133002c0224d4bd5e52aed7eaee91adac46f1247ef164775d037 guix-build-23d39c5079cf/output/arm64-apple-darwin/SHA256SUMS.part
172e378d18cd9c624e4cdce51228bfbb43d25098871c18911c70eeb1c2390f34 guix-build-23d39c5079cf/output/arm64-apple-darwin/bitcoin-23d39c5079cf-arm64-apple-darwin-unsigned.tar.gz
3de4d2cec142a8464788da7571b2f09a47893c7f8d75fe52912ecfcefac72242 guix-build-23d39c5079cf/output/arm64-apple-darwin/bitcoin-23d39c5079cf-arm64-apple-darwin-unsigned.zip
33da433dbd3c3d6
...

💬 hebasto commented on pull request "guix: Clean up manifest":
(https://github.com/bitcoin/bitcoin/pull/27811#issuecomment-1611244263)
Rebased due to the conflict with #27813.

💬 MarcoFalke commented on pull request "test: remove race in the user-agent reception check":
(https://github.com/bitcoin/bitcoin/pull/27986#discussion_r1245084467)
style-nit: Seems odd to have three asserts to check two things. Can be written shorter and easier to read:

```suggestion
p = [p for p in self.getpeerinfo() if p["addr"] == f"{us_addrport[0]}:{us_addrport[1]}"]
assert_equal(len(p), 1)
assert_equal(p[0]["subver"], P2P_SUBVERSION)
```

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1611246591)
> ... unsigned integer overflow ...

Maybe collecting the number of "full outbound or manual" connections on the fly was not so bad? I am not objecting pre-collecting and maintaining that number in `CConnman`, just thinking aloud. That looks a bit more tricky and maybe more prone to bugs (like the above). It is also not generic - the "full outbound or manual" number is used only in this specific case and unlikely to be used elsewhere in the future. A more generic approach, that could possibly
...

💬 carnhofdaki commented on issue "Add maxrelaytxfee":
(https://github.com/bitcoin/bitcoin/issues/27983#issuecomment-1611258937)
OK, thanks.

✅ carnhofdaki closed an issue: "Add maxrelaytxfee"
(https://github.com/bitcoin/bitcoin/issues/27983)

💬 kristapsk commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1611260025)
Concept ACK

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1611271297)
Guix build on `x86_64`:
```
7851f08737a0133002c0224d4bd5e52aed7eaee91adac46f1247ef164775d037 guix-build-23d39c5079cf/output/arm64-apple-darwin/SHA256SUMS.part
172e378d18cd9c624e4cdce51228bfbb43d25098871c18911c70eeb1c2390f34 guix-build-23d39c5079cf/output/arm64-apple-darwin/bitcoin-23d39c5079cf-arm64-apple-darwin-unsigned.tar.gz
3de4d2cec142a8464788da7571b2f09a47893c7f8d75fe52912ecfcefac72242 guix-build-23d39c5079cf/output/arm64-apple-darwin/bitcoin-23d39c5079cf-arm64-apple-darwin-unsigned
...