💬 MarcoFalke commented on pull request "test: remove race in the user-agent reception check":
(https://github.com/bitcoin/bitcoin/pull/27986#discussion_r1244887087)
Why would this ever be not found, given that the previously the connection was sync_with_ping'd?

In any case, you can use `next()` to do the assertion. Roughly:

```py
next([p if p["addr"] == f"{us_addrport[0]}:{us_addrport[1]}" p in self.getpeerinfo()])
assert_equal(p["subver"], P2P_SUBVERSION)

💬 willcl-ark commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1611033313)
> I get this when compiling with both gcc and clang-16. I am also using libevent 2.1.12. Is there anything unique about your setup @willcl-ark ? Also, did you Ctrl-C the `waitforblockheight` command before trying to stop bitcoind?

I've had more reports of this deadlock so come back to try and repro it again, but don't seem to be able to no matter what I try 🤷🏼‍♂️

I am on Ubuntu 23.04, also using Clang 16 and libevent 2.1.12-stable-8ubuntu3. It doesn't look like there are any debian patc
...

💬 vasild commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#discussion_r1244922368)
Compiling everything from scratch (after `git clean -fdx`) takes about 1m 30sec (including autogen and ./configure which are single-threaded). The CPU on the machine is:

> AMD Ryzen 9 7950X 16-Core Processor (4491.70-MHz K8-class CPU)

💬 MarcoFalke commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#discussion_r1244937645)
For a useful benchmark, you'll have to measure the total CPU time, not the CPU time of just the translation unit that takes the longest.

💬 vasild commented on pull request "test: remove race in the user-agent reception check":
(https://github.com/bitcoin/bitcoin/pull/27986#discussion_r1244943695)
> Why would this ever be not found

Well, I do not know, maybe some typo in `p["addr"] == f"{us_addrport[0]}:{us_addrport[1]}"` or some other unexpected thing. That is just another sanity check.

Taking a step back I wonder if this check as much value - why would `bitcoind` not have received our user agent string? I wouldn't object if somebody wants to drop the check altogether.

> p=next([p if p["addr"] == f"{us_addrport[0]}:{us_addrport[1]}" p in self.getpeerinfo()])

I find this compl
...

📝 fanquake opened a pull request: "ci: remove duplicate bsdmainutils from CI configs"
(https://github.com/bitcoin/bitcoin/pull/27987)
`bsdmainutils` is included in `CI_BASE_PACKAGES`.

💬 MarcoFalke commented on pull request "test: remove race in the user-agent reception check":
(https://github.com/bitcoin/bitcoin/pull/27986#discussion_r1244951363)
> That is just another sanity check.

Might be better to check the length is one (unique), if the check is kept?

💬 vasild commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#discussion_r1244969873)
```
PR:
real 0m29.623s
user 10m58.337s
sys 0m51.187s

real 0m29.829s
user 10m58.359s
sys 0m50.912s

mocked_sockets.h:
real 0m29.528s
user 11m12.208s
sys 1m0.406s

real 0m28.831s
user 10m45.615s
sys 0m49.680s
```

I guess the "total CPU time" is real+sys from above. It all seems within noise. In both cases all tests would be recompiled, maybe I got @jonatack's comment wrong?

💬 hebasto commented on pull request "ci: remove duplicate bsdmainutils from CI configs":
(https://github.com/bitcoin/bitcoin/pull/27987#issuecomment-1611106896)
What about the python3 package?

💬 TheCharlatan commented on pull request "kernel: Add interrupt class":
(https://github.com/bitcoin/bitcoin/pull/27861#issuecomment-1611113265)
Rebased 001acf37dff40688d82c3b1a7ff9ed3901addb33 -> 6eb33bd0c21b3e075fbab596351cacafdc947472 ([kernelInterrupt_8](https://github.com/TheCharlatan/bitcoin/commits/kernelInterrupt_8) -> [kernelInterrupt_9](https://github.com/TheCharlatan/bitcoin/commits/kernelInterrupt_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelInterrupt_8..kernelInterrupt_9)).
* Fixed conflict with #27896

💬 MarcoFalke commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#discussion_r1244981230)
> I guess the "total CPU time" is real+sys from above

user+sys, but thanks for re-checking.

💬 tansanDOTeth commented on issue "Keep getting errors after a while of syncing":
(https://github.com/bitcoin/bitcoin/issues/27972#issuecomment-1611123854)
> Has anyone ever put the leveldb directory successfully on an external drive, I am not sure if this is even supported by leveldb?
>
> Edit: Alternatively, leveldb may not support your filesystem?

This looks like the fix. I am at 35% now and haven't had issues since reformatting as APFS. Seems like ExFAT is the culprit. I'm going to close this now, thank you!

✅ tansanDOTeth closed an issue: "Keep getting errors after a while of syncing"
(https://github.com/bitcoin/bitcoin/issues/27972)

💬 hebasto commented on pull request "ci: remove duplicate bsdmainutils from CI configs":
(https://github.com/bitcoin/bitcoin/pull/27987#issuecomment-1611145723)
> What about the `python3` package?

In `ci/test/00_setup_env_i686_centos.sh` as well?

👍 hebasto approved a pull request: "ci: remove duplicate bsdmainutils from CI configs"
(https://github.com/bitcoin/bitcoin/pull/27987#pullrequestreview-1502765481)
ACK 248a17addf3cb519cb5e0fb91b9f25ce8d003d85

💬 carnhofdaki commented on issue "Add maxrelaytxfee":
(https://github.com/bitcoin/bitcoin/issues/27983#issuecomment-1611150049)
@MarcoFalke Thank you for feedback.

Last thing first: Yes, it does not make sense to implement it in the same way as `minrelaytxfee`. Such code would just add one more processing step to each transaction before it is broadcast further.

Back to your first concern: The miner may have a contract with someone who pays the fees for such recycling service off-chain.

In my view, a re-org _after_ the other miner (fee-sniper) gets the block from the P2P network and uses its all-fee transaction i
...

📝 MarcoFalke opened a pull request: "test: Use same timeout for all index sync"
(https://github.com/bitcoin/bitcoin/pull/27988)
Seems odd to use different timeouts.

Fix this by using the same timeout for all syncs.

May also fix ?

📝 hebasto opened a pull request: "refactor: Move sock from util to common"
(https://github.com/bitcoin/bitcoin/pull/27989)
Networking code should not be required by the kernel.

💬 MarcoFalke commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1611154752)
This is getting too frequent. I recently encountered this 8 times in a row.

Maybe https://github.com/bitcoin/bitcoin/pull/27988 makes it less frequent for now, by only modifying test code?

👍 fanquake approved a pull request: "guix: Update `python-lief` package to 0.13.2"
(https://github.com/bitcoin/bitcoin/pull/27813#pullrequestreview-1502778035)
ACK 529c92e837b28169b501562efe7b5b7120a2ebbb