📝 achow101 opened a pull request: "test: Log IP of download server in get_previous_releases.py"
(https://github.com/bitcoin/bitcoin/pull/34045)
In order to help debug issues with previous release downloads from our web server, we need to know which IP the downloader connected to.
(https://github.com/bitcoin/bitcoin/pull/34045)
In order to help debug issues with previous release downloads from our web server, we need to know which IP the downloader connected to.
💬 davidgumberg commented on pull request "doc: Add troubleshooting note about Guix on SELinux systems":
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2607905906)
Thanks for testing this, I've dropped this commit.
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2607905906)
Thanks for testing this, I've dropped this commit.
💬 davidgumberg commented on pull request "doc: Add troubleshooting note about Guix on SELinux systems":
(https://github.com/bitcoin/bitcoin/pull/32442#issuecomment-3638588033)
Pushed to drop the SELinux note since the issue seems to have been resolved upstream.
(https://github.com/bitcoin/bitcoin/pull/32442#issuecomment-3638588033)
Pushed to drop the SELinux note since the issue seems to have been resolved upstream.
💬 w0xlt commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2607926938)
nit: Can `OpenNetworkConnection` consistently fail even for valid addresses—for example, due to local networking issues or a misconfigured proxy that rejects connections?
Also, is it possible for this thread to loop and consume CPU until `NumToOpen` is satisfied or addrman is exhausted?
```suggestion
LogDebug(BCLog::PRIVBROADCAST, "Failed to connect to %s, will retry to a different address; remaining connections to open: %d", target_str, remaining);
// Preve
...
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2607926938)
nit: Can `OpenNetworkConnection` consistently fail even for valid addresses—for example, due to local networking issues or a misconfigured proxy that rejects connections?
Also, is it possible for this thread to loop and consume CPU until `NumToOpen` is satisfied or addrman is exhausted?
```suggestion
LogDebug(BCLog::PRIVBROADCAST, "Failed to connect to %s, will retry to a different address; remaining connections to open: %d", target_str, remaining);
// Preve
...
💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2607935205)
`ConstPubkeyProvider` can self expand. Self expand in the context of PubkeyProviders means that pubkeys can always be retrieved, and this is always true for `ConstPubkeyProvider`. `ConstPubkeyProvider` cannot be ranged, nor can it be something that requires a private key in order to get the pubkey.
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2607935205)
`ConstPubkeyProvider` can self expand. Self expand in the context of PubkeyProviders means that pubkeys can always be retrieved, and this is always true for `ConstPubkeyProvider`. `ConstPubkeyProvider` cannot be ranged, nor can it be something that requires a private key in order to get the pubkey.
💬 hebasto commented on pull request "doc: guix: Troubleshooting zdiff3 issue and uninstalling.":
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2607973542)
The default URL of repository has been updated recently:
```suggestion
Updating channel 'guix' from Git repository at 'https://git.guix.gnu.org/guix.git'...
```
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2607973542)
The default URL of repository has been updated recently:
```suggestion
Updating channel 'guix' from Git repository at 'https://git.guix.gnu.org/guix.git'...
```
💬 janb84 commented on pull request "test: Log IP of download server in get_previous_releases.py":
(https://github.com/bitcoin/bitcoin/pull/34045#discussion_r2607979328)
Are the server IP addresses always IPv4 ? `Socket.AF_INET` is ipv4 only
(https://github.com/bitcoin/bitcoin/pull/34045#discussion_r2607979328)
Are the server IP addresses always IPv4 ? `Socket.AF_INET` is ipv4 only
👍 hebasto approved a pull request: "depends: Boost 1.90.0"
(https://github.com/bitcoin/bitcoin/pull/33428#pullrequestreview-3564225158)
ACK ca4a844eed481afa0ca7eab8b972ccbda8dfe168.
My Guix build:
```
x86_64
c88ca4eda058c02cf8cd6d8e0d547ae83e52ec302187ddc1a1302ec1701d757a guix-build-ca4a844eed48/output/aarch64-linux-gnu/SHA256SUMS.part
a6853e0e507970ee3bca72bf00c9afcb979e7e6e28c8463836edf81f8aaa1958 guix-build-ca4a844eed48/output/aarch64-linux-gnu/bitcoin-ca4a844eed48-aarch64-linux-gnu-debug.tar.gz
1bf0497f2a88ace485f71c224cb0ace6e0d0ee3109057f8b0fb9813a9d8f2ddf guix-build-ca4a844eed48/output/aarch64-linux-gnu/bitcoin-ca4a84
...
(https://github.com/bitcoin/bitcoin/pull/33428#pullrequestreview-3564225158)
ACK ca4a844eed481afa0ca7eab8b972ccbda8dfe168.
My Guix build:
```
x86_64
c88ca4eda058c02cf8cd6d8e0d547ae83e52ec302187ddc1a1302ec1701d757a guix-build-ca4a844eed48/output/aarch64-linux-gnu/SHA256SUMS.part
a6853e0e507970ee3bca72bf00c9afcb979e7e6e28c8463836edf81f8aaa1958 guix-build-ca4a844eed48/output/aarch64-linux-gnu/bitcoin-ca4a844eed48-aarch64-linux-gnu-debug.tar.gz
1bf0497f2a88ace485f71c224cb0ace6e0d0ee3109057f8b0fb9813a9d8f2ddf guix-build-ca4a844eed48/output/aarch64-linux-gnu/bitcoin-ca4a84
...
👍 hodlinator approved a pull request: "rest: allow reading partial block data from storage"
(https://github.com/bitcoin/bitcoin/pull/33657#pullrequestreview-3563299997)
re-ACK 8b417087aec4671a1ce58f2331d1688e665d9935
(https://github.com/bitcoin/bitcoin/pull/33657#pullrequestreview-3563299997)
re-ACK 8b417087aec4671a1ce58f2331d1688e665d9935
💬 hodlinator commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2607934791)
Having a `default` prevents the compiler warning for missing `enum` values as it is assumed the developer meant for all missing `enum` values to go to the `default`.
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2607934791)
Having a `default` prevents the compiler warning for missing `enum` values as it is assumed the developer meant for all missing `enum` values to go to the `default`.
💬 hodlinator commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2608002092)
Could add a test for this:
```diff
--- a/test/functional/interface_rest.py
+++ b/test/functional/interface_rest.py
@@ -9,6 +9,7 @@ from enum import Enum
from io import BytesIO
import http.client
import json
+import os
import typing
import urllib.parse
@@ -84,7 +85,7 @@ class RESTTest (BitcoinTestFramework):
conn.request('POST', rest_uri, body)
resp = conn.getresponse()
- assert_equal(resp.status, status)
+ assert resp.status == status, f"Expected: {st
...
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2608002092)
Could add a test for this:
```diff
--- a/test/functional/interface_rest.py
+++ b/test/functional/interface_rest.py
@@ -9,6 +9,7 @@ from enum import Enum
from io import BytesIO
import http.client
import json
+import os
import typing
import urllib.parse
@@ -84,7 +85,7 @@ class RESTTest (BitcoinTestFramework):
conn.request('POST', rest_uri, body)
resp = conn.getresponse()
- assert_equal(resp.status, status)
+ assert resp.status == status, f"Expected: {st
...
💬 hodlinator commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2607254720)
nit: Sorry for not suggesting earlier, this could possibly be more appropriate:
```suggestion
case node::ReadRawError::IO: return RESTERR(req, HTTP_INTERNAL_SERVER_ERROR, "I/O error reading " + hashStr);
```
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2607254720)
nit: Sorry for not suggesting earlier, this could possibly be more appropriate:
```suggestion
case node::ReadRawError::IO: return RESTERR(req, HTTP_INTERNAL_SERVER_ERROR, "I/O error reading " + hashStr);
```
💬 davidgumberg commented on pull request "doc: guix: Troubleshooting zdiff3 issue and uninstalling.":
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2608030842)
I'm not sure which is the "canonical" one, but git.guix.gnu.org redirects to codeberg and that is what I actually see in the error message:
```
Updating channel 'guix' from Git repository at 'https://codeberg.org/guix/guix.git'...
guix time-machine: error: Git error: unknown style 'zdiff3' given for 'merge.conflictstyle'
```
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2608030842)
I'm not sure which is the "canonical" one, but git.guix.gnu.org redirects to codeberg and that is what I actually see in the error message:
```
Updating channel 'guix' from Git repository at 'https://codeberg.org/guix/guix.git'...
guix time-machine: error: Git error: unknown style 'zdiff3' given for 'merge.conflictstyle'
```
💬 w0xlt commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2608045683)
Purely cosmetic nit: The error message could be shorter.
```suggestion
return InitError(_("-privatebroadcast is incompatible with -connect because it must open random Tor/I2P connections. Use -maxconnections=0 and -addnode=... instead."
```
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2608045683)
Purely cosmetic nit: The error message could be shorter.
```suggestion
return InitError(_("-privatebroadcast is incompatible with -connect because it must open random Tor/I2P connections. Use -maxconnections=0 and -addnode=... instead."
```
💬 davidgumberg commented on pull request "doc: guix: Troubleshooting zdiff3 issue and uninstalling.":
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2608052261)
Thanks for catching this, I've updated the error message to what is actually printed. I think fixing the rest of the savannah->codeberg links could be done in a follow-up that also changes the `guix time-machine --url` in `/contribib/guix/libexec/prelude.bash`
(https://github.com/bitcoin/bitcoin/pull/32442#discussion_r2608052261)
Thanks for catching this, I've updated the error message to what is actually printed. I think fixing the rest of the savannah->codeberg links could be done in a follow-up that also changes the `guix time-machine --url` in `/contribib/guix/libexec/prelude.bash`
💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2608055960)
I think that is unnecessary, and unlikely to happen.
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2608055960)
I think that is unnecessary, and unlikely to happen.
💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2608056860)
Fixed
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2608056860)
Fixed
💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2608058579)
Done
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2608058579)
Done
💬 sipa commented on pull request "Replace cluster linearization algorithm with SFL":
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3638795504)
I've squashed in the new explainer comment, plus a number of other changes:
* Split out loading of an existing linearization into a separate commit.
* Split out adding support for reading non-topological inputs to `ReadLinearization` into a separate commit.
* Various small improvements to benchmarks, tests, comments.
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3638795504)
I've squashed in the new explainer comment, plus a number of other changes:
* Split out loading of an existing linearization into a separate commit.
* Split out adding support for reading non-topological inputs to `ReadLinearization` into a separate commit.
* Various small improvements to benchmarks, tests, comments.
💬 achow101 commented on pull request "test: Log IP of download server in get_previous_releases.py":
(https://github.com/bitcoin/bitcoin/pull/34045#discussion_r2608077343)
No, it can be IPv6. But since we aren't ever going to actually use this socket, `AF_INET` doesn't matter. The logging still works correctly with IPv6.
(https://github.com/bitcoin/bitcoin/pull/34045#discussion_r2608077343)
No, it can be IPv6. But since we aren't ever going to actually use this socket, `AF_INET` doesn't matter. The logging still works correctly with IPv6.