💬 fanquake commented on pull request "doc: Add `x86_64-w64-mingw32ucrt` triplet to `depends/README.md`":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2585077766)
> My hope was that one toolchain could be dropped while adding the new one relatively quickly, or even at the same time.

Yea. That was my intention/expectation for any migration.

💬 fanquake commented on pull request "doc: Add `x86_64-w64-mingw32ucrt` triplet to `depends/README.md`":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2585095510)
> developers on Ubuntu, for example, may still want to build for x86_64-w64-mingw32.

Are we supporting that, if the CI is removed in #33593 (along with dropping workarounds going forward).

💬 maflcko commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2585106930)
looks like this line crashes:

```
$ echo 'cHNidP8BAP0+AQIAAAAGy4dxGNHKAQgFPtEAoVgyMqb+N0ghgmdne5OjULYs2sUAAAr/AP3////L
fnEY0crZmwU+EVahszExpv43SCGCZ2d7k6NQtizaOwADAC4ABHwdAMt+cRjRytmbBT4RVqFYMTGm
/jdIIYJnZ3uTo1AAOwAsAAC2KwD9////hqbXlTl39C5ZmAtOAI4+zy32vWLVnyQjw7IvQsBa6rYA
AAcAAP3//zKG/zqgb7JIwmli68xeUjUXVp+c4b/tvc55IsAI4yQAAAAAAAAA/f///8t/0cpxGNmb
BT4RVqFYMTOm/jdIIXj///8AAAAAgNo7AACAAAD9//3/AiHf9QUAAAAAFgAU9/Ykq9yiCFGnUpsi
RsS6FFGLkQEAAAAAAAABABYAFEEQliEApQAADCBABv78gsn+/////wAAAAAAAAAAACIagHQA
...

⚠️ maflcko opened an issue: "FUZZ=psbt in musig2, runs into uninitialized read"
(https://github.com/bitcoin/bitcoin/issues/33999)


```
$ echo 'cHNidP8BAP0+AQIAAAAGy4dxGNHKAQgFPtEAoVgyMqb+N0ghgmdne5OjULYs2sUAAAr/AP3////L
fnEY0crZmwU+EVahszExpv43SCGCZ2d7k6NQtizaOwADAC4ABHwdAMt+cRjRytmbBT4RVqFYMTGm
/jdIIYJnZ3uTo1AAOwAsAAC2KwD9////hqbXlTl39C5ZmAtOAI4+zy32vWLVnyQjw7IvQsBa6rYA
AAcAAP3//zKG/zqgb7JIwmli68xeUjUXVp+c4b/tvc55IsAI4yQAAAAAAAAA/f///8t/0cpxGNmb
BT4RVqFYMTOm/jdIIXj///8AAAAAgNo7AACAAAD9//3/AiHf9QUAAAAAFgAU9/Ykq9yiCFGnUpsi
RsS6FFGLkQEAAAAAAAABABYAFEEQliEApQAADCBABv78gsn+/////wAAAAAAAAAAACIagHQAAAAV
DLQyJycoAHNiKDIDAEIAAEEA
...

⚠️ fanquake opened an issue: "fuzz: crash in psbt fuzzer"
(https://github.com/bitcoin/bitcoin/issues/34000)
From: https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2585106930:

> looks like this line crashes:

```bash
$ echo 'cHNidP8BAP0+AQIAAAAGy4dxGNHKAQgFPtEAoVgyMqb+N0ghgmdne5OjULYs2sUAAAr/AP3////L
fnEY0crZmwU+EVahszExpv43SCGCZ2d7k6NQtizaOwADAC4ABHwdAMt+cRjRytmbBT4RVqFYMTGm
/jdIIYJnZ3uTo1AAOwAsAAC2KwD9////hqbXlTl39C5ZmAtOAI4+zy32vWLVnyQjw7IvQsBa6rYA
AAcAAP3//zKG/zqgb7JIwmli68xeUjUXVp+c4b/tvc55IsAI4yQAAAAAAAAA/f///8t/0cpxGNmb
BT4RVqFYMTOm/jdIIXj///8AAAAAgNo7AACAAAD9//3/AiHf9QUAAAAAFgAU9/Ykq9
...

✅ fanquake closed an issue: "fuzz: crash in psbt fuzzer"
(https://github.com/bitcoin/bitcoin/issues/34000)

💬 fanquake commented on issue "FUZZ=psbt in musig2, runs into uninitialized read":
(https://github.com/bitcoin/bitcoin/issues/33999#issuecomment-3606863179)
cc @achow101 @fjahr @rkrux

💬 hebasto commented on pull request "doc: Add `x86_64-w64-mingw32ucrt` triplet to `depends/README.md`":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2585127019)
> > developers on Ubuntu, for example, may still want to build for x86_64-w64-mingw32.
>
> Are we supporting that, if the CI is removed in #33593 (along with dropping workarounds going forward).

We won't support that once workarounds are dropped and code become incompatible with MSVCRT. By that point, I don’t anticipate any issues with providing that support.

💬 fanquake commented on pull request "doc: Add `x86_64-w64-mingw32ucrt` triplet to `depends/README.md`":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2585133303)
> By that point,

Isn't that point #33593? The workarounds should be removed along with the CI being dropped, otherwise they are untested and unused.

👍 sedited approved a pull request: "index: remove unnecessary locator cleaning in BaseIndex::Init()"
(https://github.com/bitcoin/bitcoin/pull/32882#pullrequestreview-3535074920)
ACK facd01e6ffbbd019312f370a3807de0b95bbd745

💬 hebasto commented on pull request "doc: Add `x86_64-w64-mingw32ucrt` triplet to `depends/README.md`":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2585143654)
> Isn't that point #33593? The workarounds should be removed along with the CI being dropped, otherwise they are untested and unused.

It could be in #33593 or in a follow-up PR.

💬 fanquake commented on pull request "depends: Propagate native C compiler to `sqlite` package":
(https://github.com/bitcoin/bitcoin/pull/33995#issuecomment-3606913212)
Concept ACK over #33975.

🚀 fanquake merged a pull request: "index: remove unnecessary locator cleaning in BaseIndex::Init()"
(https://github.com/bitcoin/bitcoin/pull/32882)

🚀 fanquake merged a pull request: "doc: Add `x86_64-w64-mingw32ucrt` triplet to `depends/README.md`"
(https://github.com/bitcoin/bitcoin/pull/33857)

💬 hodlinator commented on pull request "qa: Avoid knock-on exception in assert_start_raises_init_error":
(https://github.com/bitcoin/bitcoin/pull/32929#issuecomment-3607011155)
Latest push (42ed679f0bb9807b08e6209528829f1e45f8765d):
* Rebases to resolve conflict with 42ed679f0bb9807b08e6209528829f1e45f8765d
* Adds 9481948e0d979dccedd7b4e6616ef4903bc1cdba - Reverts one line of 42ed679f0bb9807b08e6209528829f1e45f8765d to fix issue
* Adds 0ff74253858f0a9b6c1f0fecb815c8380d5661be - Minor documentation change to `assert_start_raises_init_error()` as requested by https://github.com/bitcoin/bitcoin/pull/32929#issuecomment-3453237274
* Modifies last commit 42ed679f0bb9807b
...

💬 hodlinator commented on pull request "contrib: Remove brittle, confusing and redundant UTF8 encoding from Python IO":
(https://github.com/bitcoin/bitcoin/pull/33702#discussion_r2585288311)
The change on this specific line is incorrect, see 9481948e0d979dccedd7b4e6616ef4903bc1cdba (#32929) for a fix.

Verified that the changes to test/lint/lint-spelling.py (where we are also printing output from an exception field) to the contrary *are correct* in this PR by passing in an invalid argument in the subprocess call.

🤔 darosior reviewed a pull request: "test: clarify timewarp grace period griefing attack"
(https://github.com/bitcoin/bitcoin/pull/31725#pullrequestreview-3535301159)
This is adding a test that demonstrates how Bitcoin Core would reject a block from a broken mining pool software that:
- ignores the block chain and set the block timestamp using wall clock time;
- ignores the `mintime` value provided by Bitcoin Core's block template;
- ignores the `curtime` value provided by Bitcoin Core's block template.

There is many, many ways a mining pool software that disregards consensus rules and values provided by Bitcoin Core's block template may create an invalid bl
...

✅ Sjors closed a pull request: "test: add logging to mock external signers"
(https://github.com/bitcoin/bitcoin/pull/32928)

💬 Sjors commented on pull request "test: add logging to mock external signers":
(https://github.com/bitcoin/bitcoin/pull/32928#issuecomment-3607170297)
Closing as up for grabs (rather than rebasing again) due to lack of review.

💬 laanwj commented on pull request "guix: use GCC 14.3.0 over 13.3.0":
(https://github.com/bitcoin/bitcoin/pull/33775#issuecomment-3607180028)
This is a minimum C++ file that will reproduce the issue:
```c++
#include <filesystem>
#include <string>
#include <fstream>
#include <vector>

#include <cstring> // Unused, but removing this makes it determinstic

namespace fs {

using namespace std::filesystem;

// Dummy class. Using "path = std::filesystem::path" makes it deterministic.
class path : public std::filesystem::path
{
public:
using std::filesystem::path::path;

path(std::filesystem::path path) : std::file
...