👍 rkrux approved a pull request: "contrib: fix manpage generation"
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534323387)
re-ACK e9536faaee2bdb53807aa7c48aafa269d18f19d3

💬 sedited commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3606147086)
Rebased 6493e47fd8d32c030d553f791caa48fcdb848c0b -> a0e9578ec1ff1d8ec57f76a37e389aeeb554a639 ([spendblock_15](https://github.com/TheCharlatan/bitcoin/tree/spendblock_15) -> [spendblock_16](https://github.com/TheCharlatan/bitcoin/tree/spendblock_16), [compare](https://github.com/TheCharlatan/bitcoin/compare/spendblock_15..spendblock_16))

* Fixed conflict with #33960

🚀 fanquake merged a pull request: "test: Avoid shutdown race in NetworkThread"
(https://github.com/bitcoin/bitcoin/pull/33140)

💬 fanquake commented on pull request "test: clarify timewarp grace period griefing attack":
(https://github.com/bitcoin/bitcoin/pull/31725#issuecomment-3606247613)
@darosior @sedited want to leave a conceptual opinion here, given your comments in #31600?

💬 fanquake commented on pull request "wallet, test: Ancient Wallet Migration from v0.14.3 (no-HD and Single Chain)":
(https://github.com/bitcoin/bitcoin/pull/33186#issuecomment-3606257395)
@achow101 can you leave a conceptual review?

💬 fanquake commented on pull request "stabilize translations by reverting old ids by text content":
(https://github.com/bitcoin/bitcoin/pull/33270#issuecomment-3606295298)
What is the status of this?

✅ fanquake closed a pull request: "index: remove unnecessary locator cleaning in BaseIndex::Init()"
(https://github.com/bitcoin/bitcoin/pull/32882)

📝 fanquake reopened a pull request: "index: remove unnecessary locator cleaning in BaseIndex::Init()"
(https://github.com/bitcoin/bitcoin/pull/32882)
Leverage locator.IsNull() to simplify ReadBestBlock() and remove
unnecessary SetNull().

💬 fanquake commented on pull request "tests: Add unix timestamp tests for OP_CLTV":
(https://github.com/bitcoin/bitcoin/pull/32229#issuecomment-3606304212)
cc @petertodd

🚀 fanquake merged a pull request: "contrib: fix manpage generation"
(https://github.com/bitcoin/bitcoin/pull/33996)

✅ fanquake closed a pull request: "wallet: don't consider unconfirmed TRUC coins with ancestors"
(https://github.com/bitcoin/bitcoin/pull/33528)

📝 fanquake reopened a pull request: "wallet: don't consider unconfirmed TRUC coins with ancestors"
(https://github.com/bitcoin/bitcoin/pull/33528)
Addresses https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3319935660

There is not an explicit check that the to-be-created wallet transaction would be within the {TRUC, normal} ancestor limits. This means that the wallet may create a transaction that violates these limits, but fail to broadcast it in `CommitTransaction`.

This appears to be expected behavior for the normal ancestor limits (and any other situation in which the wallet creates a tx that was rejected by mempool) an
...

📝 fanquake opened a pull request: "[30.x] Backports & 30.1rc1"
(https://github.com/bitcoin/bitcoin/pull/33997)
Backports:
* #32009
* #33996

💬 fanquake commented on pull request "contrib: fix manpage generation":
(https://github.com/bitcoin/bitcoin/pull/33996#issuecomment-3606431767)
Backported to 30.x in #33997.

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#issuecomment-3606432356)
Backported to 30.x in https://github.com/bitcoin/bitcoin/pull/33997.

💬 b-l-u-e commented on pull request "[p2p] Fix signed integer overflow in LocalServiceInfo::nScore":
(https://github.com/bitcoin/bitcoin/pull/33072#issuecomment-3606450126)
> Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.
>
>
>
> Marking as up for grabs.

I would like to continue to work on this..

💬 fanquake commented on pull request "wallet: don't consider unconfirmed TRUC coins with ancestors":
(https://github.com/bitcoin/bitcoin/pull/33528#issuecomment-3606452582)
Locally I could not run the merge script against this PR:
```bash
fatal: ambiguous argument 'refs/heads/pull/33528/merge': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
ERROR: Cannot find merge of pull request bitcoin/bitcoin#33528 on git@github.com:bitcoin/bitcoin.
```
Open/closed to re-run CI, and it seems to have the same issue.

📝 fanquake reopened a pull request: "[p2p] Fix signed integer overflow in LocalServiceInfo::nScore"
(https://github.com/bitcoin/bitcoin/pull/33072)
## Problem
The `nScore` field in `LocalServiceInfo` struct was defined as `int` (32-bit signed integer), which could overflow from `INT_MAX` (2,147,483,647) to `INT_MIN` (-2,147,483,648) when incremented by `SeenLocal()` during version handshakes. This is undefined behavior in C++ and could affect address selection logic.

## Solution
Implement saturation in `SeenLocal()` to cap `nScore` at `std::numeric_limits<int>::max()` instead of allowing overflow. This prevents undefined behavior while
...

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2584817277)
Changed locally with dummy addresses, for all networks. Will be part of the next push.

💬 l0rinc commented on pull request "stabilize translations by reverting old ids by text content":
(https://github.com/bitcoin/bitcoin/pull/33270#issuecomment-3606551517)
It worked correctly for stabilizing the transaltions - removals an moves alike. Some reviewers would prefer rewriting the logic from python to cmake, but it should work currently as-is. Reviews and reproducers are welcome.