👍 rkrux approved a pull request: "init: point out -stopatheight may be imprecise"
(https://github.com/bitcoin/bitcoin/pull/33993#pullrequestreview-3534134158)
crACK e4703863655135856d0d6ad54a7021d3326bf071
Helpful note.
(https://github.com/bitcoin/bitcoin/pull/33993#pullrequestreview-3534134158)
crACK e4703863655135856d0d6ad54a7021d3326bf071
Helpful note.
🤔 janb84 reviewed a pull request: "contrib: fix manpage generation"
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534147771)
ACK 10e6417b3b33a7df18a61d657153f3d90b89dbf2
This PR fixes gen-manpages to process the version in a different way.
Master, breaks:
<details>
```sh
./contrib/devtools/gen-manpages.py
Traceback (most recent call last):
File "/Users/arjan/Projects/bitcoin/./contrib/devtools/gen-manpages.py", line 65, in <module>
assert verstr.startswith('v')
~~~~~~~~~~~~~~~~~^^^^^
AssertionError
```
</details>
This PR, works:
<details>
```sh
./contrib/devtools/gen-manpag
...
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534147771)
ACK 10e6417b3b33a7df18a61d657153f3d90b89dbf2
This PR fixes gen-manpages to process the version in a different way.
Master, breaks:
<details>
```sh
./contrib/devtools/gen-manpages.py
Traceback (most recent call last):
File "/Users/arjan/Projects/bitcoin/./contrib/devtools/gen-manpages.py", line 65, in <module>
assert verstr.startswith('v')
~~~~~~~~~~~~~~~~~^^^^^
AssertionError
```
</details>
This PR, works:
<details>
```sh
./contrib/devtools/gen-manpag
...
💬 janb84 commented on pull request "contrib: fix manpage generation":
(https://github.com/bitcoin/bitcoin/pull/33996#discussion_r2584390842)
Non-blocking NIT: maybe use raw strings version of regex for clarity and following [best practices](https://mimo.org/glossary/python/regex-regular-expressions)
```suggestion
search = re.search(r"v[0-9]\S+", output)
```
(https://github.com/bitcoin/bitcoin/pull/33996#discussion_r2584390842)
Non-blocking NIT: maybe use raw strings version of regex for clarity and following [best practices](https://mimo.org/glossary/python/regex-regular-expressions)
```suggestion
search = re.search(r"v[0-9]\S+", output)
```
💬 vasild commented on pull request "precalculate SipHash constant salt XORs":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-3605988525)
> should I drop the last commit
I am fine either way. Would be interested to see what other reviewers think.
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-3605988525)
> should I drop the last commit
I am fine either way. Would be interested to see what other reviewers think.
🚀 fanquake merged a pull request: "contrib: Remove brittle, confusing and redundant UTF8 encoding from Python IO"
(https://github.com/bitcoin/bitcoin/pull/33702)
(https://github.com/bitcoin/bitcoin/pull/33702)
👍 hodlinator approved a pull request: "rest: allow reading partial block data from storage"
(https://github.com/bitcoin/bitcoin/pull/33657#pullrequestreview-3534148441)
re-ACK f07c765aa6bdba2511ceec56aa7f9755fa29a81e
(https://github.com/bitcoin/bitcoin/pull/33657#pullrequestreview-3534148441)
re-ACK f07c765aa6bdba2511ceec56aa7f9755fa29a81e
💬 hodlinator commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2584406304)
I'm fine with both 1 commit or breaking apart as suggested.
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2584406304)
I'm fine with both 1 commit or breaking apart as suggested.
💬 hodlinator commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2584396172)
meganit: double newline
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2584396172)
meganit: double newline
💬 hodlinator commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2584393520)
nit: I prefer using `std::variant` instead of out-parameters. See ab11b4bd7a5844d6ce654b39fca034d73defe973 / https://github.com/bitcoin/bitcoin/compare/master...hodlinator:bitcoin:pr/33657_suggestions2
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2584393520)
nit: I prefer using `std::variant` instead of out-parameters. See ab11b4bd7a5844d6ce654b39fca034d73defe973 / https://github.com/bitcoin/bitcoin/compare/master...hodlinator:bitcoin:pr/33657_suggestions2
👍 sedited approved a pull request: "rest: allow reading partial block data from storage"
(https://github.com/bitcoin/bitcoin/pull/33657#pullrequestreview-3534235283)
Re-ACK f07c765aa6bdba2511ceec56aa7f9755fa29a81e
(https://github.com/bitcoin/bitcoin/pull/33657#pullrequestreview-3534235283)
Re-ACK f07c765aa6bdba2511ceec56aa7f9755fa29a81e
🚀 fanquake merged a pull request: "test: assumeutxo: add missing tests in wallet_assumeutxo.py"
(https://github.com/bitcoin/bitcoin/pull/30455)
(https://github.com/bitcoin/bitcoin/pull/30455)
💬 fanquake commented on pull request "contrib: fix manpage generation":
(https://github.com/bitcoin/bitcoin/pull/33996#discussion_r2584470782)
Taken.
(https://github.com/bitcoin/bitcoin/pull/33996#discussion_r2584470782)
Taken.
💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2584472892)
Sounds reasonable. Some of the code in `ReattemptPrivateBroadcast()` will be removed if just `num_for_rebroadcast` is used.
What do other reviewers think?
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2584472892)
Sounds reasonable. Some of the code in `ReattemptPrivateBroadcast()` will be removed if just `num_for_rebroadcast` is used.
What do other reviewers think?
🤔 janb84 reviewed a pull request: "contrib: fix manpage generation"
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534282452)
re ACK e9536faaee2bdb53807aa7c48aafa269d18f19d3
changes since last ack:
- regex is now in raw string format.
(thanks for incorporating my nit)
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534282452)
re ACK e9536faaee2bdb53807aa7c48aafa269d18f19d3
changes since last ack:
- regex is now in raw string format.
(thanks for incorporating my nit)
👍 rkrux approved a pull request: "contrib: fix manpage generation"
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534323387)
re-ACK e9536faaee2bdb53807aa7c48aafa269d18f19d3
(https://github.com/bitcoin/bitcoin/pull/33996#pullrequestreview-3534323387)
re-ACK e9536faaee2bdb53807aa7c48aafa269d18f19d3
💬 sedited commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3606147086)
Rebased 6493e47fd8d32c030d553f791caa48fcdb848c0b -> a0e9578ec1ff1d8ec57f76a37e389aeeb554a639 ([spendblock_15](https://github.com/TheCharlatan/bitcoin/tree/spendblock_15) -> [spendblock_16](https://github.com/TheCharlatan/bitcoin/tree/spendblock_16), [compare](https://github.com/TheCharlatan/bitcoin/compare/spendblock_15..spendblock_16))
* Fixed conflict with #33960
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3606147086)
Rebased 6493e47fd8d32c030d553f791caa48fcdb848c0b -> a0e9578ec1ff1d8ec57f76a37e389aeeb554a639 ([spendblock_15](https://github.com/TheCharlatan/bitcoin/tree/spendblock_15) -> [spendblock_16](https://github.com/TheCharlatan/bitcoin/tree/spendblock_16), [compare](https://github.com/TheCharlatan/bitcoin/compare/spendblock_15..spendblock_16))
* Fixed conflict with #33960
🚀 fanquake merged a pull request: "test: Avoid shutdown race in NetworkThread"
(https://github.com/bitcoin/bitcoin/pull/33140)
(https://github.com/bitcoin/bitcoin/pull/33140)
💬 fanquake commented on pull request "test: clarify timewarp grace period griefing attack":
(https://github.com/bitcoin/bitcoin/pull/31725#issuecomment-3606247613)
@darosior @sedited want to leave a conceptual opinion here, given your comments in #31600?
(https://github.com/bitcoin/bitcoin/pull/31725#issuecomment-3606247613)
@darosior @sedited want to leave a conceptual opinion here, given your comments in #31600?
💬 fanquake commented on pull request "wallet, test: Ancient Wallet Migration from v0.14.3 (no-HD and Single Chain)":
(https://github.com/bitcoin/bitcoin/pull/33186#issuecomment-3606257395)
@achow101 can you leave a conceptual review?
(https://github.com/bitcoin/bitcoin/pull/33186#issuecomment-3606257395)
@achow101 can you leave a conceptual review?
💬 fanquake commented on pull request "stabilize translations by reverting old ids by text content":
(https://github.com/bitcoin/bitcoin/pull/33270#issuecomment-3606295298)
What is the status of this?
(https://github.com/bitcoin/bitcoin/pull/33270#issuecomment-3606295298)
What is the status of this?