💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3582423083)
`12dfb1cb7c...50c8320f20`: take some suggestions and minor tweaks

💬 hebasto commented on pull request "ci: Run GUI unit tests in cross-Windows task":
(https://github.com/bitcoin/bitcoin/pull/33919#issuecomment-3582434851)
> Looks like the output is missing...

The same happens for the native build: https://github.com/hebasto/bitcoin/actions/runs/19707163063/job/56457637457.

It seems to be a peculiarity of the GHA Windows image.

💬 andrewtoth commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2565904681)
> Yes, if the transaction is valid.

Interesting. How can an invalid tx have different txids but same wtxids?

🤔 hebasto reviewed a pull request: "depends: update freetype and document remaining `bitcoin-qt` runtime libs"
(https://github.com/bitcoin/bitcoin/pull/33952#pullrequestreview-3512059986)
Concept ACK.

💬 l0rinc commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2565911693)
No idea, but this way of keeping both we don't have to find out :)

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2565916767)
Hmm, it cannot, I was confused. Will drop the txid comparison.

🤔 hebasto reviewed a pull request: "guix: reduce allowed exported symbols"
(https://github.com/bitcoin/bitcoin/pull/33950#pullrequestreview-3512084049)
Concept ACK.

👍 laanwj approved a pull request: "precalculate SipHash constant salt XORs"
(https://github.com/bitcoin/bitcoin/pull/30442#pullrequestreview-3512087837)
re-ACK 1b810390fe51b79c7063966c9722c01cb8a4f7bf

Since last review:
```
git range-diff 9b1a7c3e8dd78d97fbf47c2d056d043b05969176..89bbbbd257063118e6968c409e52632835b76ce8 17072f70051dc086ef57880cd14e102ed346c350..1b810390fe51b79c7063966c9722c01cb8a4f7bf
```
1. `test: Rename k1/k2 to k0/k1 in SipHash consistency tests:` - Reordering in testcase, no functional change
2. `refactor: Extract SipHash C0-C3 constants to class scope` - No changes
3. `optimization: Introduce PresaltedSipHasher for repe
...

💬 laanwj commented on pull request "guix: reduce allowed exported symbols":
(https://github.com/bitcoin/bitcoin/pull/33950#issuecomment-3582538390)
Nice. Concept ACK. Will do riscv64 guix build.

💬 cobratbq commented on pull request "doc: update interface, --stdin flag, `signtx` (#31005)":
(https://github.com/bitcoin/bitcoin/pull/33765#discussion_r2565992040)
yeah, sry, I had found it already. I realized that it essentially just concerns text being prepended, so it is mostly whoever "tells the story" on this API. I will make the changes, or have made; need to (re)check.

💬 gmaxwell commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2566047719)
Might be useful to specifically include something that describes it in the literature terms, like:

"Producing an optimal linearization of a cluster is an instance of the parametric maximal weight closure problem as found in the field of mineral extraction for open pit mining."

-- just to give future researchers a hook to the literature that contributors here initially lacked.

💬 kevkevinpal commented on pull request "policy: Remove individual transaction <minrelay restriction":
(https://github.com/bitcoin/bitcoin/pull/33892#discussion_r2566086022)
why not drop the whole test as per this comment?

💬 plebhash commented on issue "Memory leak when using IPC mining interface":
(https://github.com/bitcoin/bitcoin/issues/33940#issuecomment-3582775203)
we merged https://github.com/stratum-mining/sv2-apps/pull/59 so deploying SRI Pool and/or JDC for testing can be done from `main` branch

> The node log messages should contain a destroy entry every time the client releases a template. It's probably also a good idea to have the client emit a log message when it discards a template.

I just did some tests with:
- Bitcoin Core v30 binary downloaded from official website
- `mainnet` (for frequent template updates)
- SRI Pool from commit https://git
...

📝 mzumsande opened a pull request: "test: add functional test for outbound connection management"
(https://github.com/bitcoin/bitcoin/pull/33954)
For #29415, vasild added the possibility to make outbound connections made "naturally" by the node from addrman entries, by redirecting them via a SOCKS5 proxy to python p2ps or other full nodes, so that the node under test behaves as if it is connected to normal non-local peers from arbitrary networks, while we have full control over the peers.

I think this feature is really cool and want to suggest to integrate it more prominently into the test framework ("`auto_outbound_mode`") in the firs
...

✅ sashass1315 closed a pull request: "coinstats: avoid unnecessary Coin copy in ApplyHash"
(https://github.com/bitcoin/bitcoin/pull/33410)

📝 sashass1315 opened a pull request: "leveldb: correct trailer boundary check in Reader::SkipToInitialBlock"
(https://github.com/bitcoin/bitcoin/pull/33955)
replaces the magic number 6 in the trailer boundary condition with kHeaderSize and corrects an off-by-one by expressing the rule as offset_in_block > kBlockSize - kHeaderSize, which is equivalent to offset_in_block >= kBlockSize - 6. According to
src/leveldb/doc/log_format.md:
“A record never starts within the last six bytes of a block”
and when exactly seven bytes remain a record may start (e.g., a zero-length FIRST), so the equal case must be treated as trailer. The writer already uses kH
...

✅ fanquake closed a pull request: "contrib: turn off compression of macOS SDK to fix determinism (across distros)"
(https://github.com/bitcoin/bitcoin/pull/32009)

📝 fanquake reopened a pull request: "contrib: turn off compression of macOS SDK to fix determinism (across distros)"
(https://github.com/bitcoin/bitcoin/pull/32009)
This includes three changes. The first is to more selectively pick files for inclusion into our macOS SDK tarball (skip manpages, binaries etc), which is nice because it redues the size of the tarball (from ~80mb to 20mb), and makes the size increase that happens with the next commit, less-bad.

The second change removes compression of the tarball. Starting with Python 3.11, Pythons gzip might delegate to zlib. Depending on the OS, i.e Ubuntu vs Fedora, the underlying zlib implementation might
...

💬 cobratbq commented on pull request "doc: update interface, --stdin flag, `signtx` (#31005)":
(https://github.com/bitcoin/bitcoin/pull/33765#issuecomment-3582846817)
@maflcko I expected that someone would squash upon integrating the work. Now squashed.
I included some of the changes from #33947, though not verbatim. It may be worth checking the changes again, as a whole.

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#issuecomment-3582852010)
New tarball is now available. Open/close to kick the CI.