💬 instagibbs commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2561115129)
ff2a16af040ac0906b4ebd488b1125b6ea25fa14

I don't think we should be tie-breaking based on size here?

```Suggestion
if (chunk_feerate_vsize << m_options.blockMinFeeRate.GetFeePerVSize()) {
```

💬 TheCharlatan commented on pull request "kernel: Flush in ChainstateManager destructor":
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3577481478)
Re https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3576740793

> I don't think this is accurate?

Thanks, updated.

💬 TheCharlatan commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#discussion_r2561338134)
I added a simple headers-first sync mechanism to kernel-ndoe here: https://github.com/TheCharlatan/kernel-node/pull/23

💬 RandyMcMillan commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#issuecomment-3577504127)
👀

💬 RandyMcMillan commented on pull request "chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us":
(https://github.com/bitcoin/bitcoin/pull/33723#issuecomment-3577531903)
ACK b0c7067

🤔 hebasto reviewed a pull request: "depends: latest config.guess & config.sub"
(https://github.com/bitcoin/bitcoin/pull/33945#pullrequestreview-3506757696)
My Guix build:
```
aarch64
50d2ead905b87b4064fd66a0c0a2dc88a7ada65e2224f1ff992bc7ec685e493d guix-build-3e4355314b1a/output/aarch64-linux-gnu/SHA256SUMS.part
923b405f4eb8cb7158f2b4aef0918e48e7e57ef097871d0702dbbd5286013d32 guix-build-3e4355314b1a/output/aarch64-linux-gnu/bitcoin-3e4355314b1a-aarch64-linux-gnu-debug.tar.gz
10317ea4cbaf9b6911592d0d4636d5959bf31f8ad0210cfe8decc4a5ebaa99fb guix-build-3e4355314b1a/output/aarch64-linux-gnu/bitcoin-3e4355314b1a-aarch64-linux-gnu.tar.gz
70bceac6d13861
...

👍 hebasto approved a pull request: "depends: latest config.guess & config.sub"
(https://github.com/bitcoin/bitcoin/pull/33945#pullrequestreview-3506773750)
ACK 3e4355314b1abf8e4456ea41ba738aaae25abb73, I have reviewed the code and it looks OK.

💬 hebasto commented on pull request "depends, doc: Learn `x86_64-w64-mingw32ucrt` host and document it":
(https://github.com/bitcoin/bitcoin/pull/33857#issuecomment-3577653125)
> > I’m unable to reproduce this in a fresh Trixie container using Docker
>
> I did almost the same apart from I checked out this PR rather than building from master.

Sorry. I've adjusted my comment.

> This works on x86 but isn't working on Apple ARM for me.

I can confirm the issue on `aarch64`.

💬 lucasbalieiro commented on issue "Memory leak when using IPC mining interface":
(https://github.com/bitcoin/bitcoin/issues/33940#issuecomment-3577712972)
> [@lucasbalieiro](https://github.com/lucasbalieiro) does Bitcoin Core behave better if you compile the `30.x` branch from source? That's the equivalent of how v30.1 will behave when it comes out.

Built Bitcoin Core at commit **a14e7b9dee9145920f93eab0254ce92942bd1e5e**:

```bash
root@srv-f20833:~/Projects/bitcoin/build/bin# git log
commit a14e7b9dee9145920f93eab0254ce92942bd1e5e (HEAD -> 30.x, origin/30.x)
Merge: d0f6d9953a ae63cc4bf2
Author: merge-script <fanquake@gmail.com>
Date: Thu
```

...

💬 hebasto commented on pull request "depends, doc: Learn `x86_64-w64-mingw32ucrt` host and document it":
(https://github.com/bitcoin/bitcoin/pull/33857#issuecomment-3577726631)
> > This works on x86 but isn't working on Apple ARM for me.
>
> I can confirm the issue on `aarch64`.

See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1121403.

💬 diegoviola commented on pull request "Revert "gui, qt: brintToFront workaround for Wayland"":
(https://github.com/bitcoin-core/gui/pull/914#issuecomment-3577784256)
> Built correctly from source both Qt 6.3.2 and 6.10.0, and bringToFront doesn't work on either of them using Wayland.
> 2025-11-25T19:22:58Z System: Ubuntu 22.04.5 LTS, x86_64-little_endian-lp64

That's because Mutter on that GNOME version doesn't support the [XDG activation protocol](https://wayland.app/protocols/xdg-activation-v1). Which is the protocol used by clients to request activation of surfaces.

`GUIUtil::bringToFront` uses `activateWindow()` which uses the XDG activation protoc
...

💬 AndKe commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-3577790159)
even with QT_QPA_PLATFORM=xcb bitcoin-qt is very broken.
Interestingly : bitcoin-25.1 works perfectly fine, 30.0 is very broken on Wayland.

👍 hodlinator approved a pull request: "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation"
(https://github.com/bitcoin/bitcoin/pull/33878#pullrequestreview-3503770177)
ACK 825d677a863d153d4c466288397da773ee2bb2f5

Operating on `std::span<std::byte>` rather than `std::vector<bool>&` enables for efficient use of asmap data embedded in the binary (#28792).

I have thoroughly reviewed and contributed patches for this refactoring up to the point of having a conflict of interest in getting it merged. :)

To build more confidence of the `bool` -> `byte` transition, I developed a C++ test with more readable asmap input data - cf34bb9806e95116d4b65b6dc80dc11a1f723a51 (
...

💬 hodlinator commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2558964758)
Ah, makes sense too. :+1:

💬 hodlinator commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2559145317)
nit: Seems to compile fine without this on Clang:
```suggestion
if (!CheckStandardAsmap(asmap)) {
```

💬 hodlinator commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2559059898)
Thank you for taking the patch! :handshake:

Agreed, it builds on https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2545416624

💬 hodlinator commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2559163190)
meganit in dc0c4310bae257236d3cd6a06de8071276d4548b: Empty line is removed only to be re-added in next commit.

👍 theStack approved a pull request: "test: Fix reorg patterns in tests to use proper fork-based approach"
(https://github.com/bitcoin/bitcoin/pull/32587#pullrequestreview-3507213147)
re-ACK 2a64851c34fcf9955a673eb77463f68ab583a7bd

meta nit: the `create_empty_fork` removal slipped again from first into second commit. Still fine to merge as-is, as far as I'm concerned.

💬 fjahr commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#issuecomment-3577923878)
> To build more confidence of the bool -> byte transition, I developed a C++ test with more readable asmap input data - https://github.com/bitcoin/bitcoin/commit/cf34bb9806e95116d4b65b6dc80dc11a1f723a51 (https://github.com/hodlinator/bitcoin/tree/pr/33878_suggestions2 for interleaved branch). Not sure whether it's worth including in some form.

Thanks, looks like a very nice visualization at least. I will consider including it and addressing your other comments until I have to retouch here. If
...

💬 fjahr commented on pull request "wallet: Expand MuSig test coverage and follow-ups":
(https://github.com/bitcoin/bitcoin/pull/33636#discussion_r2561897010)
Right, I did have a wrong understanding here. I guess I didn't review the musig descriptors PR and I went by my assumptions, but I have looked at the PR again and at BIP390 and it seems like hitting this error should be impossible. Thanks!