🚀 fanquake merged a pull request: "ci: Remove redundant busybox option"
(https://github.com/bitcoin/bitcoin/pull/33903)
(https://github.com/bitcoin/bitcoin/pull/33903)
📝 fanquake opened a pull request: "depends: latest config.guess & config.sub"
(https://github.com/bitcoin/bitcoin/pull/33945)
It's been about a year since these were last updated.
Pull in the latest versions.
(https://github.com/bitcoin/bitcoin/pull/33945)
It's been about a year since these were last updated.
Pull in the latest versions.
💬 willcl-ark commented on pull request "doc: document capnproto and libmultiprocess deps in 29.x":
(https://github.com/bitcoin/bitcoin/pull/33623#discussion_r2560701492)
Thanks, suggestions taken in 1d2251850dd
(https://github.com/bitcoin/bitcoin/pull/33623#discussion_r2560701492)
Thanks, suggestions taken in 1d2251850dd
💬 willcl-ark commented on pull request "doc: document capnproto and libmultiprocess deps in 29.x":
(https://github.com/bitcoin/bitcoin/pull/33623#discussion_r2560704014)
Suggestions here also taken in 1d2251850dd.
I opted to keep the suggested sentence, as I feel like stating (somewhere) that v6.0+ is known to _not work_ is useful.
(https://github.com/bitcoin/bitcoin/pull/33623#discussion_r2560704014)
Suggestions here also taken in 1d2251850dd.
I opted to keep the suggested sentence, as I feel like stating (somewhere) that v6.0+ is known to _not work_ is useful.
💬 willcl-ark commented on pull request "doc: document capnproto and libmultiprocess deps in 29.x":
(https://github.com/bitcoin/bitcoin/pull/33623#issuecomment-3576577336)
> Concept ACK - @willcl-ark did you want to address any of the suggestions here?
Sorry, PR updated now, taking @ryanofsky's suggestions.
(https://github.com/bitcoin/bitcoin/pull/33623#issuecomment-3576577336)
> Concept ACK - @willcl-ark did you want to address any of the suggestions here?
Sorry, PR updated now, taking @ryanofsky's suggestions.
👋 maflcko's pull request is ready for review: "ci: Call docker exec from Python script to fix word splitting"
(https://github.com/bitcoin/bitcoin/pull/33732)
(https://github.com/bitcoin/bitcoin/pull/33732)
💬 fanquake commented on pull request "depends: Add patch for Windows11Style plugin":
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576652873)
Guix Build (x86_64):
```bash
6d741dc4705f40f8b75abb084e232a2918565a22b2d000587fb952d91c1d8637 guix-build-8558902e576e/output/dist-archive/bitcoin-8558902e576e.tar.gz
f37da8124a6392893fc7b18cfd72c616cac022eaed66725b1632b9e0011e1391 guix-build-8558902e576e/output/x86_64-w64-mingw32/SHA256SUMS.part
aa44003342fd3e4fb9d8c1693d12d31788626988cd9f47840e21afe9203deef0 guix-build-8558902e576e/output/x86_64-w64-mingw32/bitcoin-8558902e576e-win64-codesigning.tar.gz
ad14fac93313dcaaba144f944cd0058ef1
...
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576652873)
Guix Build (x86_64):
```bash
6d741dc4705f40f8b75abb084e232a2918565a22b2d000587fb952d91c1d8637 guix-build-8558902e576e/output/dist-archive/bitcoin-8558902e576e.tar.gz
f37da8124a6392893fc7b18cfd72c616cac022eaed66725b1632b9e0011e1391 guix-build-8558902e576e/output/x86_64-w64-mingw32/SHA256SUMS.part
aa44003342fd3e4fb9d8c1693d12d31788626988cd9f47840e21afe9203deef0 guix-build-8558902e576e/output/x86_64-w64-mingw32/bitcoin-8558902e576e-win64-codesigning.tar.gz
ad14fac93313dcaaba144f944cd0058ef1
...
💬 TheCharlatan commented on pull request "kernel: Flush in ChainstateManager destructor":
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3576656963)
Rebased d9cc26d3b2b5c6a62937f1848f99ed430ed4bade -> ba29aaf28b6f0f63d2fec546fe1c60fe216d6c3a ([chainman_flush_destructor_8](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_8) -> [chainman_flush_destructor_9](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainman_flush_destructor_8..chainman_flush_destructor_9))
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3576656963)
Rebased d9cc26d3b2b5c6a62937f1848f99ed430ed4bade -> ba29aaf28b6f0f63d2fec546fe1c60fe216d6c3a ([chainman_flush_destructor_8](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_8) -> [chainman_flush_destructor_9](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainman_flush_destructor_8..chainman_flush_destructor_9))
💬 fanquake commented on pull request "depends: Add patch for Windows11Style plugin":
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576659216)
ACK 8558902e576e2c2d66f6083b66953dd6cc464de4 - did not test on Windows.
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576659216)
ACK 8558902e576e2c2d66f6083b66953dd6cc464de4 - did not test on Windows.
✅ fanquake closed an issue: "Amount field too narrow on Windows in Send Coins dialog"
(https://github.com/bitcoin-core/gui/issues/906)
(https://github.com/bitcoin-core/gui/issues/906)
🚀 fanquake merged a pull request: "depends: Add patch for Windows11Style plugin"
(https://github.com/bitcoin/bitcoin/pull/33906)
(https://github.com/bitcoin/bitcoin/pull/33906)
💬 TheCharlatan commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#issuecomment-3576666956)
Rebased a9ec7cdc0a1f6d4a3bd532649e79459074ed9f3b -> 4c387e938015de197860215d94b9c9aee9a82da8 ([kernelInternalLib_21](https://github.com/TheCharlatan/bitcoin/tree/kernelInternalLib_21) -> [kernelInternalLib_22](https://github.com/TheCharlatan/bitcoin/tree/kernelInternalLib_22), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelInternalLib_21..kernelInternalLib_22))
(https://github.com/bitcoin/bitcoin/pull/28690#issuecomment-3576666956)
Rebased a9ec7cdc0a1f6d4a3bd532649e79459074ed9f3b -> 4c387e938015de197860215d94b9c9aee9a82da8 ([kernelInternalLib_21](https://github.com/TheCharlatan/bitcoin/tree/kernelInternalLib_21) -> [kernelInternalLib_22](https://github.com/TheCharlatan/bitcoin/tree/kernelInternalLib_22), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelInternalLib_21..kernelInternalLib_22))
💬 roconnor commented on pull request "Align legacy script policy with P2SH policy in AreInputsStandard":
(https://github.com/bitcoin/bitcoin/pull/33926#discussion_r2560793067)
Maybe it is better to add a new `TxoutType::LEGACY` and just match on that (putting NONSTADARD back on the line above) rather than redoing some of the work already done by Solver.
(https://github.com/bitcoin/bitcoin/pull/33926#discussion_r2560793067)
Maybe it is better to add a new `TxoutType::LEGACY` and just match on that (putting NONSTADARD back on the line above) rather than redoing some of the work already done by Solver.
💬 l0rinc commented on pull request "doc: clarify and cleanup macOS fuzzing notes":
(https://github.com/bitcoin/bitcoin/pull/33921#issuecomment-3576682607)
@fanquake, what was the urgency to merge here?
(https://github.com/bitcoin/bitcoin/pull/33921#issuecomment-3576682607)
@fanquake, what was the urgency to merge here?
💬 fanquake commented on pull request "depends: Add patch for Windows11Style plugin":
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576691652)
Backported to `30.x` in #33609.
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576691652)
Backported to `30.x` in #33609.
💬 Sjors commented on pull request "mining: add getMemoryLoad() and track template non-mempool memory footprint":
(https://github.com/bitcoin/bitcoin/pull/33922#issuecomment-3576715015)
`mining_getblocktemplate_longpoll.py` triggered a `stack-use-after-return`, due to `block_template` being `static` (to allow template reuse between RPC calls). I added a commit to move this longpoll template to the node context.
(https://github.com/bitcoin/bitcoin/pull/33922#issuecomment-3576715015)
`mining_getblocktemplate_longpoll.py` triggered a `stack-use-after-return`, due to `block_template` being `static` (to allow template reuse between RPC calls). I added a commit to move this longpoll template to the node context.
💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2560837987)
Thanks - fixed in [c2088a7458...ff5c3fecea](https://github.com/bitcoin/bitcoin/compare/c2088a74586742cadc0041cab8782c423eda3bd0..ff5c3feceaba496ff25efd8420cfcc32e0864bcc).
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2560837987)
Thanks - fixed in [c2088a7458...ff5c3fecea](https://github.com/bitcoin/bitcoin/compare/c2088a74586742cadc0041cab8782c423eda3bd0..ff5c3feceaba496ff25efd8420cfcc32e0864bcc).
💬 maflcko commented on pull request "kernel: Flush in ChainstateManager destructor":
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3576740793)
> allows for getting rid of the `goto` in `bitcoin-chainstate` as well as making it a bit easier to use for future users of the kernel library.
I don't think this is accurate?
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3576740793)
> allows for getting rid of the `goto` in `bitcoin-chainstate` as well as making it a bit easier to use for future users of the kernel library.
I don't think this is accurate?
💬 roconnor commented on pull request "Align legacy script policy with P2SH policy in AreInputsStandard":
(https://github.com/bitcoin/bitcoin/pull/33926#issuecomment-3576845925)
My best guess is that making legacy script standard means that randomly generated ScriptPubKeys are now generally mempool acceptable whereas before only very few specifically shaped ScriptPubKeys could be accepted and weren't being generated by the fuzzer. This is exposing some kind of error in the `process_messages` fuzz test harness.
One thing to explore is to see if reverting PR #32822 makes the failure disappear. If so then we maybe narrowed down the problem to the recent changes to thi
...
(https://github.com/bitcoin/bitcoin/pull/33926#issuecomment-3576845925)
My best guess is that making legacy script standard means that randomly generated ScriptPubKeys are now generally mempool acceptable whereas before only very few specifically shaped ScriptPubKeys could be accepted and weren't being generated by the fuzzer. This is exposing some kind of error in the `process_messages` fuzz test harness.
One thing to explore is to see if reverting PR #32822 makes the failure disappear. If so then we maybe narrowed down the problem to the recent changes to thi
...
💬 Sjors commented on issue "Memory leak when using IPC mining interface":
(https://github.com/bitcoin/bitcoin/issues/33940#issuecomment-3576959068)
@lucasbalieiro does Bitcoin Core behave better if you compile the `30.x` branch from source?
(https://github.com/bitcoin/bitcoin/issues/33940#issuecomment-3576959068)
@lucasbalieiro does Bitcoin Core behave better if you compile the `30.x` branch from source?