💬 Sjors commented on pull request "mining: add getMemoryLoad() and track template non-mempool memory footprint":
(https://github.com/bitcoin/bitcoin/pull/33922#issuecomment-3576359913)
I restructured the implementation and commits a bit.


The `TxTemplateMap` now lives on the `NodeContext` rather than `MinerImpl` (interface). This reflects the fact that we want to track the global memory footprint instead of per client. It's a lightweight member `template_tx_refs` which should be easy to fold into a block template manager later.

It also made it easier to move `GetTemplateMemoryUsage` from `interface.cpp` to `miner.cpp`, where it's more reusable.

This in turn let me sp
...

🚀 fanquake merged a pull request: "txgraph: drop move assignment operator"
(https://github.com/bitcoin/bitcoin/pull/33862)

📝 instagibbs converted_to_draft a pull request: "policy: don't CheckEphemeralSpends on reorg"
(https://github.com/bitcoin/bitcoin/pull/33616)
Similar reasoning to https://github.com/bitcoin/bitcoin/pull/33504

During a deeper reorg it's possible that a long sequence of dust-having transactions that are connected in a linear fashion. On reorg, this could cause each subsequent "generation" to be rejected. These rejected transactions may contain a large amount of competitive fees via normal means.

PreCheck based `PreCheckEphemeralSpends` is left in place because we wouldn't have relayed them prior to the reorg.

based on #32587 to
...

💬 instagibbs commented on pull request "policy: don't CheckEphemeralSpends on reorg":
(https://github.com/bitcoin/bitcoin/pull/33616#issuecomment-3576395944)
marking as draft for now until it becomes dependency-less and I've looked over the tests some more

👋 instagibbs's pull request is ready for review: "policy: Remove individual transaction <minrelay restriction"
(https://github.com/bitcoin/bitcoin/pull/33892)

📝 oxyzenQ opened a pull request: "Request: fix typos in "release-notes-0.18.0.md" and "release-notes-0.15.0.1.md""
(https://github.com/bitcoin/bitcoin/pull/33944)
Typos Identified:

1. "seperate" → should be "separate"
- File: doc/release-notes/release-notes-0.18.0.md
- Line: 909-947 region
- Text: "#15043 Build fuzz targets into seperate executables (MarcoFalke)"
- URL: https://github.com/bitcoin/bitcoin/blob/0690514d4f72aac251ee0b876cded9187d42c63e/doc/release-notes/release-notes-0.18.0.md#L909-L947

2. "occuring" → should be "occurring"
- File: doc/release-notes/release-notes-0.15.0.1.md
- Line: 1-87 region
- Text: "This is a minimal patch t
...

💬 fanquake commented on pull request "contrib: Count entry differences in asmap-tool diff summary":
(https://github.com/bitcoin/bitcoin/pull/33939#issuecomment-3576475295)
cc @hodlinator

🤔 ismaelsadeeq reviewed a pull request: "doc: clarify and cleanup macOS fuzzing notes"
(https://github.com/bitcoin/bitcoin/pull/33921#pullrequestreview-3505882668)
reACK c34bc01b2ff2fc91ed4020288c5fa15f0c5b075e

I think recommending to fuzz using docker is a good idea.

✅ fanquake closed an issue: "RFC: Do we want to support fuzzing on MacOS?"
(https://github.com/bitcoin/bitcoin/issues/33731)

🚀 fanquake merged a pull request: "doc: clarify and cleanup macOS fuzzing notes"
(https://github.com/bitcoin/bitcoin/pull/33921)

💬 ismaelsadeeq commented on pull request "doc: clarify and cleanup macOS fuzzing notes":
(https://github.com/bitcoin/bitcoin/pull/33921#discussion_r2560644830)
I see your point @l0rinc but IHMO that should be in a separate PR? Tested independently and reviewed by contributors ensuring the guide works as expected.
But prior to that we can merge this, and clear the ambiguity.

🚀 fanquake merged a pull request: "ci: Remove redundant busybox option"
(https://github.com/bitcoin/bitcoin/pull/33903)

📝 fanquake opened a pull request: "depends: latest config.guess & config.sub"
(https://github.com/bitcoin/bitcoin/pull/33945)
It's been about a year since these were last updated.
Pull in the latest versions.

💬 willcl-ark commented on pull request "doc: document capnproto and libmultiprocess deps in 29.x":
(https://github.com/bitcoin/bitcoin/pull/33623#discussion_r2560701492)
Thanks, suggestions taken in 1d2251850dd

💬 willcl-ark commented on pull request "doc: document capnproto and libmultiprocess deps in 29.x":
(https://github.com/bitcoin/bitcoin/pull/33623#discussion_r2560704014)
Suggestions here also taken in 1d2251850dd.

I opted to keep the suggested sentence, as I feel like stating (somewhere) that v6.0+ is known to _not work_ is useful.

💬 willcl-ark commented on pull request "doc: document capnproto and libmultiprocess deps in 29.x":
(https://github.com/bitcoin/bitcoin/pull/33623#issuecomment-3576577336)
> Concept ACK - @willcl-ark did you want to address any of the suggestions here?

Sorry, PR updated now, taking @ryanofsky's suggestions.

👋 maflcko's pull request is ready for review: "ci: Call docker exec from Python script to fix word splitting"
(https://github.com/bitcoin/bitcoin/pull/33732)

💬 fanquake commented on pull request "depends: Add patch for Windows11Style plugin":
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576652873)
Guix Build (x86_64):
```bash
6d741dc4705f40f8b75abb084e232a2918565a22b2d000587fb952d91c1d8637 guix-build-8558902e576e/output/dist-archive/bitcoin-8558902e576e.tar.gz
f37da8124a6392893fc7b18cfd72c616cac022eaed66725b1632b9e0011e1391 guix-build-8558902e576e/output/x86_64-w64-mingw32/SHA256SUMS.part
aa44003342fd3e4fb9d8c1693d12d31788626988cd9f47840e21afe9203deef0 guix-build-8558902e576e/output/x86_64-w64-mingw32/bitcoin-8558902e576e-win64-codesigning.tar.gz
ad14fac93313dcaaba144f944cd0058ef1
...

💬 TheCharlatan commented on pull request "kernel: Flush in ChainstateManager destructor":
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3576656963)
Rebased d9cc26d3b2b5c6a62937f1848f99ed430ed4bade -> ba29aaf28b6f0f63d2fec546fe1c60fe216d6c3a ([chainman_flush_destructor_8](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_8) -> [chainman_flush_destructor_9](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainman_flush_destructor_8..chainman_flush_destructor_9))

💬 fanquake commented on pull request "depends: Add patch for Windows11Style plugin":
(https://github.com/bitcoin/bitcoin/pull/33906#issuecomment-3576659216)
ACK 8558902e576e2c2d66f6083b66953dd6cc464de4 - did not test on Windows.