🚀 fanquake merged a pull request: "depends: Update Qt download link"
(https://github.com/bitcoin/bitcoin/pull/33918)
(https://github.com/bitcoin/bitcoin/pull/33918)
⚠️ fanquake reopened an issue: "depends: fallback server missing Qt downloads"
(https://github.com/bitcoin/bitcoin/issues/33898)
Looks like `https://code.qt.io` is down / having issues. None of the files needed from that site are available from the fallback server:
```bash
Checksum missing or mismatched for qt source. Forcing re-download.
Fetching qtbase-everywhere-src-6.7.3.tar.xz from https://download.qt.io/archive/qt/6.7/6.7.3/submodules
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 281 100 281 0
...
(https://github.com/bitcoin/bitcoin/issues/33898)
Looks like `https://code.qt.io` is down / having issues. None of the files needed from that site are available from the fallback server:
```bash
Checksum missing or mismatched for qt source. Forcing re-download.
Fetching qtbase-everywhere-src-6.7.3.tar.xz from https://download.qt.io/archive/qt/6.7/6.7.3/submodules
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 281 100 281 0
...
✅ fanquake closed an issue: "depends: fallback server missing Qt downloads"
(https://github.com/bitcoin/bitcoin/issues/33898)
(https://github.com/bitcoin/bitcoin/issues/33898)
🚀 fanquake merged a pull request: "clang-format: Set Bitcoin Core IncludeCategories"
(https://github.com/bitcoin/bitcoin/pull/33917)
(https://github.com/bitcoin/bitcoin/pull/33917)
🚀 fanquake merged a pull request: "kernel: add btck_block_tree_entry_equals"
(https://github.com/bitcoin/bitcoin/pull/33855)
(https://github.com/bitcoin/bitcoin/pull/33855)
🤔 rkrux reviewed a pull request: "test: add `-alertnotify` test for large work invalid chain warning"
(https://github.com/bitcoin/bitcoin/pull/33893#pullrequestreview-3504869689)
ACK 8343a9ffcc752f77eb2248315d10b6dff4a5c98b (post-merge as it got merged while I was reviewing)
Quite a neat test.
(https://github.com/bitcoin/bitcoin/pull/33893#pullrequestreview-3504869689)
ACK 8343a9ffcc752f77eb2248315d10b6dff4a5c98b (post-merge as it got merged while I was reviewing)
Quite a neat test.
💬 rkrux commented on pull request "test: add `-alertnotify` test for large work invalid chain warning":
(https://github.com/bitcoin/bitcoin/pull/33893#discussion_r2559825313)
Re: https://github.com/bitcoin/bitcoin/pull/33893#issuecomment-3549085496
> Another alternative could be to create and submit one invalid block, then submit a longer chain forking enough blocks before the invalid block
I was tinkering with this portion and found that by making only the first block invalid while keeping the rest of the blocks valid, and submitting the invalid block at the end also causes the warning.
```diff
--- a/test/functional/feature_notifications.py
+++ b/test/functional/
...
(https://github.com/bitcoin/bitcoin/pull/33893#discussion_r2559825313)
Re: https://github.com/bitcoin/bitcoin/pull/33893#issuecomment-3549085496
> Another alternative could be to create and submit one invalid block, then submit a longer chain forking enough blocks before the invalid block
I was tinkering with this portion and found that by making only the first block invalid while keeping the rest of the blocks valid, and submitting the invalid block at the end also causes the warning.
```diff
--- a/test/functional/feature_notifications.py
+++ b/test/functional/
...
💬 ryanofsky commented on issue "Mining interface tracking issue":
(https://github.com/bitcoin/bitcoin/issues/33777#issuecomment-3575428504)
@Sjors I'm wondering which mining PRs & issues to focus on since there seem to be a lot open now. Feel free to tag me on any or mention any priorities here. I noticed there seemed to be a lot of these while updating the multiprocess tracking issue #28722 yesterday.
I was also wondering if there are bitcoin or libmultiprocess features I should start working on. Ones I was thinking of were:
- Adding exception types that could be thrown from IPC methods to return capnp [failed / overloaded / unim
...
(https://github.com/bitcoin/bitcoin/issues/33777#issuecomment-3575428504)
@Sjors I'm wondering which mining PRs & issues to focus on since there seem to be a lot open now. Feel free to tag me on any or mention any priorities here. I noticed there seemed to be a lot of these while updating the multiprocess tracking issue #28722 yesterday.
I was also wondering if there are bitcoin or libmultiprocess features I should start working on. Ones I was thinking of were:
- Adding exception types that could be thrown from IPC methods to return capnp [failed / overloaded / unim
...
💬 fanquake commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#issuecomment-3575432464)
Please rebase this.
(https://github.com/bitcoin/bitcoin/pull/32587#issuecomment-3575432464)
Please rebase this.
💬 sipa commented on pull request "txgraph: drop move assignment operator":
(https://github.com/bitcoin/bitcoin/pull/33862#issuecomment-3575447242)
Rebased after merge of #33629.
(https://github.com/bitcoin/bitcoin/pull/33862#issuecomment-3575447242)
Rebased after merge of #33629.
💬 sipa commented on pull request "Replace cluster linearization algorithm with SFL":
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3575453927)
Rebased after merge of #33629.
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3575453927)
Rebased after merge of #33629.
💬 sipa commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#issuecomment-3575461465)
Needs rebase!
(https://github.com/bitcoin/bitcoin/pull/33591#issuecomment-3575461465)
Needs rebase!
💬 psam21 commented on pull request "depends: Fix native_capnp to respect build_CC and build_CXX":
(https://github.com/bitcoin/bitcoin/pull/33937#issuecomment-3575469910)
@ryanofsky Thanks for pushing for the detailed the investigation. You're absolutely right - I tested it and the `config_env` approach doesn't actually change the behavior.
I compared both scenarios:
Without the fix (master): `env CC="gcc" CXX="g++" ... cmake`
With the fix (this PR): `env CC="gcc" CXX="g++" ... cmake`
Even when running `make CC=clang CXX=clang++`, both produce identical results using gcc. The issue is that `$(build_CC)` defaults to `gcc` in depends/builders/default.mk, a
...
(https://github.com/bitcoin/bitcoin/pull/33937#issuecomment-3575469910)
@ryanofsky Thanks for pushing for the detailed the investigation. You're absolutely right - I tested it and the `config_env` approach doesn't actually change the behavior.
I compared both scenarios:
Without the fix (master): `env CC="gcc" CXX="g++" ... cmake`
With the fix (this PR): `env CC="gcc" CXX="g++" ... cmake`
Even when running `make CC=clang CXX=clang++`, both produce identical results using gcc. The issue is that `$(build_CC)` defaults to `gcc` in depends/builders/default.mk, a
...
✅ maflcko closed a pull request: "depends: Fix native_capnp to respect build_CC and build_CXX"
(https://github.com/bitcoin/bitcoin/pull/33937)
(https://github.com/bitcoin/bitcoin/pull/33937)
💬 maflcko commented on pull request "depends: Fix native_capnp to respect build_CC and build_CXX":
(https://github.com/bitcoin/bitcoin/pull/33937#issuecomment-3575480041)
Closing as an LLM generated "AI agent" patch. Please note that contributors are required to fully understand their authored code themselves.
Also, the explanation is obviously wrong and hallucinated.
If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals. Also, see the [contributing guidelines](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring).
...
(https://github.com/bitcoin/bitcoin/pull/33937#issuecomment-3575480041)
Closing as an LLM generated "AI agent" patch. Please note that contributors are required to fully understand their authored code themselves.
Also, the explanation is obviously wrong and hallucinated.
If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals. Also, see the [contributing guidelines](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring).
...
💬 l0rinc commented on pull request "txgraph: drop move assignment operator":
(https://github.com/bitcoin/bitcoin/pull/33862#issuecomment-3575488229)
reACK ade0397f59f2fb59ab0e4ebb39869ac343cc54ee
Redid the rebase (no conflicts, how come rebase was needed?) and soft reset against PR, no changed.
Verifired the same with `git range-diff aef40b93cf057d2a27d61881b0858d491206bcd3...ade0397f59f2fb59ab0e4ebb39869ac343cc54ee`
(https://github.com/bitcoin/bitcoin/pull/33862#issuecomment-3575488229)
reACK ade0397f59f2fb59ab0e4ebb39869ac343cc54ee
Redid the rebase (no conflicts, how come rebase was needed?) and soft reset against PR, no changed.
Verifired the same with `git range-diff aef40b93cf057d2a27d61881b0858d491206bcd3...ade0397f59f2fb59ab0e4ebb39869ac343cc54ee`
✅ fjahr closed a pull request: "init: Split file path handling out of -asmap option"
(https://github.com/bitcoin/bitcoin/pull/33631)
(https://github.com/bitcoin/bitcoin/pull/33631)
💬 fjahr commented on pull request "init: Split file path handling out of -asmap option":
(https://github.com/bitcoin/bitcoin/pull/33631#issuecomment-3575555047)
Seems like there is now more opposition to this approach, so I will close this and consider an alternative as a follow-up when the embedding is merged.
(https://github.com/bitcoin/bitcoin/pull/33631#issuecomment-3575555047)
Seems like there is now more opposition to this approach, so I will close this and consider an alternative as a follow-up when the embedding is merged.
💬 fjahr commented on pull request "build: Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2559959760)
Ah, I get it now, I guess it was late yesterdays. Seems like @fanquake already fixed it.
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2559959760)
Ah, I get it now, I guess it was late yesterdays. Seems like @fanquake already fixed it.
👍 fanquake approved a pull request: "scripted-diff: Use LogInfo over LogPrintf [WIP, NOMERGE, DRAFT]"
(https://github.com/bitcoin/bitcoin/pull/29641#pullrequestreview-3505073521)
ACK 317b71bcd2e552f93ac2131b16a8acab414567dd - I think the conflicts here are small, and a number are themselves draft / WIP.
(https://github.com/bitcoin/bitcoin/pull/29641#pullrequestreview-3505073521)
ACK 317b71bcd2e552f93ac2131b16a8acab414567dd - I think the conflicts here are small, and a number are themselves draft / WIP.