💬 fanquake commented on pull request "init: Split file path handling out of -asmap option":
(https://github.com/bitcoin/bitcoin/pull/33631#issuecomment-3575244180)
> I think having two options to control such a minor feature is unintuive and overkill. If that's what people like, no objection as it really isn't important. But my preference would be to put everything in the -asmap option:

I agree.

🚀 fanquake merged a pull request: "test: add `-alertnotify` test for large work invalid chain warning"
(https://github.com/bitcoin/bitcoin/pull/33893)

💬 hulxv commented on issue "RFC: Replacing `tinyformat` with `{fmt}`":
(https://github.com/bitcoin/bitcoin/issues/33942#issuecomment-3575297752)
But from the developers' view, I think having features like compile-time error-checking and easy API and [other features](https://github.com/fmtlib/fmt?tab=readme-ov-file#features) will be helpful to have. At least it will make it a little bit easier. Maybe this is a little thing, but nice to have

💬 maflcko commented on issue "RFC: Replacing `tinyformat` with `{fmt}`":
(https://github.com/bitcoin/bitcoin/issues/33942#issuecomment-3575329532)
There is compile-time error-checking already implemented for tinyformat in this codebase, so there is also no developer benefit of using `std::format` or `{fmt}`.

💬 fanquake commented on pull request "txgraph: drop move assignment operator":
(https://github.com/bitcoin/bitcoin/pull/33862#issuecomment-3575373453)
Please rebase this.

👍 fanquake approved a pull request: "ci: Run GUI unit tests in cross-Windows task"
(https://github.com/bitcoin/bitcoin/pull/33919#pullrequestreview-3504833470)
ACK fa7ea497c3ef9366805e520205f2acf04d4d347b - didn't test.

🚀 fanquake merged a pull request: "ci: Run GUI unit tests in cross-Windows task"
(https://github.com/bitcoin/bitcoin/pull/33919)

👍 fanquake approved a pull request: "depends: Update Qt download link"
(https://github.com/bitcoin/bitcoin/pull/33918#pullrequestreview-3504837208)
ACK 50cbde3295b4b45d3ef2e5f787a33eea91ef38b5

✅ fanquake closed an issue: "depends: fallback server missing Qt downloads"
(https://github.com/bitcoin/bitcoin/issues/33898)

🚀 fanquake merged a pull request: "depends: Update Qt download link"
(https://github.com/bitcoin/bitcoin/pull/33918)

⚠️ fanquake reopened an issue: "depends: fallback server missing Qt downloads"
(https://github.com/bitcoin/bitcoin/issues/33898)
Looks like `https://code.qt.io` is down / having issues. None of the files needed from that site are available from the fallback server:
```bash
Checksum missing or mismatched for qt source. Forcing re-download.
Fetching qtbase-everywhere-src-6.7.3.tar.xz from https://download.qt.io/archive/qt/6.7/6.7.3/submodules
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 281 100 281 0
...

✅ fanquake closed an issue: "depends: fallback server missing Qt downloads"
(https://github.com/bitcoin/bitcoin/issues/33898)

🚀 fanquake merged a pull request: "clang-format: Set Bitcoin Core IncludeCategories"
(https://github.com/bitcoin/bitcoin/pull/33917)

🚀 fanquake merged a pull request: "kernel: add btck_block_tree_entry_equals"
(https://github.com/bitcoin/bitcoin/pull/33855)

🤔 rkrux reviewed a pull request: "test: add `-alertnotify` test for large work invalid chain warning"
(https://github.com/bitcoin/bitcoin/pull/33893#pullrequestreview-3504869689)
ACK 8343a9ffcc752f77eb2248315d10b6dff4a5c98b (post-merge as it got merged while I was reviewing)

Quite a neat test.

💬 rkrux commented on pull request "test: add `-alertnotify` test for large work invalid chain warning":
(https://github.com/bitcoin/bitcoin/pull/33893#discussion_r2559825313)
Re: https://github.com/bitcoin/bitcoin/pull/33893#issuecomment-3549085496

> Another alternative could be to create and submit one invalid block, then submit a longer chain forking enough blocks before the invalid block

I was tinkering with this portion and found that by making only the first block invalid while keeping the rest of the blocks valid, and submitting the invalid block at the end also causes the warning.

```diff
--- a/test/functional/feature_notifications.py
+++ b/test/functional/
...

💬 ryanofsky commented on issue "Mining interface tracking issue":
(https://github.com/bitcoin/bitcoin/issues/33777#issuecomment-3575428504)
@Sjors I'm wondering which mining PRs & issues to focus on since there seem to be a lot open now. Feel free to tag me on any or mention any priorities here. I noticed there seemed to be a lot of these while updating the multiprocess tracking issue #28722 yesterday.

I was also wondering if there are bitcoin or libmultiprocess features I should start working on. Ones I was thinking of were:

- Adding exception types that could be thrown from IPC methods to return capnp [failed / overloaded / unim
...

💬 fanquake commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#issuecomment-3575432464)
Please rebase this.

💬 sipa commented on pull request "txgraph: drop move assignment operator":
(https://github.com/bitcoin/bitcoin/pull/33862#issuecomment-3575447242)
Rebased after merge of #33629.

💬 sipa commented on pull request "Replace cluster linearization algorithm with SFL":
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3575453927)
Rebased after merge of #33629.