💬 Sjors commented on pull request "mining: add getMemoryLoad() and track template non-mempool memory footprint":
(https://github.com/bitcoin/bitcoin/pull/33922#issuecomment-3563799563)
> In my opinion, we should not rely on the IPC client to manage our memory.

> Whenever the memory budget is exhausted, we should release templates in FIFO order

It seems counter intuitive, but from a memory management perspective IPC clients are treated no different than our own code. And if we started FIFO deleting templates that are used by our own code, we'd crash.

So I think FIFO deletion should be a last resort (not implemented here).

There's another reason why we should give cl
...

💬 fjahr commented on pull request "CI: silent merge check":
(https://github.com/bitcoin/bitcoin/pull/33145#issuecomment-3563843760)
Concept ACK

💬 maflcko commented on pull request "CI: silent merge check":
(https://github.com/bitcoin/bitcoin/pull/33145#issuecomment-3563863948)
I think what could work (hacky, untested):

* Setup a separate "silent-merge-check" repo with the desired ci config
* Push the selected ci runs to it on the desired schedule
* Get the result, and on failure, pass it back to the upstream repo

💬 fanquake commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#discussion_r2550408178)
I'm wondering, give we are building IWYU from source, can we just patch it, so the output is correct (uses <>); avoiding the need for this fixup.

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550482102)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550482202)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550482323)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550482467)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550482573)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483077)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483175)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483287)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483371)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483458)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483537)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483605)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483677)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483747)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483813)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#discussion_r2550483869)
Thanks, updated in 4e038c4b7a6fbfaafe1f2570592e2bb751f9be09