💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2549174545)
Wow! Taken :) plus a comment/note that now the declaration order is now relevant, to prevent somebody reordering those in the future or inserting new members at the beginning.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2549185247)
Done, even though `CService{addr}` is also slicing according to https://github.com/isocpp/CppCoreGuidelines/blob/e49158a/CppCoreGuidelines.md#es63-dont-slice.

💬 maflcko commented on pull request "ci: Enable experimental kernel stuff in most CI tasks via `dev-mode`":
(https://github.com/bitcoin/bitcoin/pull/33824#discussion_r2549200835)
Hmm, this was fixed by setting `DYLD_LIBRARY_PATH`.

Fixed in https://github.com/maflcko/bitcoin-core-nightly/commit/c35885a1904c16918af9602e47a456b15b15e941

💬 hebasto commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#issuecomment-3562283264)
> Sensitive RPC commands such as `walletpassphrase` or `createwallet`
> have their arguments redacted when stored in the console history.
> Even though their parameters are hidden, these commands could still
> be recalled and executed again, which might lead to unintended or
> harmful actions.

If running the same RPC command twice "might lead to unintended or harmful actions", then the issue should be addressed in that command’s implementation, as it isn’t specific to the GUI console.


...

💬 maflcko commented on pull request "ci: Add Windows + UCRT jobs for cross-compiling and native testing":
(https://github.com/bitcoin/bitcoin/pull/33764#issuecomment-3562292543)
> > Not sure I understand the dependence on #33775?
> > CI is using it's own build, not the guix build right? Also MinGW brings it's own GCC doesn't it?
>
> The CI jobs are more useful when using toolchains with versions similar to those in the Guix script.

I think this is just a doc question. I think the `trixie/g++-mingw-w64-ucrt64` task can be left as-is, without adding a dependency here. In the future, https://github.com/bitcoin/bitcoin/pull/33593 could simply update the comment to cl
...

💬 maflcko commented on pull request "depends, doc: Learn `x86_64-w64-mingw32ucrt` host and document it":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2549232668)
> > It could make sense to ask Ubuntu to import g++-mingw-w64-ucrt64 from Debian, at least for the 26.04 release.
>
> It appears to be a WIP: https://packages.ubuntu.com/search?keywords=ucrt

Ah ok, so maybe someone could open a question/request at https://launchpad.net/ubuntu/+source/gcc-mingw-w64/+bugs, so that the progress can be tracked.

✅ waketraindev closed a pull request: "Add console commands for clearing output and history"
(https://github.com/bitcoin-core/gui/pull/882)

✅ waketraindev closed a pull request: "Prevent re-execution of sensitive commands from console history"
(https://github.com/bitcoin-core/gui/pull/909)

✅ waketraindev closed an issue: "No way to clear command history in RPC console or reset the console without restarting the node"
(https://github.com/bitcoin-core/gui/issues/897)

💬 maflcko commented on pull request "test: add unit test coverage for the empty leaves path in MerkleComputation":
(https://github.com/bitcoin/bitcoin/pull/33858#issuecomment-3562382383)
lgtm ACK ffcae82a68104c1992964b26c592b62cbca391bf

💬 waketraindev commented on pull request "Add console commands for clearing output and history":
(https://github.com/bitcoin-core/gui/pull/882#issuecomment-3562385876)
Closed

💬 waketraindev commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#issuecomment-3562387089)
Closed

💬 fanquake commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#issuecomment-3562449962)
`wallet_assumeutxo.py` is failing when I run it locally:
```bash
./build/test/functional/test_runner.py wallet_assumeutxo.py
Temporary test directory at /var/folders/83/bylt1m2s7xnf5ytr1g6dn7lh0000gn/T/test_runner_₿_🏃_20251121_103928
Remaining jobs: [wallet_assumeutxo.py]
1/1 - wallet_assumeutxo.py failed, Duration: 4 s

stdout:
2025-11-21T10:39:28.628294Z TestFramework (INFO): PRNG seed is: 3913925397541703779
2025-11-21T10:39:28.628710Z TestFramework (INFO): Initializing test directo
...

💬 hebasto commented on pull request "depends, doc: Learn `x86_64-w64-mingw32ucrt` host and document it":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2549347896)
> Ah ok, so maybe someone could open a question/request at https://launchpad.net/ubuntu/+source/gcc-mingw-w64/+bugs, so that the progress can be tracked.

https://bugs.launchpad.net/ubuntu/+source/gcc-mingw-w64/+bug/2132114

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2549354887)
This is a continuation of https://github.com/bitcoin/bitcoin/pull/27509#discussion_r1214671917. I think it is better to continue the discussion there to have it in one place. I asked at IRC for it to be unlocked, I guess it was locked due to inactivity.

✅ maflcko closed a pull request: "test: assumeutxo: add missing tests in wallet_assumeutxo.py"
(https://github.com/bitcoin/bitcoin/pull/30455)

📝 maflcko reopened a pull request: "test: assumeutxo: add missing tests in wallet_assumeutxo.py"
(https://github.com/bitcoin/bitcoin/pull/30455)
Adding tests in `./test/functional/wallet_assumeutxo.py` to cover the following scenario:
- test loading a wallet (backup) on a pruned node

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562633993)
The recent feedback from @fanquake has been addressed.

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2549474353)
Thanks! [Dropped](https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562633993).

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2549475436)
Thanks! [Reworked](https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562633993).