💬 achow101 commented on pull request "miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`":
(https://github.com/bitcoin/bitcoin/pull/31734#issuecomment-3549681375)
ACK 28a4fcb03c0fb1cd5112eca1eb36dcb13e0b4ff2

✅ achow101 closed an issue: "Inconsistent hardened derivation marker in `listdescriptors` output"
(https://github.com/bitcoin/bitcoin/issues/31694)

🚀 achow101 merged a pull request: "miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`"
(https://github.com/bitcoin/bitcoin/pull/31734)

📝 hebasto opened a pull request: "depends: Add patch for Windows11Style plugin"
(https://github.com/bitcoin/bitcoin/pull/33906)
This PR fixes https://github.com/bitcoin-core/gui/issues/906:

<img width="561" height="179" alt="image" src="https://github.com/user-attachments/assets/6bb6d12b-91a6-4659-b6eb-be64093ec86d" />

💬 hebasto commented on issue "Amount field too narrow on Windows in Send Coins dialog":
(https://github.com/bitcoin-core/gui/issues/906#issuecomment-3549727054)
> I'm quite sure that `QStyle::sizeFromContents()` is broken for `QWindows11Style`:
>
> [gui/src/qt/bitcoinamountfield.cpp](https://github.com/bitcoin-core/gui/blob/2444488f6ad32dcbbed51a73cd4f59ff3a239e32/src/qt/bitcoinamountfield.cpp#L147)
>
> Line 147 in [2444488](/bitcoin-core/gui/commit/2444488f6ad32dcbbed51a73cd4f59ff3a239e32)
> cachedMinimumSizeHint = style()->sizeFromContents(QStyle::CT_SpinBox, &opt, hint, this);

Fixed in https://github.com/bitcoin/bitcoin/pull/33906.

📝 andradepsa opened a pull request: "Cycles Bitcoin 2.0"
(https://github.com/bitcoin/bitcoin/pull/33907)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 hebasto commented on pull request "ci: Remove redundant busybox option":
(https://github.com/bitcoin/bitcoin/pull/33903#issuecomment-3549740070)
Concept ACK.

💬 plebhash commented on issue "Block template memory management (for IPC clients)":
(https://github.com/bitcoin/bitcoin/issues/33899#issuecomment-3549744583)
we ran some numbers

on client side, we're keeping track of:
- header: 80 bytes
- coinbase tx: ~150 bytes (empirically observed)
- merkle path: worst case ~600 bytes

assuming a rather extreme scenario:
- max block time ever observed: ~2h
- ever-increasing mempool leading to ~1 template/s

this stay below ~10MB of RAM consumption

this could only be extrapolated if we went into even more extreme scenario of mempool changes leading to sub-second template times, which actually motivated me to intr
...

💬 brunoerg commented on pull request "test: add `-alertnotify` test for large work invalid chain warning":
(https://github.com/bitcoin/bitcoin/pull/33893#issuecomment-3549777295)
> corecheck does not show any new coverage here, so I guess there is a test (via invalidateblock?) which triggers this as a side-effect?

Exactly, it's in `feature_bip68_sequence`. I guess it happens at:
https://github.com/bitcoin/bitcoin/blob/53b72372da91c5e90df865bc15961e16feb4a983/test/functional/feature_bip68_sequence.py#L341-L344

🚀 hebasto merged a pull request: "Remove HD seed reference from blank wallet tooltip"
(https://github.com/bitcoin-core/gui/pull/908)

👍 hebasto approved a pull request: "Added test coverage for qt gui#901 console history filter"
(https://github.com/bitcoin-core/gui/pull/910#pullrequestreview-3480059403)
ACK 310e4979b36cbcf1e9e01dd90c14e2e9997343a0, tested on Fedora 42 by reverting 4e352efa2ce756c668664486c99d003eef530e0c.

🚀 hebasto merged a pull request: "Added test coverage for qt gui#901 console history filter"
(https://github.com/bitcoin-core/gui/pull/910)

💬 fjahr commented on pull request "test, refactor: Embedded ASMap [1/3]: Selected minor preparatory work":
(https://github.com/bitcoin/bitcoin/pull/33026#discussion_r2539937445)
I will address this if I have to retouch

💬 hebasto commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3549873074)
@RandyMcMillan

The PR description is currently empty. Could you please add the motivation for this change, along with a few example use cases?

💬 hebasto commented on pull request "Add console commands for clearing output and history":
(https://github.com/bitcoin-core/gui/pull/882#issuecomment-3549889257)
From https://github.com/bitcoin-core/gui/issues/897#issuecomment-3335194642, it appears that this PR is intended to address https://github.com/bitcoin-core/gui/issues/897.

Is this right?

If so, is this change still necessary given that https://github.com/bitcoin-core/gui/issues/897 has since been closed?

📝 w0xlt opened a pull request: "kernel: add context‑free block validation API (`btck_check_block_context_free`) with POW/Merkle flags"
(https://github.com/bitcoin/bitcoin/pull/33908)
This PR exposes Bitcoin Core’s context‑free block checks to library users via a new C API entry point, `btck_check_block_context_free`.

Callers can validate a block’s structure (size/weight, coinbase rules, per‑tx context‑free checks) and optionally re‑run Proof‑of‑Work and Merkle‑root verification without touching chainstate, the block index, or the UTXO set.

Rationale
Clients embedding the kernel need a pure block sanity check without requiring node state or disk writes (candidate blo
...

💬 hebasto commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#issuecomment-3549895592)
Please rebase.

💬 kallewoof commented on pull request "BIP-322 basic support":
(https://github.com/bitcoin/bitcoin/pull/24058#issuecomment-3549901786)
If no one is actively looking into this at the moment, I will see about restoring (probably rewriting from scratch) this PR.

💬 waketraindev commented on pull request "Add console commands for clearing output and history":
(https://github.com/bitcoin-core/gui/pull/882#issuecomment-3549905223)
> From [#897 (comment)](https://github.com/bitcoin-core/gui/issues/897#issuecomment-3335194642), it appears that this PR is intended to address #897.
>
> Is this right?
>
> If so, is this change still necessary given that #897 has since been closed?

Hey,

I closed the issue because I have this PR open. I find the ability to clear input history necessary and I use it all the time in my builds.

💬 waketraindev commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#issuecomment-3549922600)
> Please rebase.

Rebased on top of master