💬 achow101 commented on pull request "rpc: combinerawtransaction now rejects unmergeable transactions":
(https://github.com/bitcoin/bitcoin/pull/31298#discussion_r2539683746)
nit: This is an unnecessary style change.

💬 ryanofsky commented on issue "IPC via TCP Sockets":
(https://github.com/bitcoin/bitcoin/issues/32802#issuecomment-3549542846)
Rereading the issue, I noticed I missed the references to docker, and just posted about alternatives to TCP generally.

As far as I know, there should be no issue sharing the IPC socket between the docker containers or between the host and a container on linux. The socket should look like normal file on the filesystem (`node.sock`) that can be shared with docker's `--volume` / `-v` option. On macos I don't think it's possible to share the socket between a host and container, but it should be pos
...

💬 furszy commented on pull request "http: replace WorkQueue and single threads handling for ThreadPool":
(https://github.com/bitcoin/bitcoin/pull/33689#discussion_r2539707339)
Done.

💬 furszy commented on pull request "http: replace WorkQueue and single threads handling for ThreadPool":
(https://github.com/bitcoin/bitcoin/pull/33689#discussion_r2539707584)
Done as suggested.

👍 hebasto approved a pull request: "ci: Consistenly only cache on the default branch"
(https://github.com/bitcoin/bitcoin/pull/33905#pullrequestreview-3479795946)
ACK fa411f938e4796cf3806f234c9787b7c79492cc2.

💬 ryanofsky commented on issue "rfc: virtio-vsock for RPC and IPC":
(https://github.com/bitcoin/bitcoin/issues/33897#issuecomment-3549565261)
It should be pretty easy to support vsock if we want that. I think it would only require a change to the [`ipc::ParseAddress`](https://github.com/bitcoin/bitcoin/blob/2444488f6ad32dcbbed51a73cd4f59ff3a239e32/src/ipc/process.cpp#L71-L98) function and updates to documentation and tests.

TCP support could also be added by modifying the `ParseAddress` function, but I'd be wary of doing that since it would not really be safe without authentication (https://github.com/bitcoin/bitcoin/issues/32802#iss
...

🤔 achow101 reviewed a pull request: "rpc: Handle -named argument parsing where '=' character is used"
(https://github.com/bitcoin/bitcoin/pull/32821#pullrequestreview-3479788805)
ACK f53dbbc5057b6f676db4be9bc720898149f293fc

💬 achow101 commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2539711136)
In f53dbbc5057b6f676db4be9bc720898149f293fc "test: Add functional tests for named argument parsing"

nit: Logging at the end of the test case is unnecessary

💬 achow101 commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2539711086)
In f53dbbc5057b6f676db4be9bc720898149f293fc "test: Add functional tests for named argument parsing"

nit: Logging at the end of the test case is unnecessary

💬 ryanofsky commented on issue "Block template memory management (for IPC clients)":
(https://github.com/bitcoin/bitcoin/issues/33899#issuecomment-3549589356)
> The node could refuse to make new templates when it gets to 80% full and automatically drop the oldest template if it crosses 100%.

Makes sense. The way I imagined it working is just that there would be some some configurable limit on how many much memory could be used by block template, and a createNewBlock or waitNext call exceeded that limit they could just throw an exception.

It shouldn't be necessary to modify the capnp interface to do this since cap'n proto provides a built in [OVERLOA
...

🚀 achow101 merged a pull request: "rpc: Handle -named argument parsing where '=' character is used"
(https://github.com/bitcoin/bitcoin/pull/32821)

💬 achow101 commented on pull request "miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`":
(https://github.com/bitcoin/bitcoin/pull/31734#issuecomment-3549681375)
ACK 28a4fcb03c0fb1cd5112eca1eb36dcb13e0b4ff2

✅ achow101 closed an issue: "Inconsistent hardened derivation marker in `listdescriptors` output"
(https://github.com/bitcoin/bitcoin/issues/31694)

🚀 achow101 merged a pull request: "miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`"
(https://github.com/bitcoin/bitcoin/pull/31734)

📝 hebasto opened a pull request: "depends: Add patch for Windows11Style plugin"
(https://github.com/bitcoin/bitcoin/pull/33906)
This PR fixes https://github.com/bitcoin-core/gui/issues/906:

<img width="561" height="179" alt="image" src="https://github.com/user-attachments/assets/6bb6d12b-91a6-4659-b6eb-be64093ec86d" />

💬 hebasto commented on issue "Amount field too narrow on Windows in Send Coins dialog":
(https://github.com/bitcoin-core/gui/issues/906#issuecomment-3549727054)
> I'm quite sure that `QStyle::sizeFromContents()` is broken for `QWindows11Style`:
>
> [gui/src/qt/bitcoinamountfield.cpp](https://github.com/bitcoin-core/gui/blob/2444488f6ad32dcbbed51a73cd4f59ff3a239e32/src/qt/bitcoinamountfield.cpp#L147)
>
> Line 147 in [2444488](/bitcoin-core/gui/commit/2444488f6ad32dcbbed51a73cd4f59ff3a239e32)
> cachedMinimumSizeHint = style()->sizeFromContents(QStyle::CT_SpinBox, &opt, hint, this);

Fixed in https://github.com/bitcoin/bitcoin/pull/33906.

📝 andradepsa opened a pull request: "Cycles Bitcoin 2.0"
(https://github.com/bitcoin/bitcoin/pull/33907)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 hebasto commented on pull request "ci: Remove redundant busybox option":
(https://github.com/bitcoin/bitcoin/pull/33903#issuecomment-3549740070)
Concept ACK.

💬 plebhash commented on issue "Block template memory management (for IPC clients)":
(https://github.com/bitcoin/bitcoin/issues/33899#issuecomment-3549744583)
we ran some numbers

on client side, we're keeping track of:
- header: 80 bytes
- coinbase tx: ~150 bytes (empirically observed)
- merkle path: worst case ~600 bytes

assuming a rather extreme scenario:
- max block time ever observed: ~2h
- ever-increasing mempool leading to ~1 template/s

this stay below ~10MB of RAM consumption

this could only be extrapolated if we went into even more extreme scenario of mempool changes leading to sub-second template times, which actually motivated me to intr
...

💬 brunoerg commented on pull request "test: add `-alertnotify` test for large work invalid chain warning":
(https://github.com/bitcoin/bitcoin/pull/33893#issuecomment-3549777295)
> corecheck does not show any new coverage here, so I guess there is a test (via invalidateblock?) which triggers this as a side-effect?

Exactly, it's in `feature_bip68_sequence`. I guess it happens at:
https://github.com/bitcoin/bitcoin/blob/53b72372da91c5e90df865bc15961e16feb4a983/test/functional/feature_bip68_sequence.py#L341-L344