📝 kevkevinpal opened a pull request: "rest: add interface for gettxspendingprevout rpc"
(https://github.com/bitcoin/bitcoin/pull/33904)
This creates a REST interface for the `gettxspendingprevout` RPC, it also includes functional tests and updates to the REST docs

This is part of https://github.com/bitcoin/bitcoin/issues/33808 but would still need [@sstone’s](https://github.com/sstone) PR https://github.com/bitcoin/bitcoin/pull/24539, but that can be left as a follow-up for when it is merged.

If it is prefered to open a PR after https://github.com/bitcoin/bitcoin/issues/33808 I can close this and reopen after its merged

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3548620601)
`3e6b5a9ec4...b499edb414`: take https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2527749355

💬 instagibbs commented on issue "test: intermittent issue in p2p_1p1c_network.py":
(https://github.com/bitcoin/bitcoin/issues/33318#issuecomment-3548640184)
I've also discovered that `create_package_2outs` has regressed since we lowered minrelay to 0.1s/vbyte. The `parent_4` now pays for itself rather than needing cppf.

I think it'd be better if we do 0-fee parents to make the test less brittle. I have a branch that I can push along later shortly after cluster mempool and https://github.com/bitcoin/bitcoin/pull/33892 is merged: https://github.com/instagibbs/bitcoin/commits/2025-11-1p1c-test-timeout/

As per branch I think just making sure the orpha
...

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2539016880)
Yeah, `compare_exchange_weak()` would set the current value into its first argument if it fails. No need to assign it again explicitly. Changed.

Some napkin math about the overflow - at 7 transactions per second, to have 2³² would take about 20 years. Further, `m_num_to_open` is about unconfirmed transactions, connections that the node needs to open because it has that many transactions to send. 100 bytes each means that the node stores 400GB of transactions to be broadcast. Can't
...

💬 willcl-ark commented on issue "ci: windows-native-dll-vcpkg-* cache does not work?":
(https://github.com/bitcoin/bitcoin/issues/33685#issuecomment-3548778624)
I checked the last 200 runs to see if this was still happening, and it does seem to, but a lot less frequently than when this was opened.

<details>
<summary>Details</summary>

```json
{
"job_name": "Windows native, VS 2022",
"step_name": "Generate build system",
"repo": "bitcoin/bitcoin",
"duration_seconds": [
191.0,
100.0,
101.0,
91.0,
91.0,
88.0,
110.0,
163.0,
115.0,
87.0,
115.0,
92.0,
87.0,
110.0,
98.0,
91.0,
96.0,

...

💬 hebasto commented on issue "Amount field too narrow on Windows in Send Coins dialog":
(https://github.com/bitcoin-core/gui/issues/906#issuecomment-3548808342)
It appears to be an upstream bug:: https://bugreports.qt.io/browse/QTBUG-124150.

💬 instagibbs commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2539134137)
to recap, single rbf carveout is nuked later in e031085fd464b528c186948d3cbf1c08a5a8d624

👍 instagibbs approved a pull request: "Cluster mempool"
(https://github.com/bitcoin/bitcoin/pull/33629#pullrequestreview-3479025059)
reACK 3fb3c230c93e39706b813f67006ae86c9e34e803

Minor changes, squashes and commit reorderings as suggested by other reviewers.

`git range-diff master 5b5a41b94396c9171d1a8ce076b92ac0ade54c66 3fb3c230c93e39706b813f67006ae86c9e34e803`

👍 maflcko approved a pull request: "validation: Improve warnings in case of chain corruption"
(https://github.com/bitcoin/bitcoin/pull/33553#pullrequestreview-3479097629)
re-ACK 6db2551dc27c4a9b989e8814054c93dd9d8f1b36 🍓

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 6db2551dc27c4a9b989e8814054c9
...

💬 maflcko commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2539190197)
nit in 34339dbfdcc439f394eed63af6dfb4e3e066d156:

All other give a more verbose explanation, so maybe this one can be as well?

Ref:

```
$ git grep --perl-regexp 'Invalid\(BlockValidationResult::.*?, ".*?", '
src/validation.cpp: state.Invalid(BlockValidationResult::BLOCK_CONSENSUS, "bad-blk-sigops", "too many sigops");
src/validation.cpp: return state.Invalid(BlockValidationResult::BLOCK_INVALID_HEADER, "high-hash", "proof of work failed");
src/validation.cpp: return st
...

💬 maflcko commented on issue "ci: windows-native-dll-vcpkg-* cache does not work?":
(https://github.com/bitcoin/bitcoin/issues/33685#issuecomment-3548952471)
> Cache is evicted for some reason, presumably due to low space

Good find. I guess this could be due to several branches writing windows caches. For example, right now I see `win64-native-vcpkg-binary-04fcf06a88f8571c75c5068ea9f67b8012e86d99ba204a334c696f0ec5e79551 2.6 GB cached 5 hours ago
[29.x](https://github.com/bitcoin/bitcoin/tree/29.x)
Last used 5 hours ago`. I don't think there is any value in saving caches for non-main branches, as there won't be any pull requests that could use them w
...

📝 maflcko opened a pull request: "ci: Consistenly only cache on the default branch"
(https://github.com/bitcoin/bitcoin/pull/33905)
Fixes https://github.com/bitcoin/bitcoin/issues/33685

The general idea for caches is to only save them on pushes to the default branch, because the cache is limited in size and time that the only benefit of the cache can be to speed up pull requests against the default branch.

Backport pull requests to older branches don't benefit from caches, because usually they will be running into a cache miss anyway. Also, they would cause the cache size to overflow and lead to cache misses down the l
...

💬 plebhash commented on pull request "mining: add requestedOutputs field, e.g. for merged mining":
(https://github.com/bitcoin/bitcoin/pull/33890#issuecomment-3549010283)
is this aimed at Sv2? if not, please disregard everything below

---

even though the `bitcoin_core_sv2` crate introduced via https://github.com/stratum-mining/sv2-apps/pull/59 is leveraging IPC to interact with Bitcoin Core, on the Rust side we're still abstracting the IO around Sv2 Template Distribution Protocol, for which there's no message that would be able to carry this kind of information

---

> Although it's possible to modify pool software to add merge mining outputs on top of
...

💬 hebasto commented on issue "ci: windows-native-dll-vcpkg-* cache does not work?":
(https://github.com/bitcoin/bitcoin/issues/33685#issuecomment-3549035364)
> So the fix would be to to only write the cache on the default branch?

Agreed.

💬 ryanofsky commented on pull request "Split CConnman":
(https://github.com/bitcoin/bitcoin/pull/30988#issuecomment-3549076531)

re: https://github.com/bitcoin/bitcoin/pull/30988#issuecomment-3483436641

> I think I agree with @theuni's comment in [#30988 (comment)](https://github.com/bitcoin/bitcoin/pull/30988#issuecomment-2702063374) that the http server and sv2 server probably would not benefit very much from using this, but that seems like more of a concern for #32061 than this PR.
>
> I would be interested to know more about how the HTTP and sv2 implementations "ended up with very non-optimal performance becau
...

💬 janb84 commented on pull request "ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG":
(https://github.com/bitcoin/bitcoin/pull/33888#discussion_r2539270042)
NIT (Maybe) switch order of the 2 conditions in the if statement. It's slightly more optimized and it communicated the intent better of setting one or the other extra_env.

```suggestion
if os.environ.get("GITHUB_EVENT_NAME") != "pull_request" and os.environ.get("GITHUB_REPOSITORY") == "bitcoin/bitcoin":
```

💬 plebhash commented on issue "Block template memory management (for IPC clients)":
(https://github.com/bitcoin/bitcoin/issues/33899#issuecomment-3549117345)
> so maybe they need an additional response status argument to communicate the situation.

indeed this would be essential to make sure we know why `waitNext` failed and what we need to do about it (drop old template instead of assuming something went bad)

💬 hebasto commented on issue "Amount field too narrow on Windows in Send Coins dialog":
(https://github.com/bitcoin-core/gui/issues/906#issuecomment-3549124189)
I'm quite sure that `QStyle::sizeFromContents()` is broken for `QWindows11Style`:https://github.com/bitcoin-core/gui/blob/2444488f6ad32dcbbed51a73cd4f59ff3a239e32/src/qt/bitcoinamountfield.cpp#L147

cc @laanwj, as the initial code author :)

💬 maflcko commented on pull request "ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG":
(https://github.com/bitcoin/bitcoin/pull/33888#discussion_r2539394381)
sure, done. And changed to `os.environ[key]` lookup, to get KeyError on key-typos or missing keys in the future

💬 janb84 commented on pull request "ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG":
(https://github.com/bitcoin/bitcoin/pull/33888#issuecomment-3549223965)
re ACK 55555db055b59dd529526915dfc59e5a13e43160

changes since last ACK:
- if condition order and `os.environ[key]` lookup

thanks for incorporating my suggestion !