💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538851944)
I swapped the commits, and verified that every commit in the branch I just pushed compiles.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538853181)
Squashed.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538858278)
Fixed this commit message (8e49477e86b3089ea70d1f2659b9fd3a8a1f7db4).

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538862686)
Fixed in b9a2039f51226dce2c4e38ce5f26eefee171744b.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538863183)
Squashed.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538865118)
Done.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538866223)
Thanks, fixed this wording in e031085fd464b528c186948d3cbf1c08a5a8d624

✅ willcl-ark closed a pull request: "Clear out space on GHA jobs"
(https://github.com/bitcoin/bitcoin/pull/33514)

💬 willcl-ark commented on pull request "Clear out space on GHA jobs":
(https://github.com/bitcoin/bitcoin/pull/33514#issuecomment-3548476975)
Closing for now

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2538870170)
I moved this commit much earlier in the PR (to right before the commit: "Select transactions for blocks based on chunk feerate").

💬 maflcko commented on pull request "Remove HD seed reference from blank wallet tooltip":
(https://github.com/bitcoin-core/gui/pull/908#issuecomment-3548479257)
lgtm ACK 929f69d0ff29cb803769a423035fdcf675f40b78

📝 kevkevinpal opened a pull request: "rest: add interface for gettxspendingprevout rpc"
(https://github.com/bitcoin/bitcoin/pull/33904)
This creates a REST interface for the `gettxspendingprevout` RPC, it also includes functional tests and updates to the REST docs

This is part of https://github.com/bitcoin/bitcoin/issues/33808 but would still need [@sstone’s](https://github.com/sstone) PR https://github.com/bitcoin/bitcoin/pull/24539, but that can be left as a follow-up for when it is merged.

If it is prefered to open a PR after https://github.com/bitcoin/bitcoin/issues/33808 I can close this and reopen after its merged

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3548620601)
`3e6b5a9ec4...b499edb414`: take https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2527749355

💬 instagibbs commented on issue "test: intermittent issue in p2p_1p1c_network.py":
(https://github.com/bitcoin/bitcoin/issues/33318#issuecomment-3548640184)
I've also discovered that `create_package_2outs` has regressed since we lowered minrelay to 0.1s/vbyte. The `parent_4` now pays for itself rather than needing cppf.

I think it'd be better if we do 0-fee parents to make the test less brittle. I have a branch that I can push along later shortly after cluster mempool and https://github.com/bitcoin/bitcoin/pull/33892 is merged: https://github.com/instagibbs/bitcoin/commits/2025-11-1p1c-test-timeout/

As per branch I think just making sure the orpha
...

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2539016880)
Yeah, `compare_exchange_weak()` would set the current value into its first argument if it fails. No need to assign it again explicitly. Changed.

Some napkin math about the overflow - at 7 transactions per second, to have 2³² would take about 20 years. Further, `m_num_to_open` is about unconfirmed transactions, connections that the node needs to open because it has that many transactions to send. 100 bytes each means that the node stores 400GB of transactions to be broadcast. Can't
...

💬 willcl-ark commented on issue "ci: windows-native-dll-vcpkg-* cache does not work?":
(https://github.com/bitcoin/bitcoin/issues/33685#issuecomment-3548778624)
I checked the last 200 runs to see if this was still happening, and it does seem to, but a lot less frequently than when this was opened.

<details>
<summary>Details</summary>

```json
{
"job_name": "Windows native, VS 2022",
"step_name": "Generate build system",
"repo": "bitcoin/bitcoin",
"duration_seconds": [
191.0,
100.0,
101.0,
91.0,
91.0,
88.0,
110.0,
163.0,
115.0,
87.0,
115.0,
92.0,
87.0,
110.0,
98.0,
91.0,
96.0,

...

💬 hebasto commented on issue "Amount field too narrow on Windows in Send Coins dialog":
(https://github.com/bitcoin-core/gui/issues/906#issuecomment-3548808342)
It appears to be an upstream bug:: https://bugreports.qt.io/browse/QTBUG-124150.

💬 instagibbs commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2539134137)
to recap, single rbf carveout is nuked later in e031085fd464b528c186948d3cbf1c08a5a8d624

👍 instagibbs approved a pull request: "Cluster mempool"
(https://github.com/bitcoin/bitcoin/pull/33629#pullrequestreview-3479025059)
reACK 3fb3c230c93e39706b813f67006ae86c9e34e803

Minor changes, squashes and commit reorderings as suggested by other reviewers.

`git range-diff master 5b5a41b94396c9171d1a8ce076b92ac0ade54c66 3fb3c230c93e39706b813f67006ae86c9e34e803`

👍 maflcko approved a pull request: "validation: Improve warnings in case of chain corruption"
(https://github.com/bitcoin/bitcoin/pull/33553#pullrequestreview-3479097629)
re-ACK 6db2551dc27c4a9b989e8814054c93dd9d8f1b36 🍓

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 6db2551dc27c4a9b989e8814054c9
...