💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538446734)
Have renamed to `gen-sdk.py`. Tested that the linter works locally by reintroduing rogue `import time`.

💬 yuvicc commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#issuecomment-3547905576)
Updated commit message an PR description to better reflect the changes and intention as suggested by @TheCharlatan @stickies-v.

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538447512)
Took the rest of the suggestions.

💬 Sjors commented on pull request "mining: add requestedOutputs field, e.g. for merged mining":
(https://github.com/bitcoin/bitcoin/pull/33890#issuecomment-3547936775)
@TheBlueMatt do you know of any merged mining open source projects and whether the approach here would make sense for them?

In https://github.com/stratum-mining/sv2-spec/issues/167#issuecomment-3547519952 you mention that a potential downside is that it increases the potential number of distinct templates, making caching harder.

💬 instagibbs commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#issuecomment-3547940477)
reACK b1581924a79e120f166719943646484ba00ff21b

`git range-diff master 7defbc7dc6155dabfab6a0ccddac69260d6d2d54 b1581924a79e120f166719943646484ba00ff21b`

⚠️ fanquake opened an issue: "29.x depends: fallback server missing capnp downloads"
(https://github.com/bitcoin/bitcoin/issues/33901)
https://github.com/bitcoin/bitcoin/actions/runs/19464722758/job/55696959090#step:9:2030:
```bash
Fetching capnproto-c++-1.2.0.tar.gz from https://capnproto.org/
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 15 0 0
...

💬 stickies-v commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538486498)
> We will upload the new SDK before this PR is merged (leaving the existing one in place), I don't think we need interim code changes here.

Yeah that's what I meant, but I now see how my phrasing was ambiguous. The "temporary" referred to having both versions on the server, until the gz is removed after this PR is merged. Thanks.

💬 willcl-ark commented on pull request "guix: produce a `-static-pie` bitcoind":
(https://github.com/bitcoin/bitcoin/pull/25573#issuecomment-3547964609)
Ah OK I think I might understand better now. Both systems I tested on include `files` and `dns` backends as part of `nsswitch.conf` (line starting with `hosts: `):

```bash
# alpine Container

x86_64-linux-gnu/bitcoin-84d3c4d14e70/bin on  pr-25573 [$] via ❄️ impure (nix-shell-env)
❯ cat /etc/nsswitch.conf
passwd: files systemd
group: files [success=merge] systemd
shadow: files systemd
sudoers: files

hosts: mymachines mdns4_minimal [NOTFOUND=return] files myhostname
...

💬 maflcko commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538502098)
i think the gz will be needed for old release branches?

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538507249)
Yea, the `.tar.gz` will be left as-is.

💬 stickies-v commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#issuecomment-3548014491)
ACK 5513cd0941a2300c0b78758d980ef5eee5079b4c once the new .tar SDK is uploaded

💬 maflcko commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-3548048120)
For reference, inside GDB, the following worked for me:

```
(gdb) set substitute-path ./ /path/to/project/root/src
```

*Not* using the (outdated?) gdbinit advice:

```
set substitute-path ./src /path/to/project/root/src
```

As an alternative, i could use debugedit:

```
debugedit --base-dir ./ --dest-dir /path/to/project/root/src bld-cmake/bin/test_kernel

💬 maflcko commented on issue "callgrind_annotate broken after cmake migration?":
(https://github.com/bitcoin/bitcoin/issues/31957#issuecomment-3548048725)
Ah, looks like this is related to the prefix-map and the following workaround fixes it:

```diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index f264acc..9ed5b46 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -488,12 +488,6 @@ try_append_cxx_flags("-fno-extended-identifiers" TARGET core_interface SKIP_LINK
# which can cause issues with coverage builds, particularly when using
# Clang in the OSS-Fuzz environment due to its use of other options
# and a third party script, or with GCC.
-
...

💬 roconnor-blockstream commented on issue "Standardness policy rules for legacy Multisig script is incoherent":
(https://github.com/bitcoin/bitcoin/issues/33882#issuecomment-3548052465)
> Solver() calls MatchMultisig() which invokes num_keys = GetScriptNuymber(opcode, data, required_sigs, MAX_PUBKEYS_PER_MULTISIG).

This checking m ≤ n behaviour in the Solver seems to have been added in #13194. However this wouldn't count as soft-confiscations because multisigs with m > n are presumably unspendable anways.

> What we support by consensus matches the (earlier) ANSI X9.62-1998 standard

Ah, I was not aware of this.

I wouldn't object to dropping the hybrid key protections. I pr
...

💬 maflcko commented on issue "callgrind_annotate broken after cmake migration?":
(https://github.com/bitcoin/bitcoin/issues/31957#issuecomment-3548070707)
Maybe the prefix-map can be disabled by default or an option could be added to disable it, or it could be disabled on `-DWITH_CCACHE=NO`, as there is no need for it then?

💬 waketraindev commented on pull request "net: Decouple `CConnman::GetAddresses` from `CNode`":
(https://github.com/bitcoin/bitcoin/pull/33900#issuecomment-3548073525)
> it probably makes sense to check if those refactors are in line with the Net Split WG (ref https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-11-13_16_00.log.html and the coredev meeting notes).
>
> Otherwise, this may be touched again soon after.



> it probably makes sense to check if those refactors are in line with the Net Split WG (ref https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-11-13_16_00.log.html and the coredev meeting notes).
>
> Otherwise, this ma
...

💬 waketraindev commented on pull request "net: Decouple `CConnman::GetAddresses` from `CNode`":
(https://github.com/bitcoin/bitcoin/pull/33900#issuecomment-3548115837)
@theuni is this refactor okay with you?

📝 maflcko converted_to_draft a pull request: "ci: Call docker exec from Python script to fix word splitting"
(https://github.com/bitcoin/bitcoin/pull/33732)
The remaining `ci/test/02_run_container.sh` is fine, but has a bunch of shellcheck SC2086 word splitting violations.

This is fine currently, because the only place that needed them had additional escaping, and all other commands happened to split fine on spaces.

However, this may change in the future. So fix it now, by rewriting it in Python, which is recommended in the dev notes.

📝 willcl-ark opened a pull request: "Document compiler configuration for native depends packages"
(https://github.com/bitcoin/bitcoin/pull/33902)
Fixes: #33859

Previously one had to read the Makefile (and various *.mk configuration
files) to see how to correctly override CC and CXX when building native
depends packages.

Detail this in README.md to make it clearer.

🤔 hebasto reviewed a pull request: "Document compiler configuration for native depends packages"
(https://github.com/bitcoin/bitcoin/pull/33902#pullrequestreview-3478388624)
Concept ACK. Thanks!