💬 djkazic commented on pull request "guix: update per-host disk-space estimates in build gate":
(https://github.com/bitcoin/bitcoin/pull/33889#discussion_r2538317201)
@maflcko I proposed the changes to the build gates by just running a build and checking before/after snapshots of disk usage. Do we need more detailed info like tracking which files the extra disk space use comes from?

💬 djkazic commented on pull request "guix: update per-host disk-space estimates in build gate":
(https://github.com/bitcoin/bitcoin/pull/33889#discussion_r2538322036)
I've updated my PR description to be more in line with our discussions here.

👍 stickies-v approved a pull request: "contrib: turn off compression of macOS SDK to fix determinism (across distros)"
(https://github.com/bitcoin/bitcoin/pull/32009#pullrequestreview-3477969031)
tACK 5513cd0941a2300c0b78758d980ef5eee5079b4c

Determinism across Python versions (3.10-3.14) is now restored on my machine. New approach of just avoiding gzip entirely seems straightforward and preferable.

💬 stickies-v commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538362360)
The CI script is still using the `.tar.gz` name: https://github.com/bitcoin/bitcoin/blob/2444488f6ad32dcbbed51a73cd4f59ff3a239e32/ci/test/01_base_install.sh#L93

Perhaps we can temporarily add both the `.tar.gz` and `.tar` files to the `SDK_URL` and update all of this in one go?

💬 stickies-v commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538309245)
nit: could be cleaned up a bit more

<details>
<summary>git diff on 5513cd0941</summary>

```diff
diff --git a/contrib/macdeploy/gen-sdk b/contrib/macdeploy/gen-sdk
index 0cfd2b1379..426d82e46c 100755
--- a/contrib/macdeploy/gen-sdk
+++ b/contrib/macdeploy/gen-sdk
@@ -2,9 +2,7 @@
import argparse
import plistlib
import pathlib
-import sys
import tarfile
-import gzip
import os
import contextlib

@@ -23,7 +21,7 @@ def run():
description=__doc__, formatter_class=
...

💬 maflcko commented on pull request "net: Decouple `CConnman::GetAddresses` from `CNode`":
(https://github.com/bitcoin/bitcoin/pull/33900#issuecomment-3547819287)
it probably makes sense to check if those refactors are in line with the Net Split WG (ref https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-11-13_16_00.log.html and the coredev meeting notes).

Otherwise, this may be touched again soon after.

💬 maflcko commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538390511)
Not sure it this is possible, but if the file was renamed, the existing linters will pick up and lint this file:

```
git mv ./contrib/macdeploy/gen-sdk ./contrib/macdeploy/gen-sdk.py

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538402920)
> Perhaps we can temporarily add both the

We will upload the new SDK before this PR is merged (leaving the existing one in place), I don't think we need interim code changes here.

💬 m3dwards commented on pull request "guix: use GCC 14.3.0 over 13.3.0":
(https://github.com/bitcoin/bitcoin/pull/33775#issuecomment-3547873246)
As I think we expected I got slightly different results on an x86 guix build for windows:

```shell
x86_64
a80099915046f4771235180303b1c92664d36c8cb1564e0e8afc410d3a5eec19 guix-build-8ebf8d35eb1c/output/aarch64-linux-gnu/SHA256SUMS.part
1c3b7cd6548ba04ce58c3d8c7645941fd6cdda313d21f171d0ce10067e11087b guix-build-8ebf8d35eb1c/output/aarch64-linux-gnu/bitcoin-8ebf8d35eb1c-aarch64-linux-gnu-debug.tar.gz
e3738b32f546e48dca9a1e1adb63349c206d11a6528c73f639701e3d376dabe3 guix-build-8ebf8d35eb1c
...

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538446734)
Have renamed to `gen-sdk.py`. Tested that the linter works locally by reintroduing rogue `import time`.

💬 yuvicc commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#issuecomment-3547905576)
Updated commit message an PR description to better reflect the changes and intention as suggested by @TheCharlatan @stickies-v.

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538447512)
Took the rest of the suggestions.

💬 Sjors commented on pull request "mining: add requestedOutputs field, e.g. for merged mining":
(https://github.com/bitcoin/bitcoin/pull/33890#issuecomment-3547936775)
@TheBlueMatt do you know of any merged mining open source projects and whether the approach here would make sense for them?

In https://github.com/stratum-mining/sv2-spec/issues/167#issuecomment-3547519952 you mention that a potential downside is that it increases the potential number of distinct templates, making caching harder.

💬 instagibbs commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#issuecomment-3547940477)
reACK b1581924a79e120f166719943646484ba00ff21b

`git range-diff master 7defbc7dc6155dabfab6a0ccddac69260d6d2d54 b1581924a79e120f166719943646484ba00ff21b`

⚠️ fanquake opened an issue: "29.x depends: fallback server missing capnp downloads"
(https://github.com/bitcoin/bitcoin/issues/33901)
https://github.com/bitcoin/bitcoin/actions/runs/19464722758/job/55696959090#step:9:2030:
```bash
Fetching capnproto-c++-1.2.0.tar.gz from https://capnproto.org/
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 15 0 0
...

💬 stickies-v commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538486498)
> We will upload the new SDK before this PR is merged (leaving the existing one in place), I don't think we need interim code changes here.

Yeah that's what I meant, but I now see how my phrasing was ambiguous. The "temporary" referred to having both versions on the server, until the gz is removed after this PR is merged. Thanks.

💬 willcl-ark commented on pull request "guix: produce a `-static-pie` bitcoind":
(https://github.com/bitcoin/bitcoin/pull/25573#issuecomment-3547964609)
Ah OK I think I might understand better now. Both systems I tested on include `files` and `dns` backends as part of `nsswitch.conf` (line starting with `hosts: `):

```bash
# alpine Container

x86_64-linux-gnu/bitcoin-84d3c4d14e70/bin on  pr-25573 [$] via ❄️ impure (nix-shell-env)
❯ cat /etc/nsswitch.conf
passwd: files systemd
group: files [success=merge] systemd
shadow: files systemd
sudoers: files

hosts: mymachines mdns4_minimal [NOTFOUND=return] files myhostname
...

💬 maflcko commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538502098)
i think the gz will be needed for old release branches?

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#discussion_r2538507249)
Yea, the `.tar.gz` will be left as-is.

💬 stickies-v commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#issuecomment-3548014491)
ACK 5513cd0941a2300c0b78758d980ef5eee5079b4c once the new .tar SDK is uploaded