💬 stickies-v commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#discussion_r2537688942)
It doesn't return a header, though. I'm not saying we shouldn't add it, but it is orthogonal to the PR, and it is bundled in an unrelated commit without motivation. I think doing this separately makes more sense, I'd like to think more about how we want to expose this functionality, whereas the actual block header changes are quite straightforward and mechanistic.

💬 waketraindev commented on pull request "test, refactor: Embedded ASMap [1/3]: Selected minor preparatory work":
(https://github.com/bitcoin/bitcoin/pull/33026#discussion_r2537716651)
> The call should be fully optimized out anyway, no?

I sure hope so!
It's a test-only code, so not a big deal.

💬 hebasto commented on issue "guix build fails on RISC-V due to python-py-cpuinfo test failure":
(https://github.com/bitcoin/bitcoin/issues/33873#issuecomment-3547137380)
> > Which kernel are you running? `5.10.113-scw1` here. (Apparently released `Wed, 27 Apr 2022`. That's ancient especially in RISC-V land!)
>
> ```
> # uname -srv
> Linux 5.10.113-scw1 #1 SMP PREEMPT Fri Jul 12 15:31:22 UTC 2024
> ```

I've just checked out Fedora 40:
```
# uname -srv
Linux 5.10.113-scw1 #1 SMP PREEMPT Mon Jul 15 10:10:04 UTC 2024
```

👍 stickies-v approved a pull request: "clang-format: Set InsertNewlineAtEOF: true"
(https://github.com/bitcoin/bitcoin/pull/33896#pullrequestreview-3477255388)
ACK fa1bf6818f0910f997e5235a197ff51f2e18780d

🚀 fanquake merged a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33611)

💬 TheCharlatan commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#discussion_r2537757275)
I think it should be part of this PR. We should not make changes to the API if we don't know how completing simple tasks will look like in the future. If there are doubts about how this should be exposed, this seems like the correct place to voice them and come up with something better. Would you be more on favour if it returned the header directly instead of having to retrieve the header from the entry?

👍 hebasto approved a pull request: "clang-format: Set InsertNewlineAtEOF: true"
(https://github.com/bitcoin/bitcoin/pull/33896#pullrequestreview-3477293559)
ACK fa1bf6818f0910f997e5235a197ff51f2e18780d.

💬 willcl-ark commented on pull request "guix: produce a `-static-pie` bitcoind":
(https://github.com/bitcoin/bitcoin/pull/25573#issuecomment-3547222727)
> > ;; --enable-static-nss isn't used yet, because it has been broken
> > ;; since 2.33: [sourceware.org/bugzilla/show_bug.cgi?id=27959](https://sourceware.org/bugzilla/show_bug.cgi?id=27959).
>
> What are the exact implications of this? I guix-built this branch and loaded it into a scratch docker container and the dns seeds were connected to and loaded fine. Is this coming from my host system perhaps, even inside a scratch container?
>
> I also tested the binary on alpine and it appeared
...

💬 Sjors commented on issue "External signer: in case of error shows only "External signer failure"":
(https://github.com/bitcoin/bitcoin/issues/31004#issuecomment-3547259649)
Most of the action is here:
- https://github.com/bitcoin/bitcoin/blob/master/src/external_signer.cpp
- https://github.com/bitcoin/bitcoin/blob/master/src/common/run_command.cpp

💬 Sjors commented on pull request "doc: update interface, --stdin flag, `signtx` (#31005)":
(https://github.com/bitcoin/bitcoin/pull/33765#discussion_r2537840004)
Most of the action is here:
- https://github.com/bitcoin/bitcoin/blob/master/src/external_signer.cpp
- https://github.com/bitcoin/bitcoin/blob/master/src/common/run_command.cpp

🤔 janb84 reviewed a pull request: "doc: Improve CI docs on env and qemu-user-static"
(https://github.com/bitcoin/bitcoin/pull/33887#pullrequestreview-3477305156)
Concept ACK f8d83ee4d631c95ef6e222d7868bfa9e28b66e05

This PR improves the CI documentation, to clarify certain aspects of the CI which raise questions time to time. (see #31199). I would say that the additional information in this PR would stop some questions from being asked. The information provided is (the docker part) is non-trivial to me, and the importance of `env-i` can be overlooked so the additional information is welcome.

NIT: Small grammar suggestion.

💬 janb84 commented on pull request "doc: Improve CI docs on env and qemu-user-static":
(https://github.com/bitcoin/bitcoin/pull/33887#discussion_r2537769758)
NIT: small grammar suggestion

```suggestion
It is recommended to run the CI system in a clean environment. The `env -i` command
below ensures that *only* specified environment variables are propagated into the local CI.
To run the test stage with a specific configuration:
```

💬 Sjors commented on issue "External signer: in case of error shows only "External signer failure"":
(https://github.com/bitcoin/bitcoin/issues/31004#issuecomment-3547268112)
Unless you're going to open a PR to improve it yourself, probably nobody else will :-)

I can't close it though, only you or the maintainers can.

✅ pinheadmz closed an issue: "External signer: in case of error shows only "External signer failure""
(https://github.com/bitcoin/bitcoin/issues/31004)

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#issuecomment-3547313774)
I think this could actually be a fine solution, and the additional changes needed are minimal, so I've pushed that up. The hash of the tarball using this branch is `95b00dc41fa090747dc0a7907a5031a2fcb2d7f95c9584ba6bccdb99b6e3d498`.

💬 stickies-v commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#discussion_r2537904473)
> We should not make changes to the API if we don't know how completing simple tasks will look like in the future.

I agree with that, but I think I'm misunderstanding the purpose of this PR, then. Adding block headers to the API seems like a pretty straightforward addition to the existing API for which imo just the additional introspection ability seems worthwhile, and that's how I was reviewing it. From your messages, it seems like the actual goal is to implement a specific use case, but tha
...

💬 Sjors commented on pull request "miner: drop dummy extraNonce in coinbase scriptSig for templates requested via IPC":
(https://github.com/bitcoin/bitcoin/pull/32420#issuecomment-3547327475)
Rebased due after #33745 due to import conflict in the test. Also fixed comment typo.

💬 Sjors commented on pull request "ipc: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#issuecomment-3547353597)
re-ACK 2cb5e6472c8c0109390258c298915dd4011f0292

Trivial rebase after #30595 added `libbitcoinkernel (experimental)` to the CMake summary.

💬 plebhash commented on issue "IPC via TCP Sockets":
(https://github.com/bitcoin/bitcoin/issues/32802#issuecomment-3547392323)
apparently @lucasbalieiro was able to ship https://github.com/stratum-mining/sv2-apps/pull/85 without running into the Docker challenges I originally described as the motivation for IPC via TCP here... I'm yet to dive into it and figure out whether I had any blindspots when opened this issue here

when I asked about encryption I didn't really have the Docker setup in mind... I was just curious about potential use-cases of IPC over TCP

💬 fanquake commented on pull request "contrib: turn off compression of macOS SDK to fix determinism (across distros)":
(https://github.com/bitcoin/bitcoin/pull/32009#issuecomment-3547440518)
Guix Build (aarch64):
```bash
3bd9c90945da34a1398beceb2474401a486a6f3436bb4a12a573bdfa38df6d62 guix-build-5513cd0941a2/output/arm64-apple-darwin/SHA256SUMS.part
e78e73b65107c95fd4199f5a354471e8f61165c51ee7602b775a59093cf345f5 guix-build-5513cd0941a2/output/arm64-apple-darwin/bitcoin-5513cd0941a2-arm64-apple-darwin-codesigning.tar.gz
3fee841b5625963dda994f68035e2d87decbbce4df666485e76f42fbe2b7f61b guix-build-5513cd0941a2/output/arm64-apple-darwin/bitcoin-5513cd0941a2-arm64-apple-darwin-uns
...