💬 andrewtoth commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2532090415)
Ahh I didn't test these suggestions before submitting. I wasn't sure if we could have that annotation after a catch block. Please ignore.

💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#issuecomment-3538991279)
Thanks @andrewtoth!
I have applied the patch below on e14650967d, but it seems that it didn't improve the following benchmark performance (reading the smallest possible amount of data from a block):
```
$ BLOCKHASH=00000000000000000001878540abd91b4dd591287ee58de73a163b698748f23b
$ ab -q -k -c 1 -n 100000 "http://localhost:8332/rest/blockpart/$BLOCK.bin?offset=0&size=1"
```
<details>

<summary> Patch </summary>

```diff
diff --git a/src/node/blockstorage.cpp b/src/node/blockstorage.cp
...

⚠️ alexandre-leng opened an issue: "Improve Bitcoin’s resilience to large-scale power grid failures and Carrington-type solar storms"
(https://github.com/bitcoin/bitcoin/issues/33885)
### Please describe the feature you'd like to see added.

Hi,
This is a feature request to explore options for improving Bitcoin’s resilience during large-scale, long-duration power or network outages (e.g., Carrington-type solar storms).
Such events could isolate regions for days or weeks, causing separate chain histories that later need reconciliation.

The request is to consider small, consensus-compatible improvements in documentation, defaults, or optional tools to help nodes operate on deg
...

💬 alexandre-leng commented on issue "Improve Bitcoin’s resilience to large-scale power grid failures and Carrington-type solar storms":
(https://github.com/bitcoin/bitcoin/issues/33885#issuecomment-3539127615)
This is just a starting point to spark some thought.

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2531999067)
Addressed in #33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532002918)
Addressed in https://github.com/bitcoin/bitcoin/pull/33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532004290)
Renamed parameter in https://github.com/bitcoin/bitcoin/pull/33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532010522)
Addressed in https://github.com/bitcoin/bitcoin/pull/33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532010167)
Probably not a bad idea in principle but the nature of the test changes with your suggested code, so I would like to manage the PR scope a bit and keep this for a follow-up.

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532054758)
Addressed in #33878

> (Also removes data from file-global scope).

Not a problem because of the anonymous namespace I think.

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532014755)
Addressed in https://github.com/bitcoin/bitcoin/pull/33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532014382)
I have been working on improved documentation. Please check the new commit in https://github.com/bitcoin/bitcoin/pull/33878 to see if that is fixing this completely.

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532224663)
Addressed in https://github.com/bitcoin/bitcoin/pull/33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r2532022415)
Done in #33878

💬 fjahr commented on pull request "Embedded ASMap [3/3]: Build binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#issuecomment-3539393301)
All the feedback that applied to https://github.com/bitcoin/bitcoin/pull/33878 has now been addressed there. I am marking these comments as resolved and if there are further notes on these please move the conversation over there. Thanks!

💬 fjahr commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#issuecomment-3539395607)
All the feedback from #28792 that applied to the commits here has been addressed here now.

💬 fjahr commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2532262781)
Thank you for the quick feedback! Added a small paragraph on the bit-packed format in the introduction comment at the top.

💬 fjahr commented on issue "interface_ipc functional test failing in CI":
(https://github.com/bitcoin/bitcoin/issues/33884#issuecomment-3539397600)
I have opened #33880 to address this.

💬 starius commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-3539405058)
> Are you still working on this?

Yes. I'm addressing all the feedback. I'll publish new version soon.

✅ pinheadmz closed an issue: "Improve Bitcoin’s resilience to large-scale power grid failures and Carrington-type solar storms"
(https://github.com/bitcoin/bitcoin/issues/33885)