💬 maflcko commented on pull request "build: add `-W*-whitespace`":
(https://github.com/bitcoin/bitcoin/pull/32482#issuecomment-3522287508)
(possibly it reproduced only using GCC-16 nightly)

✅ glozow closed an issue: "GetSerializeSize's return type should not be platform dependent"
(https://github.com/bitcoin/bitcoin/issues/33709)

🚀 glozow merged a pull request: "refactor: Return uint64_t from GetSerializeSize"
(https://github.com/bitcoin/bitcoin/pull/33724)

🤔 glozow reviewed a pull request: "test: add option to skip large re-org test in feature_block"
(https://github.com/bitcoin/bitcoin/pull/33003#pullrequestreview-3453870259)
lgtm ACK 8810642b571e1d8482375e962a1129b691d5d226

✅ glozow closed an issue: "test: break `feature_block` into subtests?"
(https://github.com/bitcoin/bitcoin/issues/32877)

🚀 glozow merged a pull request: "test: add option to skip large re-org test in feature_block"
(https://github.com/bitcoin/bitcoin/pull/33003)

💬 jonatack commented on pull request "doc: document fingerprinting risk when operating node on multiple networks":
(https://github.com/bitcoin/bitcoin/pull/33750#discussion_r2518649330)
> The purpose of this PR is to more explicitly inform people

That is why I suggest providing actionable steps in this documentation for those who are concerned.

💬 glozow commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2518653525)
Marking this conversation resolved, please unresolve if that's a misinterpretation

💬 jonatack commented on pull request "doc: document fingerprinting risk when operating node on multiple networks":
(https://github.com/bitcoin/bitcoin/pull/33750#discussion_r2518658453)
> Perhaps clarify that in the documentation, as those that do run over both Tor and I2P could conclude that they risk being fingerprinted in the same way as described here.

Would be good to address this as well.

🚀 glozow merged a pull request: "mining: check witness commitment in submitBlock"
(https://github.com/bitcoin/bitcoin/pull/33745)

💬 kevkevinpal commented on pull request "test: add unit test coverage for the empty leaves path in MerkleComputation":
(https://github.com/bitcoin/bitcoin/pull/33858#issuecomment-3522419951)
ACK [ffcae82](https://github.com/bitcoin/bitcoin/pull/33858/commits/ffcae82a68104c1992964b26c592b62cbca391bf)

According to corecheck it looks like there was an increase in coverage
https://corecheck.dev/bitcoin/bitcoin/pulls/33858

📝 hebasto opened a pull request: "build: Bump VS minimum supported version to 18.0"
(https://github.com/bitcoin/bitcoin/pull/33861)
The new [VS 18.0](https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-notes) release includes numerous bug fixes.

Drafted pending:
1. [Availability](https://github.com/actions/runner-images/issues/13291) in GHA.
2. The inclusion of [CMake 4.2](https://cmake.org/cmake/help/v4.2/generator/Visual%20Studio%2018%202026.html) as part of the Visual Studio installation (currently 4.1.1 is shipped).

🚀 glozow merged a pull request: "init: Fix Ctrl-C shutdown hangs during wait calls"
(https://github.com/bitcoin/bitcoin/pull/33511)

💬 hebasto commented on pull request "refactor: Remove workaround for resolved MSVC bug":
(https://github.com/bitcoin/bitcoin/pull/32552#issuecomment-3522471746)
Another attempt in https://github.com/bitcoin/bitcoin/pull/33861.

💬 mzumsande commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2518738990)
Yes, makes sense, I'll add that soon.

🤔 hebasto reviewed a pull request: "depends: drop Qt patches"
(https://github.com/bitcoin/bitcoin/pull/33860#pullrequestreview-3454019618)
Concept ACK. Thanks!

💬 theStack commented on pull request "tests: Add witness commitment if we have a witness transaction in `FullBlockTest.update_block()`":
(https://github.com/bitcoin/bitcoin/pull/31823#discussion_r2518748320)
> It is my understanding that the `feature_block.py` test suites turns on [`-acceptnonstdtxn=1`](https://github.com/bitcoin/bitcoin/blob/3c1f72a36700271c7c1293383549c3be29f28edb/test/functional/feature_block.py#L90) which turns off this policy check. Thus we don't receive any error message when submitting the transaction to the mempool.
>

I assume you are referring to the functional test `p2p_invalid_tx.py` rather than `feature_block.py`, as the latter only sends blocks to the node rather t
...

💬 hebasto commented on pull request "build: add `-W*-whitespace`":
(https://github.com/bitcoin/bitcoin/pull/32482#issuecomment-3522533346)
> Not sure how to reproduce locally, but this seems to be failing:
>
> ```
> /__w/bitcoin-core-nightly/bitcoin-core-nightly/src/clientversion.cpp:33:79: error: trailing whitespace [-Werror=trailing-whitespace=]
> 33 | //! git will put "#define GIT_COMMIT_ID ..." on the next line inside archives.
> ```
>
> https://github.com/maflcko/bitcoin-core-nightly/actions/runs/19297432422/job/55182808327#step:6:405

Does the following patch help:
```diff
--- a/src/clientversion.cpp
+++ b/sr
...

💬 kevkevinpal commented on issue "`test_kernel` fails to build on Ubuntu 22.04":
(https://github.com/bitcoin/bitcoin/issues/33846#issuecomment-3522551720)
Just tested on master commit d4e2a458330512c227b475531e1617d25366be54 and the build still failed with this docker file

```
FROM ubuntu:22.04

RUN apt update
RUN apt install -y git build-essential cmake pkgconf python3 libevent-dev libboost-dev libsqlite3-dev

COPY . /bitcoin
WORKDIR /bitcoin

RUN cmake -B build -DENABLE_IPC=OFF -DBUILD_KERNEL_LIB=ON
RUN cmake --build build -j1
```

are we sure https://github.com/bitcoin/bitcoin/pull/33853 closes this issue? @fanquake

🤔 hebasto reviewed a pull request: "kernel: Allow null arguments for serialized data"
(https://github.com/bitcoin/bitcoin/pull/33853#pullrequestreview-3454086839)
Post-merge ACK.