💬 TheCharlatan commented on pull request "(RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store":
(https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-3521999252)
Rebased a5a8bff198f9f641c10e159fa3cc51757d8f69f6 -> ef1f96134098e73b47bfc988d878422917ceac1d ([blocktreestore_7](https://github.com/TheCharlatan/bitcoin/tree/blocktreestore_7) -> [blocktreestore_8](https://github.com/TheCharlatan/bitcoin/tree/blocktreestore_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/blocktreestore_7..blocktreestore_8))

💬 fanquake commented on pull request "guix: build `bitcoin-qt` with static libxcb & utils":
(https://github.com/bitcoin/bitcoin/pull/33537#issuecomment-3522030114)
Fixed the linking issue with `qdbusviewer`, by just disabling building that tool.

💬 mmortal03 commented on issue "Option to use dark theme for Windows":
(https://github.com/bitcoin-core/gui/issues/378#issuecomment-3522060989)
> The issue has been resolved in [bitcoin/bitcoin#30997](https://github.com/bitcoin/bitcoin/pull/30997), as Qt 6.7.3 allows an app to use the dark system palette on Windows.
>
> Compare screenshots:

Based on my testing, this only works on Windows 11 currently.

To get it working on Windows 10, it would need the GUI to use one of the other Qt styles, other than what they have it default to for Windows 10, which is called the "windowsvista" style. See here: https://forum.qt.io/topic/163222/dark-
...

💬 janb84 commented on pull request "guix: use GCC 14.3.0 over 13.3.0":
(https://github.com/bitcoin/bitcoin/pull/33775#issuecomment-3522064022)
Same got build failure (2x) at 758da5a5732433807f1d9c8f043de934982218ab

```sh
/ 'build' phasenote: keeping build directory `/tmp/guix-build-gcc-cross-x86_64-w64-mingw32-14.3.0.drv-0'
builder for `/gnu/store/akfhrz7dsfj133vqrdr79ipdhgvc5352-gcc-cross-x86_64-w64-mingw32-14.3.0.drv' failed with 1
build of /gnu/store/akfhrz7dsfj133vqrdr79ipdhgvc5352-gcc-cross-x86_64-w64-mingw32-14.3.0.drv failed
View build log at '/var/log/guix/drvs/ak/fhrz7dsfj133vqrdr79ipdhgvc5352-gcc-cross-x86_64-w64-mingw
...

👋 fanquake's pull request is ready for review: "guix: build `bitcoin-qt` with static libxcb & utils"
(https://github.com/bitcoin/bitcoin/pull/33537)

💬 fanquake commented on pull request "guix: build `bitcoin-qt` with static libxcb & utils":
(https://github.com/bitcoin/bitcoin/pull/33537#issuecomment-3522077989)
I think this is now reviewable / testable. I've updated our Guix symbol check to remove all `libxcb*` entries. The remaining dynamic Qt deps are Freetype, Fontconfig and the dynamic loader.

🤔 fjahr reviewed a pull request: "init: Require explicit -asmap filename"
(https://github.com/bitcoin/bitcoin/pull/33770#pullrequestreview-3453538980)
Approach ACK

While not everyone I asked has gotten back to me yet, almost all responders did already use an explicit file path and the few that had used the option of the default file had similar sentiment to @sipa.

The file should probably also be dropped from `files.md` then since there is nothing special about that name/location anymore, e.g. https://github.com/fjahr/bitcoin/commit/e0283bb8c133c8cae19c48c8d78cfe95dab664ee

💬 fjahr commented on pull request "init: Require explicit -asmap filename":
(https://github.com/bitcoin/bitcoin/pull/33770#discussion_r2518375913)
Effectively the arg is not allowed anymore without a path to a file, so I think it would make sense to return an explicit error here which gives the user that feedback. The current error for the empty `-asmap` is "Could not find asmap file /path/to/datadir" which suggests there still is a default location where the file (without a name) could not be found.

💬 fjahr commented on pull request "init: Require explicit -asmap filename":
(https://github.com/bitcoin/bitcoin/pull/33770#discussion_r2518380662)
nit: I was going to say that the unspecified file and the missing file test could be deduplicated since they are currently similar but I think the better change would be to have an explicit error message for the empty `-asmap` arg.

💬 instagibbs commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2518433916)
double-checked test that it would go through properly funded (works):

```
diff --git a/test/functional/feature_rbf.py b/test/functional/feature_rbf.py
index 4b2c89f3d9..10e3239a33 100755
--- a/test/functional/feature_rbf.py
+++ b/test/functional/feature_rbf.py
@@ -346,4 +346,7 @@ class ReplaceByFeeTest(BitcoinTestFramework):
assert_raises_rpc_error(-26, "insufficient feerate: does not improve feerate diagram", self.nodes[0].sendrawtransaction, tx_replacement['hex'])

+
...

💬 laanwj commented on pull request "chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us":
(https://github.com/bitcoin/bitcoin/pull/33723#issuecomment-3522121392)
ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e

i personally haven't trusted luke-jr to run important bitcoin core infrastructure since he hijacked the Transifex for Knots, removing the other maintainer's admin access. He could potentially use the DNS seed in some way to further Knots, or in a way harmful to this project. Or might already be doing so.

Recent developments, furthering bad blood between the projects, haven't improved my sentiment on this.

In terms of risk minimization, it mak
...

✅ fanquake closed an issue: "dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us appears to be violating DNS seed policy"
(https://github.com/bitcoin/bitcoin/issues/33734)

💬 fanquake commented on issue "dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us appears to be violating DNS seed policy":
(https://github.com/bitcoin/bitcoin/issues/33734#issuecomment-3522141208)
Closing for now.

💬 instagibbs commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2518470746)
was marked as hidden now

🚀 fanquake merged a pull request: "kernel: Allow null arguments for serialized data"
(https://github.com/bitcoin/bitcoin/pull/33853)

👍 instagibbs approved a pull request: "Cluster mempool"
(https://github.com/bitcoin/bitcoin/pull/33629#pullrequestreview-3453677219)
reACK 5b5a41b94396c9171d1a8ce076b92ac0ade54c66

Lock changes seem like a maximally sensible tweak deferring to future improvements to more review. All other changes follow suggestions by reviewers.

`git range-diff master ed23b4537ae8a8a814738909fe9a84c548f2855d 5b5a41b94396c9171d1a8ce076b92ac0ade54c66`

💬 willcl-ark commented on pull request "guix: use GCC 14.3.0 over 13.3.0":
(https://github.com/bitcoin/bitcoin/pull/33775#issuecomment-3522177104)
Without the new flags I get:

```
core/worktrees/pr-33775 on  pr-33775 [$] via △ v3.31.6 via 🐍 v3.13.5 via ❄️ impure (nix-shell-env) took 3h44m19s
❯ uname -m; find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
36feb0fb0ca11e5c17e01704b2c0c2cf6e23f59a62f0dd1d76819db5dc9fc1a5 guix-build-fc564434b8fb/output/aarch64-linux-gnu/SHA256SUMS.part
1b88fb5d39140df4b14e67638f02bb07ff2d7525b7ad812f783b4c0f87531908 guix-buil
...

💬 TheCharlatan commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3522227364)
Rebased 5988c7172406e3caca32fc78c011d878a1abdf1e -> 6493e47fd8d32c030d553f791caa48fcdb848c0b ([spendblock_14](https://github.com/TheCharlatan/bitcoin/tree/spendblock_14) -> [spendblock_15](https://github.com/TheCharlatan/bitcoin/tree/spendblock_15), [compare](https://github.com/TheCharlatan/bitcoin/compare/spendblock_14..spendblock_15))

📝 fanquake opened a pull request: "depends: drop Qt patches"
(https://github.com/bitcoin/bitcoin/pull/33860)
Drop one patch that was already unused, and one that compilation succeeds without.

💬 maflcko commented on pull request "build: add `-W*-whitespace`":
(https://github.com/bitcoin/bitcoin/pull/32482#issuecomment-3522280482)
Not sure how to reproduce locally, but this seems to be failing:

```
/__w/bitcoin-core-nightly/bitcoin-core-nightly/src/clientversion.cpp:33:79: error: trailing whitespace [-Werror=trailing-whitespace=]
33 | //! git will put "#define GIT_COMMIT_ID ..." on the next line inside archives.
```

https://github.com/maflcko/bitcoin-core-nightly/actions/runs/19297432422/job/55182808314#step:9:403