👍 hebasto approved a pull request: "ci: Use cmake --preset=dev-mode in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/33823#pullrequestreview-3438100683)
ACK fa6db67369fbf9b9f0ec839b898edd7ba8bfe31a, I have reviewed the code and it looks OK.

📝 maflcko opened a pull request: " ci: Enable experimental kernel stuff in most CI tasks "
(https://github.com/bitcoin/bitcoin/pull/33824)
Most of the CI tasks have a long list of stuff that they enable. This makes it hard to see what each CI task is actually running.

Also, most of the CI tasks should probably mimic the `dev-mode` CMake preset and run on as much stuff as possible. Usually, changing the `dev-mode` comes with changing those CI tasks as well in the same commit, which is verbose.

Fix both issues, by basing most CI tasks on the `dev-mode`. In the future, this makes it easier to change the `dev-mode` in a single pl
...

📝 maflcko opened a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825)
Otherwise, the compilation may fail with:


```
/home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:271:14: error: no type named 'exception_ptr' in namespace 'std'; did you mean 'exception'?
271 | std::exception_ptr exception;
| ~~~~~^~~~~~~~~~~~~
| exception
/cxx_build/include/c++/v1/__exception/exception.h:72:33: note: 'exception' declared here
72 | class _LIBCPP_EXPORTED_FROM_ABI exception {
|
...

📝 maflcko converted_to_draft a pull request: "ci: Enable experimental kernel stuff in most CI tasks"
(https://github.com/bitcoin/bitcoin/pull/33824)
Most of the CI tasks have a long list of stuff that they enable. This makes it hard to see what each CI task is actually running.

Also, most of the CI tasks should probably mimic the `dev-mode` CMake preset and run on as much stuff as possible. Usually, changing the `dev-mode` comes with changing those CI tasks as well in the same commit, which is verbose.

Fix both issues, by basing most CI tasks on the `dev-mode`. In the future, this makes it easier to change the `dev-mode` in a single pl
...

💬 maflcko commented on pull request "ci: Enable experimental kernel stuff in most CI tasks":
(https://github.com/bitcoin/bitcoin/pull/33824#issuecomment-3506469571)
Hmm. Looks like this uncovered some errors. I'll circle back next week.

👍 TheCharlatan approved a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825#pullrequestreview-3438301340)
ACK fa1e8d8bad92f5fba2b086d78581df4c8123b098

📝 waketraindev converted_to_draft a pull request: "Prevent re-execution of sensitive commands from console history"
(https://github.com/bitcoin-core/gui/pull/909)
Sensitive RPC commands such as `walletpassphrase` or `createwallet`
may appear in the console history with their arguments redacted. Previously,
these entries could still be re-executed if recalled, potentially causing
unintended actions.

This change prefixes redacted history entries with a leading character(`!`),
marking them as non-executable when called. The console blocks their
execution and informs the user that the command was redacted.
The help text in `help-console` has been upd
...

🤔 hebasto reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3438351299)
My Guix build:
```
x86_64
a3647a46e00124b207263b695d9598cf9fe6c845ea9072c933462dd0e31a0ed9 guix-build-a02282d20c87/output/aarch64-linux-gnu/SHA256SUMS.part
6e3b9a2e39e207d98c347ccc0a81dfc6c79484befa5dbbeaaccdd0b44b759e99 guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu-debug.tar.gz
827f5c070c2ee3c8e1eb96cfd6f05551e4a69a00e422f808c15840026c7a27fc guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu.tar.gz
0614c466cb38f98
...

🤔 hebasto reviewed a pull request: "guix: build for Linux HOSTS with `-static-libgcc`"
(https://github.com/bitcoin/bitcoin/pull/33181#pullrequestreview-3438354635)
> Still waiting for my Guix build on RISC-V machine.

Here are intermediate results:
```
riscv64
b3870a41bd0bec7dd6be11f5fbfc31f2e3693b4a5aaba388035a26fe5ca87c79 guix-build-f06c6e189831/output/dist-archive/bitcoin-f06c6e189831.tar.gz
fdd0db1fef76e0b1f8eb5eab771a3d9cdfc0af6903fbccc6e256cee777d09d6a guix-build-f06c6e189831/output/x86_64-linux-gnu/SHA256SUMS.part
8625456849e70062d7532915f64d92a467ef58c1b6de3d6880e533995409c150 guix-build-f06c6e189831/output/x86_64-linux-gnu/bitcoin-f06c6e189831-
...

🤔 hebasto reviewed a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825#pullrequestreview-3438418410)
ACK fa1e8d8bad92f5fba2b086d78581df4c8123b098.

[Here](https://github.com/hebasto/bitcoin/commit/11bc5cca61a9edad38d070bd5046355fcf58c7ee#diff-4d05cd02fdce641be603f0f9abcecfeaf76944285d4539ba4bbc40337fa9bbc2) is IWYU's diff based on https://github.com/bitcoin/bitcoin/pull/33810:
```diff
--- a/src/kernel/bitcoinkernel_wrapper.h
+++ b/src/kernel/bitcoinkernel_wrapper.h
@@ -5,12 +5,19 @@
#ifndef BITCOIN_KERNEL_BITCOINKERNEL_WRAPPER_H
#define BITCOIN_KERNEL_BITCOINKERNEL_WRAPPER_H

-#include <kern
...

🤔 yuvicc reviewed a pull request: "kernel: trim Chain interface"
(https://github.com/bitcoin/bitcoin/pull/33820#pullrequestreview-3438421965)
ACK f4b3ba18d9bf3e7c2c55a98f3c3d98129a1fa6e2

This makes sense to me.

🤔 yuvicc reviewed a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825#pullrequestreview-3438422552)
ACK fa1e8d8bad92f5fba2b086d78581df4c8123b098

🚀 hebasto merged a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825)

👍 hebasto approved a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3438443615)
ACK a02282d20c87471a3399e4061c7edad7ecdb391f.

🤔 hebasto reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3438464326)
@151henry151

Could you please also remove the workaround for NetBSD by reverting commit 11115e9aa845d675a88e18e729913f0aaa11e322?

I've tested it on NeBSD 10.1, and can confirm I'm sure it's no longer necessary.

👋 waketraindev's pull request is ready for review: "Prevent re-execution of sensitive commands from console history"
(https://github.com/bitcoin-core/gui/pull/909)

📝 hebasto opened a pull request: "scripted-diff: Remove obsolete comment"
(https://github.com/bitcoin/bitcoin/pull/33826)
The removed comment become obsolete after bitcoin/bitcoin#32697 and bitcoin/bitcoin#32881.

💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#issuecomment-3506722651)
[Added](https://github.com/bitcoin/bitcoin/compare/c30647c4d34c2941696729704854467b30657c43..9a4c016b9c41ad711d7be487d6f450659246af0a) REST API documentation and release notes.

💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2507024695)
Added here:
https://github.com/bitcoin/bitcoin/blob/e14650967dc95da5c10e0d6183b6eac3e8243fe5/src/rest.cpp#L392-L397

💬 l0rinc commented on pull request "scripted-diff: Remove obsolete comment":
(https://github.com/bitcoin/bitcoin/pull/33826#issuecomment-3506770544)
code review ACK 36724205fc1f226d7b5493ed0212c336e7f2ae84

Looks like this is a leftover from [before the cmake migration](https://github.com/bitcoin/bitcoin/commit/6ce50fd9d0ae6850d54bf883e7a7c1bcb6912c5c#diff-7533d479b9e3ad56dcfbf6daaa21317373e8233da5ea13714554115c66057aa2L22-L132).
Checked locally, other Python 3 references seem unrelated.