💬 gmaxwell commented on pull request "validation: reduce persisted UTXO set size by prioritizing positive lookups (RFC)":
(https://github.com/bitcoin/bitcoin/pull/33817#issuecomment-3505120463)
Hm. I don't know we were aware that you could turn off the filters in leveldb-- I thought they were used to also decide what level an entry might be in!

Have you tried to characterize if this opens up any DOS attacks with unconfirmed transactions?

💬 waketraindev commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#discussion_r2505990347)
You’re right, a separate signal/slot wasn’t necessary here. I revisited the implementation, removed both the signal and slot, and consolidated the logic directly into RPCConsole::on_lineEdit_returnPressed, as you suggested, cleaning everything up. Thanks for taking a look at the PR!

💬 waketraindev commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#issuecomment-3505624298)
* Blocking character was changed from '#' to '!' in order to reserve '#' for printing comments such as like bash
* Removed noop slot and signal
* Added alert window when a command starting with ! is entered
* Commands starting with ! don't print, and don't go to history

💬 yuvicc commented on pull request "kernel: Add block header support and validation":
(https://github.com/bitcoin/bitcoin/pull/33822#issuecomment-3506002531)
Fixed some lint errors.

🤔 yuvicc reviewed a pull request: "kernel: Expose `CheckTransaction` consensus validation function"
(https://github.com/bitcoin/bitcoin/pull/33796#pullrequestreview-3437677428)
Approach ACK

Great addition exposing `CheckTransaction` to the kernel API. This will be useful to external users needing context-free transaction validation.

💬 yuvicc commented on pull request "kernel: Expose `CheckTransaction` consensus validation function":
(https://github.com/bitcoin/bitcoin/pull/33796#discussion_r2506321358)
```suggestion
/**
* @brief Run consensus/tx_check::CheckTransaction on a transaction.
*
* Performs context-free consensus validation on a transaction without
* requiring blockchain state.
*
* @param[in] tx The transaction to validate
* @param[out] out_state Pointer to receive the validation state (always set,
* caller must destroy with btck_tx_validation_state_destroy)
* @return 1 if valid, 0 if invalid
*/
```

💬 ArmchairCryptologist commented on issue "dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us appears to be violating DNS seed policy":
(https://github.com/bitcoin/bitcoin/issues/33734#issuecomment-3506113602)
> For the record, the current range of accepted versions is 0.21.1-28.*. If you are observing other versions, it is most likely because the node operator recently upgraded since the last crawl. There are currently 3567 "good" nodes being chosen from for results, which seems more than sufficient for now. (While this doesn't break the policy in any way, maybe it would be about time to expand the scope since 28.x is no longer maintained.)

It seems to me that intentionally configuring your DNS seed
...

💬 big14way commented on issue "ASAN use-after-free in `m_reconnections`":
(https://github.com/bitcoin/bitcoin/issues/33615#issuecomment-3506144248)
@maflcko please assign this issue to me let me fix the bug

💬 big14way commented on issue "Inconsistent CJDNS address handling in Local addresses and AddLocal logs":
(https://github.com/bitcoin/bitcoin/issues/33471#issuecomment-3506148172)
@willcl-ark please assign me this issue i can fix this bug

📝 maflcko opened a pull request: " ci: Use cmake --preset=dev-mode in test-each-commit task "
(https://github.com/bitcoin/bitcoin/pull/33823)
Using the preset should reduce the bloat and need to maintain several places to list the same cmake cache variables.

The only difference should be that `bitcoin-chainstate (experimental)` will be enabled, which seems fast and in line with the goal of the CI task.

* Before: https://github.com/bitcoin/bitcoin/actions/runs/19174075826/job/54814118651#step:8:315
* After: (this pull)

diff:

```diff

👍 danielabrozzoni approved a pull request: "log: avoid collecting `GetSerializeSize` data when compact block logging is disabled"
(https://github.com/bitcoin/bitcoin/pull/33738#pullrequestreview-3437924068)
Code Review ACK 10e0e96e703a40b298b87e9943f85d5189b9e3dc

Code looks good to me, I ran the tests locally, but I didn’t perform any additional testing beyond that.

👍 hebasto approved a pull request: "ci: Use cmake --preset=dev-mode in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/33823#pullrequestreview-3438100683)
ACK fa6db67369fbf9b9f0ec839b898edd7ba8bfe31a, I have reviewed the code and it looks OK.

📝 maflcko opened a pull request: " ci: Enable experimental kernel stuff in most CI tasks "
(https://github.com/bitcoin/bitcoin/pull/33824)
Most of the CI tasks have a long list of stuff that they enable. This makes it hard to see what each CI task is actually running.

Also, most of the CI tasks should probably mimic the `dev-mode` CMake preset and run on as much stuff as possible. Usually, changing the `dev-mode` comes with changing those CI tasks as well in the same commit, which is verbose.

Fix both issues, by basing most CI tasks on the `dev-mode`. In the future, this makes it easier to change the `dev-mode` in a single pl
...

📝 maflcko opened a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825)
Otherwise, the compilation may fail with:


```
/home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:271:14: error: no type named 'exception_ptr' in namespace 'std'; did you mean 'exception'?
271 | std::exception_ptr exception;
| ~~~~~^~~~~~~~~~~~~
| exception
/cxx_build/include/c++/v1/__exception/exception.h:72:33: note: 'exception' declared here
72 | class _LIBCPP_EXPORTED_FROM_ABI exception {
|
...

📝 maflcko converted_to_draft a pull request: "ci: Enable experimental kernel stuff in most CI tasks"
(https://github.com/bitcoin/bitcoin/pull/33824)
Most of the CI tasks have a long list of stuff that they enable. This makes it hard to see what each CI task is actually running.

Also, most of the CI tasks should probably mimic the `dev-mode` CMake preset and run on as much stuff as possible. Usually, changing the `dev-mode` comes with changing those CI tasks as well in the same commit, which is verbose.

Fix both issues, by basing most CI tasks on the `dev-mode`. In the future, this makes it easier to change the `dev-mode` in a single pl
...

💬 maflcko commented on pull request "ci: Enable experimental kernel stuff in most CI tasks":
(https://github.com/bitcoin/bitcoin/pull/33824#issuecomment-3506469571)
Hmm. Looks like this uncovered some errors. I'll circle back next week.

👍 TheCharlatan approved a pull request: "refactor: Add missing include in bitcoinkernel_wrapper.h"
(https://github.com/bitcoin/bitcoin/pull/33825#pullrequestreview-3438301340)
ACK fa1e8d8bad92f5fba2b086d78581df4c8123b098

📝 waketraindev converted_to_draft a pull request: "Prevent re-execution of sensitive commands from console history"
(https://github.com/bitcoin-core/gui/pull/909)
Sensitive RPC commands such as `walletpassphrase` or `createwallet`
may appear in the console history with their arguments redacted. Previously,
these entries could still be re-executed if recalled, potentially causing
unintended actions.

This change prefixes redacted history entries with a leading character(`!`),
marking them as non-executable when called. The console blocks their
execution and informs the user that the command was redacted.
The help text in `help-console` has been upd
...

🤔 hebasto reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3438351299)
My Guix build:
```
x86_64
a3647a46e00124b207263b695d9598cf9fe6c845ea9072c933462dd0e31a0ed9 guix-build-a02282d20c87/output/aarch64-linux-gnu/SHA256SUMS.part
6e3b9a2e39e207d98c347ccc0a81dfc6c79484befa5dbbeaaccdd0b44b759e99 guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu-debug.tar.gz
827f5c070c2ee3c8e1eb96cfd6f05551e4a69a00e422f808c15840026c7a27fc guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu.tar.gz
0614c466cb38f98
...

🤔 hebasto reviewed a pull request: "guix: build for Linux HOSTS with `-static-libgcc`"
(https://github.com/bitcoin/bitcoin/pull/33181#pullrequestreview-3438354635)
> Still waiting for my Guix build on RISC-V machine.

Here are intermediate results:
```
riscv64
b3870a41bd0bec7dd6be11f5fbfc31f2e3693b4a5aaba388035a26fe5ca87c79 guix-build-f06c6e189831/output/dist-archive/bitcoin-f06c6e189831.tar.gz
fdd0db1fef76e0b1f8eb5eab771a3d9cdfc0af6903fbccc6e256cee777d09d6a guix-build-f06c6e189831/output/x86_64-linux-gnu/SHA256SUMS.part
8625456849e70062d7532915f64d92a467ef58c1b6de3d6880e533995409c150 guix-build-f06c6e189831/output/x86_64-linux-gnu/bitcoin-f06c6e189831-
...