Bitcoin Core Github
43 subscribers
122K links
Download Telegram
👍 maflcko approved a pull request: "ci: Add fast IWYU job"
(https://github.com/bitcoin/bitcoin/pull/33810#pullrequestreview-3433404478)
lgtm. Seems fine
💬 maflcko commented on pull request "ci: Add fast IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#discussion_r2503088962)
```suggestion
# Don't apply patches in the iwyu job, because it relies on the `git diff`
```

nit, if you re-touch
💬 maflcko commented on issue "alexminer":
(https://github.com/bitcoin/bitcoin/issues/33815#issuecomment-3502188798)
@willcl-ark @pinheadmz Probably off-topic here, but I am thinking about just having those spam issues be auto-closed and locked by @DrahtBot . Any thoughts?
💬 pinheadmz commented on issue "alexminer":
(https://github.com/bitcoin/bitcoin/issues/33815#issuecomment-3502204812)
@maflcko yes ACK to that... can the bot edit title and description to null as well? (Will and I don't have permission)

Bot has been doing great with these heuristics auto closes. I just stroll by later and block the account if its total nonsense
💬 hebasto commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#discussion_r2503176033)
Thanks! Fixed.
💬 fanquake commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502215255)
> just to produce a diff that can be immediately applied.

The diff can't be applied at all, is always wrong to varying extents, and there are no instructions for devs on how to fix it.
💬 willcl-ark commented on issue "alexminer":
(https://github.com/bitcoin/bitcoin/issues/33815#issuecomment-3502215405)
Yeah ack from me too
fanquake closed an issue: "alexminer"
(https://github.com/bitcoin/bitcoin/issues/33815)
💬 maflcko commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502264978)
> instructions

Some basic instructions could be added after the `echo "^^^ ⚠️ Failure generated from IWYU"`, if needed.
💬 fanquake commented on pull request "net_processing: reorder the code that handles the VERSION message":
(https://github.com/bitcoin/bitcoin/pull/33792#issuecomment-3502276048)
cc @ajtowns
💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3502289963)
`e5e16de7b5...29ef3c62de`: rebase due to conflicts, drop the changes that were merged via https://github.com/bitcoin/bitcoin/pull/33793, thank you!
💬 hebasto commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502299400)
> > instructions
>
> Some basic instructions could be added after the `echo "^^^ ⚠️ Failure generated from IWYU"`, if needed.

Happy to add them once someone suggests good wording.
💬 fanquake commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#issuecomment-3502313400)
Guix Build (aarch64):
```bash
a3647a46e00124b207263b695d9598cf9fe6c845ea9072c933462dd0e31a0ed9 guix-build-a02282d20c87/output/aarch64-linux-gnu/SHA256SUMS.part
6e3b9a2e39e207d98c347ccc0a81dfc6c79484befa5dbbeaaccdd0b44b759e99 guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu-debug.tar.gz
827f5c070c2ee3c8e1eb96cfd6f05551e4a69a00e422f808c15840026c7a27fc guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu.tar.gz
0614c4
...
💬 m3dwards commented on pull request "cmake: Create subdirectories in build tree in advance":
(https://github.com/bitcoin/bitcoin/pull/32773#issuecomment-3502318619)
ACK 76dae5d6911b600fafa3a417a740f14b299284f3

Tested on arm Mac.
💬 fanquake commented on pull request "cmake: Create subdirectories in build tree in advance":
(https://github.com/bitcoin/bitcoin/pull/32773#issuecomment-3502325640)
cc @purpleKarrot
📝 l0rinc opened a pull request: "validation: reduce persisted UTXO set size by prioritizing positive lookups (RFC)"
(https://github.com/bitcoin/bitcoin/pull/33817)
*draft to gather comments and conceptual reviews*

-----

### Context

BIP30 prevents duplicate transaction IDs by checking whether outputs already exist in the UTXO set before adding them.
LevelDB's `FilterPolicy` stores a per-table probabilistic filter to optimize for negative lookups.

After the first ~230k blocks (BIP30/BIP34 windows), validation does not deliberately probe the UTXO set for missing entries (missing coins imply invalid transactions).
Bloom filters therefore slow the
...
📝 hebasto opened a pull request: "ci: Extend tidy job to cover kernel code"
(https://github.com/bitcoin/bitcoin/pull/33818)
🚀 fanquake merged a pull request: "script: remove dead code in `CountWitnessSigOps`"
(https://github.com/bitcoin/bitcoin/pull/33786)