📝 mccoystevens78-web opened a pull request: "Patch 1"
(https://github.com/bitcoin/bitcoin/pull/33798)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 mccoystevens78-web opened a pull request: "Update SECURITY.md"
(https://github.com/bitcoin/bitcoin/pull/33799)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 amitsingh881024-ctrl opened a pull request: "Create SECURITY.md — Strong Security Policy"
(https://github.com/bitcoin/bitcoin/pull/33800)
# Security Policy

## 🔒 Supported Versions

Please refer to the official lifecycle page to identify supported and actively maintained releases:
- [https://bitcoincore.org/en/lifecycle/#schedule](https://bitcoincore.org/en/lifecycle/#schedule)

Security updates are provided only for the listed maintained versions. Users are **strongly advised to upgrade** to supported versions to receive patches.

---

## 🚨 Reporting a Vulnerability

If you discover a security vulnerability, please
...

💬 amitsingh881024-ctrl commented on pull request "Create SECURITY.md — Strong Security Policy":
(https://github.com/bitcoin/bitcoin/pull/33800#issuecomment-3494370269)
curl -X POST \
-H "Authorization: token YOUR_GITHUB_TOKEN" \
-H "Accept: application/vnd.github+json" \
https://api.github.com/repos/OWNER/REPO/issues/PR_NUMBER/comments \
-d '{"body":"Please update the README before merging."}'

💬 amitsingh881024-ctrl commented on pull request "Create SECURITY.md — Strong Security Policy":
(https://github.com/bitcoin/bitcoin/pull/33800#issuecomment-3494371111)
curl -X POST \
-H "Authorization: token YOUR_GITHUB_TOKEN" \
-H "Accept: application/vnd.github+json" \
https://api.github.com/repos/OWNER/REPO/issues/PR_NUMBER/comments \
-d '{"body":"Please update the README before merging."}'

💬 w0xlt commented on pull request "rpc: Optionally print feerates in sat/vb":
(https://github.com/bitcoin/bitcoin/pull/33741#discussion_r2496724101)
This drags an RPC‑only dependency (UniValue) into a widely included policy header.
Instead, a helper in `rpc/util.{h,cpp}` (or `rpc/fees.h`) could be added such as:

```cpp
enum class FeeRateUnit { BTC_KVB, SAT_VB };
UniValue ValueFromFeeRate(const CFeeRate& fr, FeeRateUnit unit);
```

💬 w0xlt commented on pull request "rpc: Optionally print feerates in sat/vb":
(https://github.com/bitcoin/bitcoin/pull/33741#discussion_r2496731465)
Do the last six lines duplicate three assertions ?
You probably intended to add negative sat/vB cases.

💬 murchandamus commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#discussion_r2496738958)
> Removing UTXO's with the lowest effective_value minimizes the number of UTXOS included in the result when the maximum weight is exceeded.

Maybe we have diverging understandings of what the verb “minimize” means. I understand it to mean “reduce to a minimum”. Are you using it as a synonym for “reduce”? Or do you think that removing a single OutputGroup always reduces the selection to the minimum necessary selection?

Because, per my understanding of the verb, this algorithm does not _minim
...

💬 w0xlt commented on pull request "rpc: Optionally print feerates in sat/vb":
(https://github.com/bitcoin/bitcoin/pull/33741#discussion_r2496744390)
This line constructs a full object (with locking) only to reuse two values.
It also adds a new include `<rpc/mempool.h>` into `rpc/net.cpp`, creating an RPC‑RPC dependency.
It may be better to compute these two fields directly.

⚠️ Vashan69 opened an issue: "VLZO COIN"
(https://github.com/bitcoin/bitcoin/issues/33801)
### Please describe the feature you'd like to see added.

<img width="500" height="500" alt="Image" src="https://github.com/user-attachments/assets/e229fa17-1a3b-4fdc-ba8f-c3f0068840ac" />

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

<img width="4269" height="2400" alt="Image" src="https://github.com/user-attachments/assets/234cadb2-fef4-4d73-aa58-e2f392428dd9" />

### Describe any alternatives you've considered

_No r
...

⚠️ Vashan69 opened an issue: "VLZO"
(https://github.com/bitcoin/bitcoin/issues/33802)
### Please describe the feature you'd like to see added.

<img width="500" height="500" alt="Image" src="https://github.com/user-attachments/assets/e229fa17-1a3b-4fdc-ba8f-c3f0068840ac" />

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

<img width="4269" height="2400" alt="Image" src="https://github.com/user-attachments/assets/234cadb2-fef4-4d73-aa58-e2f392428dd9" />

### Describe any alternatives you've considered

_No r
...

⚠️ Vashan69 opened an issue: "VLZO COIN"
(https://github.com/bitcoin/bitcoin/issues/33803)
### Please describe the feature you'd like to see added.

<img width="500" height="500" alt="Image" src="https://github.com/user-attachments/assets/e229fa17-1a3b-4fdc-ba8f-c3f0068840ac" />

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

<img width="4269" height="2400" alt="Image" src="https://github.com/user-attachments/assets/234cadb2-fef4-4d73-aa58-e2f392428dd9" />

### Describe any alternatives you've considered

_No r
...

⚠️ Vashan69 opened an issue: "VLZO COIN"
(https://github.com/bitcoin/bitcoin/issues/33804)
### Please describe the feature you'd like to see added.

<img width="500" height="500" alt="Image" src="https://github.com/user-attachments/assets/e229fa17-1a3b-4fdc-ba8f-c3f0068840ac" />

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

<img width="4269" height="2400" alt="Image" src="https://github.com/user-attachments/assets/234cadb2-fef4-4d73-aa58-e2f392428dd9" />

### Describe any alternatives you've considered

_No r
...

✅ achow101 closed an issue: "VLZO COIN"
(https://github.com/bitcoin/bitcoin/issues/33801)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/33802)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/33804)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/33803)

💬 frankomosh commented on pull request "doc: add cmake help option in Windows build docs":
(https://github.com/bitcoin/bitcoin/pull/33789#discussion_r2497242092)
Thanks for clarifying. I think i'll keep it as-is for now. Yes, unifying structure across build docs as you have suggested is great and can indeed be tackled seperately. Appreciate your feedback!

🤔 pablomartin4btc reviewed a pull request: "test: move create_malleated_version() to messages.py for reuse"
(https://github.com/bitcoin/bitcoin/pull/33793#pullrequestreview-3426229391)
cr ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769

💬 maflcko commented on pull request "test: skip interface_ipc if python version is freethreaded and PYTHON_GIL=0 is not set":
(https://github.com/bitcoin/bitcoin/pull/33795#issuecomment-3495381887)
As mentioned in the issue, I don't see the problem that free threading solves for us. In fact, it is likely going to cause more issues that are not worth it to debug nor fix.

Free threading could make sense if there is a heavy multithreaded production workload. However, I don't see this in the functional test, which are single-threaded, or at most double threaded?

I'd say we should just require the GIL for all Python code. I can't see Python removing the GIL any time soon without controve
...