💬 umrashrf commented on issue "Can I compile on OSX Tahoe?":
(https://github.com/bitcoin/bitcoin/issues/33733#issuecomment-3462647625)
Boost libs https://gist.github.com/umrashrf/15bfff6425025902a7f310d867929f14

🚀 fanquake merged a pull request: "build: Bump clang minimum supported version to 17"
(https://github.com/bitcoin/bitcoin/pull/33555)

💬 ajtowns commented on issue "Batch tx broadcast RPC":
(https://github.com/bitcoin/bitcoin/issues/33700#issuecomment-3462702682)
I'd contend that if you could make a p2p connection, announce `INV tx1 tx2 ...` and reply to `GETDATA` requests (or BIP331 messages or whatever we add in future), and get your txs added to the node's mempool and relayed onwards, then you should be able to get the same result with a simple RPC call.

For errors, I think it would be preferable to have a parameter that decides whether the behaviour should be "only accept anything if you can accept everything" or "accept as much as you can and tell
...

💬 ismaelsadeeq commented on pull request "fees: enable `CBlockPolicyEstimator` return sub 1 sat/vb fee rate estimates":
(https://github.com/bitcoin/bitcoin/pull/33199#discussion_r2474293335)
Fixed

💬 ismaelsadeeq commented on pull request "fees: enable `CBlockPolicyEstimator` return sub 1 sat/vb fee rate estimates":
(https://github.com/bitcoin/bitcoin/pull/33199#discussion_r2474293676)
Fixed

💬 enirox001 commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#issuecomment-3462730169)
In commit ac7f694

Fixed the no-op issue raised by @maflcko and @Eunovo. The test was calling getblockstats twice and comparing results against itself. Now it calls getblockstats once and validates consistency

💬 ismaelsadeeq commented on pull request "fees: enable `CBlockPolicyEstimator` return sub 1 sat/vb fee rate estimates":
(https://github.com/bitcoin/bitcoin/pull/33199#issuecomment-3462730845)
Rebased and fixed nits.

💬 fanquake commented on pull request "fuzz: don't pass (maybe) nullptr to memcpy()":
(https://github.com/bitcoin/bitcoin/pull/33644#discussion_r2474301667)
@vasild did you want to follow up here?

💬 furszy commented on pull request "rpc: add "ischange: true" to decoded tx outputs in wallet gettransaction response":
(https://github.com/bitcoin/bitcoin/pull/32517#issuecomment-3462765091)
ACK [060bb55](https://github.com/bitcoin/bitcoin/pull/32517/commits/060bb55508245776bb6a39c8b7849769ee588d69)

💬 hebasto commented on issue "Can I compile on OSX Tahoe?":
(https://github.com/bitcoin/bitcoin/issues/33733#issuecomment-3462777867)
@umrashrf

Could you please post the output of the following command:
```
rm -rf build && cmake -B build -DENABLE_IPC=OFF -DBUILD_GUI=OFF -DWITH_QRENCODE=OFF -LA 2>&1 | grep -i boost
```
?

💬 ryanofsky commented on pull request "init: Split file path handling out of -asmap option":
(https://github.com/bitcoin/bitcoin/pull/33631#issuecomment-3462799469)
> If reading a file by default or embedding it into the binary gets rid of that, that's fine with me too. But i guess even in that case, one might want to either disable the functionality, or override the path?

Yes, these things are done with `-noasmap` and `-asmap=<filename>` and covered in existing `feature_asmap.py` tests.

> It seems partly orthogonal to these options.

I do think the issues are pretty directly related, not orthogonal. The basic problem here is that this option's defa
...

💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for `src/init` and `src/policy`":
(https://github.com/bitcoin/bitcoin/pull/33725#issuecomment-3462818493)
> > this pull request conflicts with the following ones:
> > #33629 (Cluster mempool by sdaftuar)
> > #33591 (Cluster mempool followups by sdaftuar)
>
> I think if you want to continue these refactors, it might be better if you picked code that doesn't conflict with Cluster Mempool or Kernel work, or things we are trying to ship in `v31`.

I agree, and when I noticed these conflicts, I checked that those PRs don't have any ACKs yet.

> Could instead do directories that rarely change, li
...

💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for `src/init` and `src/policy`":
(https://github.com/bitcoin/bitcoin/pull/33725#discussion_r2474367441)
We use a tiny part of Boost, which seems quite stable. So I don’t think it’s worth the effort.

💬 umrashrf commented on issue "Can I compile on OSX Tahoe?":
(https://github.com/bitcoin/bitcoin/issues/33733#issuecomment-3462842254)
@hebasto I first put the output to a file so I can resue it later.

```
% cat configure.log.3 | grep -i boost
-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE
-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE - Failed
Boost_DIR:PATH=/opt/homebrew/opt/boost/lib/cmake/Boost-1.89.0
boost_headers_DIR:PATH=/opt/homebrew/opt/boost/lib/cmake/boost_headers-1.89.0
```

💬 hebasto commented on issue "Can I compile on OSX Tahoe?":
(https://github.com/bitcoin/bitcoin/issues/33733#issuecomment-3462861458)
@umrashrf

I have a guess, and to confirm it, I'd ask you to try configuring and building with the additional `-DENABLE_WALLET=OFF` option.

💬 00w1 commented on issue "dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us appears to be violating DNS seed policy":
(https://github.com/bitcoin/bitcoin/issues/33734#issuecomment-3462899397)
> Luke-jr's seed returns knots 29.2 nodes, and yet he claims knots 29.2 is based on the same code it currently won't return. https://x.com/LukeDashjr/status/1977355254510256135 even though the issue is now known to luke-jr the behavior hasn't been corrected.

I have been trying to resolve `dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us` since last 15 minutes but it did not return any knots v29.2 node IP address in the response. Others who reviewed https://github.com/bitcoin/bitcoin/pull/33723 did n
...

💬 umrashrf commented on issue "Can I compile on OSX Tahoe?":
(https://github.com/bitcoin/bitcoin/issues/33733#issuecomment-3462919053)
@hebasto tried that but fails.

configure.log https://gist.github.com/umrashrf/691047f40e17b7ca06abce2d25375323
build.log https://gist.github.com/umrashrf/019e10e3fca1c6a686b556c7a6b65ce2

⚠️ 00w1 opened an issue: "Remove *petertodd.net DNS seed for testnet and mainnet"
(https://github.com/bitcoin/bitcoin/issues/33736)
Creating an issue based on @glozow's suggestion in https://github.com/bitcoin/bitcoin/pull/33730#issuecomment-3461843402

Some [emails](https://agorism.dev/petertodd-emails.txt) were leaked on bitcointalk and Peter Todd acknowledged that they are not fake. His communication with someone about bitcoin development and privacy who claims to work for government agencies potentially violates the DNS seed policy.

> A DNS seed operating organization or person is expected to follow good host security p
...

💬 achow101 commented on issue "Remove *petertodd.net DNS seed for testnet and mainnet":
(https://github.com/bitcoin/bitcoin/issues/33736#issuecomment-3463006389)
Can you cite where in those emails you believe this part of the policy is being violated? I searched for "dns" and "seed" and got no results. I searched for "server" and don't see anything that seems to discuss handing over any DNS seed infrastructure to someone else.

👍 pinheadmz approved a pull request: "http: replace WorkQueue and single threads handling for ThreadPool"
(https://github.com/bitcoin/bitcoin/pull/33689#pullrequestreview-3395201777)
ACK f5eca8d5252a68f0fbc8b5efec021c75744555b6

minor changes since last ack

<details><summary>Show Signature</summary>

```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK f5eca8d5252a68f0fbc8b5efec021c75744555b6
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmkCWuYACgkQ5+KYS2KJ
yTpb9RAAgxNlDQlqkVfnIK2Xt8BQmRsiG+1KHQGJA2d3RHoxjFg2129fj47y5i+t
GlatlcsXEcibI2D0F22sKSzY1u0LWy4GYLI1d12JAIewA99n/lRr1ktDk3v64pp8
kldvYpd8UBs7DCHSJhPs4HbOPgwIILPASdSbQTb+6m48X5jg+cu+yMBu
...