💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2442498819)
this seems overly general to me, I think we can inline the delay for now

💬 hebasto commented on issue "ZMQ problem: 'ss -ltnp | grep 28332' and 'ss -ltnp | grep 28333' does not give me an answer (i need it for LND)":
(https://github.com/bitcoin/bitcoin/issues/33710#issuecomment-3453513998)
> Compile process:
>
> ```
> [GIT stuff here]
> apt install -y cmake
> cd ~/bitcoin
> mkdir build
> cd build
> apt install -y capnproto libcapnp-dev
> cmake .. -DBUILD_BITCOIN_WALLET=ON -DENABLE_ZMQ=ON -DBUILD_TESTING=OFF -DBUILD_BENCH=OFF
> make -j$(nproc)
> ```

s/-DENABLE_ZMQ=ON/-DWITH_ZMQ=ON/

For more details please refer to https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md.

💬 TheCharlatan commented on pull request "http: replace WorkQueue and single threads handling for ThreadPool":
(https://github.com/bitcoin/bitcoin/pull/33689#issuecomment-3453541325)
Approach ACK

👍 TheCharlatan approved a pull request: "Add a "tx output spender" index"
(https://github.com/bitcoin/bitcoin/pull/24539#pullrequestreview-3385723797)
Re-ACK 9d3dfd77224fbe40033feccb346a167dc5f031a7

✅ kosuodhmwa closed an issue: "ZMQ problem: 'ss -ltnp | grep 28332' and 'ss -ltnp | grep 28333' does not give me an answer (i need it for LND)"
(https://github.com/bitcoin/bitcoin/issues/33710)

💬 kosuodhmwa commented on issue "ZMQ problem: 'ss -ltnp | grep 28332' and 'ss -ltnp | grep 28333' does not give me an answer (i need it for LND)":
(https://github.com/bitcoin/bitcoin/issues/33710#issuecomment-3453614584)
thank you very much! :-)

📝 stevensmccoy734-commits opened a pull request: "Add Docker Image CI workflow"
(https://github.com/bitcoin/bitcoin/pull/33716)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 ryanofsky commented on pull request "wallet: re-activate "AmountWithFeeExceedsBalance" error":
(https://github.com/bitcoin/bitcoin/pull/25269#discussion_r2467450779)
re: https://github.com/bitcoin/bitcoin/pull/25269#discussion_r2115800834

Thinking about this more I can see why SFFO should make the "amount exceeds your balance when fees are included" condition harder to trigger than when SFFO is not used, because when SFFO is enabled the wallet is able to reduce the amounts recipients receive to cover any fees, whereas without SFFO the amount received needs to be fixed. But I'd still expect the `(available_balance >= recipients_sum && available_effective_b
...

💬 Krellan commented on pull request "gui: Add a menu action to restore then migrate a legacy wallet":
(https://github.com/bitcoin-core/gui/pull/877#issuecomment-3453956904)
I was able to work around my problem by downgrading to an older version of Bitcoin which still recognized the older wallet format my wallet was in at the time. I then made a backup, using that older version of Bitcoin, and it wrote my wallet in a slightly newer format. That was good enough to get my old wallet recognized by the current version of Bitcoin, with zero loss, I'm happy to report. And I paid off my house!

💬 kannapoix commented on pull request "doc: update multisig tutorial to use multipath descriptors":
(https://github.com/bitcoin/bitcoin/pull/33286#issuecomment-3453972624)
Core review ACK: de7c3587cd4586bbed94a4ea6eae4a252301daee

📝 stevensmccoy734-commits opened a pull request: "Delete .gitignore"
(https://github.com/bitcoin/bitcoin/pull/33717)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 stevensmccoy734-commits opened a pull request: "Add .gitignore file with common patterns"
(https://github.com/bitcoin/bitcoin/pull/33718)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 ryanofsky commented on pull request "wallet: re-activate "AmountWithFeeExceedsBalance" error":
(https://github.com/bitcoin/bitcoin/pull/25269#discussion_r2467589769)
re: https://github.com/bitcoin/bitcoin/pull/25269#discussion_r2115800834

Update: think I finally figured this out. In the SFFO case the fee exceeds balance error can still happen but the `available_balance >= recipients_sum` condition will not detect it. So I think the change I would suggest would just be dropping the `m_subtract_fee_outputs` code and writing a more descriptive comment:

```diff
--- a/src/wallet/spend.cpp
+++ b/src/wallet/spend.cpp
@@ -1164,12 +1164,19 @@ static util::Re
...

📝 stevensmccoy734-commits opened a pull request: "Add .gitignore file with editor and build patterns"
(https://github.com/bitcoin/bitcoin/pull/33719)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 151henry151 commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#issuecomment-3454098765)
Rebased on latest master and cleaned up commit message/PR description. Guix build in progress - will post hashes once complete.

📝 stevensmccoy734-commits opened a pull request: "Delete .github/workflows/ci.yml"
(https://github.com/bitcoin/bitcoin/pull/33720)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 stevensmccoy734-commits opened a pull request: "Patch 6"
(https://github.com/bitcoin/bitcoin/pull/33721)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 waketraindev commented on pull request "addrman, net: filter during address selection via AddrPolicy to avoid underfill":
(https://github.com/bitcoin/bitcoin/pull/33663#issuecomment-3454896610)
Added AddrPolicy coverage in addrman_tests

💬 maflcko commented on issue "Cannot import descriptors with label and internal:false":
(https://github.com/bitcoin/bitcoin/issues/32376#issuecomment-3455029791)
Can be closed after https://github.com/bitcoin/bitcoin/pull/31514?

💬 Sjors commented on issue "RFC: Adding bitcoin-{node,gui} binaries for IPC in 30.0 release":
(https://github.com/bitcoin/bitcoin/issues/31756#issuecomment-3455071260)
🎉

The sidecar application that connects to `bitcoin-node` / `bitcoin -m node` now lives here: https://github.com/sjors/sv2-tp

It can connect to the v30 release.