👍 hebasto approved a pull request: "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2"
(https://github.com/bitcoin/bitcoin/pull/33185#pullrequestreview-3380138604)
re-ACK 59c4898994bde3d86168075f0031c9d5a9ac5c8f.

💬 enirox001 commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#discussion_r2462960057)
Thanks for the review @maflcko! You were spot on, I'd turned that into a no-op.

I've restored the gen_test_data / load_test_data logic so it's a proper regression test again. I've generated the new rpc_getblockstats.json file and added it to the PR.

Also updated the PR description to better reflect changes made

💬 hebasto commented on pull request "build: Use clang-cl to build on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31507#issuecomment-3446975081)
> > > Yes. I forgot to put this link into my previous comment: [bitcoin-core/secp256k1#1681](https://github.com/bitcoin-core/secp256k1/pull/1681).
> >
> >
> > Have you seen the same from actually running Core, or it's benchmarks, or an IBD?
>
> I'll refresh my benchmarks and post them shortly.

Below are benchmarks on my Windows machine:
<details>

<summary>Compiled with MSVC</summary>

```
| ns/op | op/s | err% | total | benchmark
|----------
...

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r2462992380)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/9d3dfd77224fbe40033feccb346a167dc5f031a7

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r2462992391)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/9d3dfd77224fbe40033feccb346a167dc5f031a7

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r2462992401)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/9d3dfd77224fbe40033feccb346a167dc5f031a7

💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#issuecomment-3447786473)
Tested the performance of the new REST endpoint using `ab` on mainnet with various `SIZE` parameters:
```
$ BLOCKHASH=00000000000000000001eae3683a5350b67ddb17d9c7b6c8010ab5b36ccbaa09
$ ab -q -k -c 1 -n 100000 'http://localhost:8332/rest/blockpart/BLOCKHASH.bin?offset=0&size=SIZE'
```
| `SIZE` | Time per request [ms] |
| - | - |
| 1 | 0.03 |
| 10 | 0.03 |
| 100 | 0.03 |
| 1k | 0.03 |
| 10k | 0.04 |
| 100k | 0.07 |
| 1M | 0.6 |

So fetching a typical transaction is expected to tak
...

💬 andrewtoth commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#issuecomment-3447826732)
Compared your command fetching SIZE=788 and block 850000 with a 788 byte tx in that block 2d2dcc80195541dd44209dcfeb25393c8c8710f262360368a618b7ff3fa3f08c using `getrawtransaction` with `txindex`. I used hex encoding to make the comparison more fair.

```
ab -q -k -c 1 -n 1000000 'http://localhost:8332/rest/blockpart/00000000000000000002a0b5db2a7f8d9087464c2586b546be7bce8eb53b8187.hex?offset=0&size=788'
```
I got `Time per request: 0.037 [ms] (mean)`.
```
ab -q -k -c 1 -n 1000000 -p
...

📝 redmsqt opened a pull request: "Add base fileBaseb"
(https://github.com/bitcoin/bitcoin/pull/33703)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 redmsqt commented on pull request "Add base fileBaseb":
(https://github.com/bitcoin/bitcoin/pull/33703#issuecomment-3447957799)
Base

📝 mccoyadd opened a pull request: "Add CI workflow for C/C++ projects"
(https://github.com/bitcoin/bitcoin/pull/33704)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 mccoyadd opened a pull request: "Delete test directory"
(https://github.com/bitcoin/bitcoin/pull/33705)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 mccoyadd opened a pull request: "Patch 1"
(https://github.com/bitcoin/bitcoin/pull/33706)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 mccoyadd opened a pull request: "Update README to reflect active line status"
(https://github.com/bitcoin/bitcoin/pull/33707)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 mccoyadd opened a pull request: "29.x"
(https://github.com/bitcoin/bitcoin/pull/33708)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed a pull request: "Delete test directory"
(https://github.com/bitcoin/bitcoin/pull/33705)

💬 ubbabeck commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#issuecomment-3448550601)
> @ubbabeck could you please test it too?

Sure here her my results for the same test using the same params and ApacheBench, Version 2.3
<details>

| SIZE | Time per request [ms] |
| ---- | --------------------- |
| 1 | 0.046 |
| 10 | 0.046 |
| 100 | 0.050 |
| 1k | 0.050 |
| 10k | 0.054 |
| 100k | 0.113 |
| 1m | 0.803 |

Fetching on average tx on my system is
...

💬 Raimo33 commented on pull request "refactor: optimize: avoid allocations in script & policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3448567609)
As suggested, I've removed some commits to keep this PR simple. I'll open a follow up PR with the more complex but related commits that change the API.

As per the benchmarks, there currently is no benchmark that realistically measures the impacted methods, and I'm afraid I'll not be able to code one. we'd need to measure `AreInputsStandard()`, `IsWitnessStandard()` and `Solver()` which depend on too many variables.

⚠️ darosior opened an issue: "GetSerializeSize's return type should not be platform dependent"
(https://github.com/bitcoin/bitcoin/issues/33709)
That `GetSerializeSize` returns a `size_t` is the root cause behind low-severity [CVE-2025-46597](https://bitcoincore.org/en/2025/10/24/disclose-cve-2025-46597/). Now that the advisory is published, we should fix this.

💬 mansiverma897993 commented on issue "GetSerializeSize's return type should not be platform dependent":
(https://github.com/bitcoin/bitcoin/issues/33709#issuecomment-3448669054)
Please assign me this issue .