🚀 achow101 merged a pull request: "p2p: add `DifferenceFormatter` fuzz target and invariant check"
(https://github.com/bitcoin/bitcoin/pull/33252)

💬 achow101 commented on pull request "rpc: refactor: use string_view in Arg/MaybeArg":
(https://github.com/bitcoin/bitcoin/pull/32983#issuecomment-3444159368)
ACK b63428ac9ce2c903670409b3e47b9f6730917ae8

💬 achow101 commented on pull request "refactor: unify container presence checks":
(https://github.com/bitcoin/bitcoin/pull/33192#issuecomment-3444171405)
> rfm

I don't think so. This PR lacks review from senior contributors. It's also mostly a stylistic change which we generally do not care about doing. This also conflicts with cluster mempool which is a project that I think we want to be avoiding conflicts with in general at this point.

⚠️ TheBlueMatt opened an issue: "Batch tx broadcast RPC"
(https://github.com/bitcoin/bitcoin/issues/33700)
### Please describe the feature you'd like to see added.

The intent of #31085 wasn't really *just* to be able to broadcast a "package" of size 1, but that it would be nice if the caller of `submitpackage` didn't need to sit down and figure out/make sure all their broadcasts match exactly some BIP-defined structure. Ideally I just give Bitcoin Core a pile of transactions and it figures it out - if there's two children and two parents it broadcasts them as two packages, etc. Maybe this is just so
...

💬 diegoviola commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-3444184782)
> This fix just doesn't work on Qt6 anymore as it was on Qt5, so I need to investigate how the same behaviour can be replicated.

I suggest looking into `requestActivate()` for getting this done.

If my understanding is correct, in the context of Wayland, there is no "top" and "front", and focus isn't something that can be stolen from an app either. So I don't think `GUIUtil::bringToFront` which calls `Qt::WindowStaysOnTopHint` has any chance of working.

`requestActivate()` would, in theo
...

💬 TheBlueMatt commented on issue "Batch tx broadcast RPC":
(https://github.com/bitcoin/bitcoin/issues/33700#issuecomment-3444208682)
Oh, maybe the most important relaxation would be to remove the topological-sort requirement.

💬 achow101 commented on pull request "log: print every script verification state change":
(https://github.com/bitcoin/bitcoin/pull/33336#issuecomment-3444209034)
ACK 45bd8914658a675d00aa9c83373d6903a8a9ece8

🚀 achow101 merged a pull request: "rpc: refactor: use string_view in Arg/MaybeArg"
(https://github.com/bitcoin/bitcoin/pull/32983)

🤔 jonatack reviewed a pull request: "test: Update BIP324 test vectors"
(https://github.com/bitcoin/bitcoin/pull/33688#pullrequestreview-3378075933)
ACK 51877f2fc5eb02b4229258b4b43731c4da843793

> This is a draft because https://github.com/bitcoin/bips/pull/2016 has not been merged.

Can now remove from the PR description.

💬 jotapea commented on pull request "More comprehensive datacarrier configuration":
(https://github.com/bitcoin/bitcoin/pull/33682#issuecomment-3444266049)
> more heterogeneity → less mempool overlap → more missing transactions during compact block reconstruction → slower propagation on the critical path

@cedwies (hopefully with @achow101 's permission), didn't v30.0 **increase** this heterogeneity? i.e:

> v30.0 nodes with -datacarriersize=83 are still relaying transactions with multiple OP_RETURN outputs, transactions which all nodes prior to v30.0 will reject..

Fixing [#33690](https://github.com/bitcoin/bitcoin/pull/33690) would improve
...

🚀 achow101 merged a pull request: "log: print every script verification state change"
(https://github.com/bitcoin/bitcoin/pull/33336)

💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3444285774)
Let me summarize our offline discussions:

### Cache hierarchy

During block connection we're adding an extra temporary in-memory dbcache layer on top so that whatever happens during block connection doesn't end up polluting the big dbcache or leveldb.
I think we should take advantage of this and use the temporary top layer to collect the missing inputs there:
* if block validation fails we can just throw it out
* it's easier to test and benchmark, we can rerun the same operation without
...

💬 l0rinc commented on pull request "log: print every script verification state change":
(https://github.com/bitcoin/bitcoin/pull/33336#issuecomment-3444302074)
Thank you all for the reviews, appreciate the help.
Once we're branching for `30.1` I'd like to suggest we backport this.

🚀 achow101 merged a pull request: "fuzz: enhance wallet_fees by mocking mempool stuff"
(https://github.com/bitcoin/bitcoin/pull/33210)

💬 furszy commented on pull request "http: replace WorkQueue and single threads handling for ThreadPool":
(https://github.com/bitcoin/bitcoin/pull/33689#issuecomment-3444568607)
> Can't we use an already existing open source library instead of reinventing the wheel?

That's a good question. It's usually where we all start.
Generally, the project consensus is to avoid introducing new external dependencies (unless they’re maintained by us) to minimize potential attack vectors. This doesn’t mean we should reinvent everything, just that we need to be very careful about what we decide to include.

That being said, for the changes introduced in this PR, can argue that we
...

💬 achow101 commented on pull request "clang-format: make formatting deterministic for different formatter versions":
(https://github.com/bitcoin/bitcoin/pull/32813#issuecomment-3444782149)
ACK 13f36c020f0329b5e975282b45292fdf2a495e31

💬 theStack commented on pull request "rpc: allow writing UTXO set to a named pipe, introduce dump_to_sqlite.sh script":
(https://github.com/bitcoin/bitcoin/pull/31560#issuecomment-3444789711)
Rebased on master (due to conflict with recently merged #32983, commit b63428ac9ce2c903670409b3e47b9f6730917ae8).

🚀 achow101 merged a pull request: "clang-format: make formatting deterministic for different formatter versions"
(https://github.com/bitcoin/bitcoin/pull/32813)

💬 kevkevinpal commented on pull request "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult":
(https://github.com/bitcoin/bitcoin/pull/32958#issuecomment-3444860797)
Just rebased the PR to [86d9a82](https://github.com/bitcoin/bitcoin/pull/32958/commits/86d9a82cc8f4c5dd873592ef3589fd2406bb513c) since @DrahtBot was upset

💬 diegoviola commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-3444933735)
> from the current application

Application window/surface.