💬 yancyribbens commented on issue "coin-grinder missing test for TOTAL_TRIES":
(https://github.com/bitcoin/bitcoin/issues/33419#issuecomment-3440231707)
Something like this would work:

```c++
{
// #################################################################################################################
// 8) Max iterations
// #################################################################################################################
CAmount target = 8 * COIN;
int max_selection_weight = 3200; // WU
const auto& res = CoinGrinder(target, dummy_params, m_node, max_selection_weight, [&
...

📝 fanquake opened a pull request: "ci: use pycapnp 2.2.1"
(https://github.com/bitcoin/bitcoin/pull/33693)

🚀 fanquake merged a pull request: "util: Abort on failing CHECK_NONFATAL in debug builds"
(https://github.com/bitcoin/bitcoin/pull/32588)

💬 fanquake commented on pull request "[wip] [nomerge] [draft] 2510 msan zero":
(https://github.com/bitcoin/bitcoin/pull/33686#issuecomment-3440580382)
4h 53m for MSAN depends.
MSAN Fuzz cancelled after 6 hours.

💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2458728270)
Neither 4 nor 8 helped hit the case, will look into it more.

💬 00w1 commented on pull request "Datacarrier backwards compatibility and improved test coverage":
(https://github.com/bitcoin/bitcoin/pull/33690#issuecomment-3441000599)
@jotapea Some users might be [interested](https://x.com/skot9000/status/1977676769542201663) in this patch and #33682. I would suggest that you share the links along with a summary on [delvingbitcoin](https://delvingbitcoin.org/), [mailing list](https://groups.google.com/g/bitcoindev/), [bitcointalk](https://bitcointalk.org/) and [stacker.news](https://stacker.news/). They would be a better place to look for constructive feedback.

You can also add that v30 relase notes are misleading: https:/
...

💬 jotapea commented on pull request "Datacarrier backwards compatibility and improved test coverage":
(https://github.com/bitcoin/bitcoin/pull/33690#issuecomment-3441086614)
Replied on [X](https://x.com/uanbtc/status/1981586817003471300). I have no account on the other suggestions, would greatly appreciate if you can help spread the word.

I am enjoying getting involved and learning the codebase, so I see no issue at all in maintaining these [patches](https://github.com/jotapea/bitcoin/branches).

💬 dasrecord commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-3441101547)
@jlopp has an obvious conflict of interest. @BitcoinMechanic should be unblocked.

💬 hodlinator commented on pull request "node: Add --debug_runs/-waitfordebugger + --debug_cmd":
(https://github.com/bitcoin/bitcoin/pull/31723#issuecomment-3441238061)
Latest push adds 9d1de2e8b3c73edc44bb3f7578ec96c2b91c2dd8 to support modifying a functional test to make a specific node (re)start trigger attaching of a debugger. This may be a more natural alternative when humans read through functional test code and want to select a specific node instance to debug.

(It also removes a header which caused a build failure on Alpine/musl, and adds helpful details in 2 commit messages).

There has been some feedback to see if we could avoid changing the funct
...

💬 w0xlt commented on pull request "[Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2":
(https://github.com/bitcoin/bitcoin/pull/32617#issuecomment-3441441134)
PSK functionality removed.
Thanks for the suggestion @theStack and @nothingmuch

💬 pablomartin4btc commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-3441484004)
> Can you say what those issues are?

This fix just doesn't work on Qt6 anymore as it was on Qt5, so I need to investigate how the same behaviour can be replicated.

🤔 pablomartin4btc reviewed a pull request: "Fix bitcoin-qt visual glitches on Wayland"
(https://github.com/bitcoin-core/gui/pull/904#pullrequestreview-3374875546)
tested 095f920629207b5ec4c50de7b454dfced0eafefb and it fixes the problem.

I still need to check if this is the right approach, need to check against `xcb` and `macOS`. Also there are other places where `bringToFront` is being used, the `rpcconsole` has the same issue as the main window in `wayland`, so perhaps the fix has to be within `bringToFront`, need more time to test. Thanks for finding the issue and taking a look at this!

💬 maflcko commented on pull request "ci: use pycapnp 2.2.1":
(https://github.com/bitcoin/bitcoin/pull/33693#issuecomment-3441558476)
unrelated nit: I think you can also remove this comment:

```
# Homebrew's python@3.12 is marked as externally managed (PEP 668).
# Therefore, `--break-system-packages` is needed.
```

Since, homebrew has updated the python version number, and the comment isn't added to any of the other `--break-system-packages` options where set.

💬 fanquake commented on pull request "ci: use pycapnp 2.2.1":
(https://github.com/bitcoin/bitcoin/pull/33693#issuecomment-3441589055)
> I think you can also remove this comment:

Added a removal.

💬 maflcko commented on pull request "ci: use pycapnp 2.2.1":
(https://github.com/bitcoin/bitcoin/pull/33693#issuecomment-3441611867)
lgtm ACK 8088643a616355b941fabbd584013c5969c0d1dc

💬 fanquake commented on pull request "[WIP] doc: update Guix install instructions":
(https://github.com/bitcoin/bitcoin/pull/33574#issuecomment-3441654137)
Looks like a `1.5.0` release might happen in January, according to https://codeberg.org/guix/release-planning/wiki/release-1.5.0-project.

🚀 fanquake merged a pull request: "ci: Drop libFuzzer from msan fuzz task"
(https://github.com/bitcoin/bitcoin/pull/33666)

💬 maflcko commented on pull request "ci: Retry image building once on failure":
(https://github.com/bitcoin/bitcoin/pull/33677#discussion_r2459256446)
Hmm, it is interesting to see CI seemingly pass on your commit. However, I think you are just exploiting a bug in Docker. Passing an empty string as an argument is normally not equal to passing no argument. Maybe Docker is doing that internally, but Podman is not, and it will fail there.

You can also check this locally:

```
$ podman run --rm "--cap-add=LINUX_IMMUTABLE" "" 'alpine:latest' echo hi
Error: parsing reference "": repository name must have at least one component
```

or via
...

💬 fanquake commented on issue "ci: windows-native-dll-vcpkg-* cache does not work?":
(https://github.com/bitcoin/bitcoin/issues/33685#issuecomment-3441731165)
cc @willcl-ark @m3dwards

📝 MChuanying001 opened a pull request: "Codex/modify testnet3 to create zhaolunet a1r0sg"
(https://github.com/bitcoin/bitcoin/pull/33694)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...