✅ achow101 closed a pull request: "Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only"
(https://github.com/bitcoin/bitcoin/pull/26398)

💬 achow101 commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#issuecomment-3432934694)
Are you still working on this?

✅ achow101 closed a pull request: "test: Verify that a message is not in rpc errors raised (follow-up 31451)"
(https://github.com/bitcoin/bitcoin/pull/32174)

💬 achow101 commented on pull request "test: Verify that a message is not in rpc errors raised (follow-up 31451)":
(https://github.com/bitcoin/bitcoin/pull/32174#issuecomment-3432937021)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed a pull request: "OP_CHECKCONTRACTVERIFY"
(https://github.com/bitcoin/bitcoin/pull/32080)

💬 achow101 commented on pull request "OP_CHECKCONTRACTVERIFY":
(https://github.com/bitcoin/bitcoin/pull/32080#issuecomment-3432952954)
This seems like something for Bitcoin Inquisition, now that that has been rebased.

👋 willcl-ark's pull request is ready for review: "Permit Combiner to strip bip32_deriv information"
(https://github.com/bitcoin/bitcoin/pull/30341)

✅ achow101 closed a pull request: "Add read-only mode to sqlite db and use in `bitcoin-wallet`"
(https://github.com/bitcoin/bitcoin/pull/32818)

💬 achow101 commented on pull request "Add read-only mode to sqlite db and use in `bitcoin-wallet`":
(https://github.com/bitcoin/bitcoin/pull/32818#issuecomment-3432975964)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "docs: add guidance on initialism capitalisation in PascalCase identifiers."
(https://github.com/bitcoin/bitcoin/pull/32720)

💬 achow101 commented on pull request "docs: add guidance on initialism capitalisation in PascalCase identifiers.":
(https://github.com/bitcoin/bitcoin/pull/32720#issuecomment-3432980411)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs.

Closing due to lack of interest.

💬 achow101 commented on pull request "test: Introduce `SUPPRESS_ABORT_MESSAGE` environment variable":
(https://github.com/bitcoin/bitcoin/pull/32409#issuecomment-3432986859)
Are you still working on this?

✅ maflcko closed an issue: "doc: Developer Notes don't give advice on initialisms in class/function/method names"
(https://github.com/bitcoin/bitcoin/issues/32698)

💬 maflcko commented on issue "doc: Developer Notes don't give advice on initialisms in class/function/method names":
(https://github.com/bitcoin/bitcoin/issues/32698#issuecomment-3432990947)
(closing for now, as the pull is also closed)

💬 achow101 commented on pull request "checkqueue: set MAX_SCRIPTCHECK_THREADS to nCores - 1":
(https://github.com/bitcoin/bitcoin/pull/32692#issuecomment-3433007612)
Are you still working on this?

💬 maflcko commented on pull request "test: Introduce `SUPPRESS_ABORT_MESSAGE` environment variable":
(https://github.com/bitcoin/bitcoin/pull/32409#issuecomment-3433010318)
> @maflcko
>
> > No objection, but assert/Assert seems to be used widely in the codebase, so shouldn't this be done for all test binaries, or none? Otherwise the same assert could lead to inconsistent behavior, depending on which test binary ran into it.
>
> Thanks! Reworked.

Thx, but it seems it would also need to be applied to bitcoind (or really all executables)?

✅ achow101 closed a pull request: "wallet: add codex32 argument to addhdkey"
(https://github.com/bitcoin/bitcoin/pull/32652)

💬 achow101 commented on pull request "wallet: add codex32 argument to addhdkey":
(https://github.com/bitcoin/bitcoin/pull/32652#issuecomment-3433012113)
Concept NACK

💬 instagibbs commented on pull request "test: Add `leaf_version` parameter to `taproot_tree_helper()`":
(https://github.com/bitcoin/bitcoin/pull/29371#issuecomment-3433012786)
> Previously the leaf version was hard coded, because we only currently support 1 leaf version.

Unless I'm missing something, this is untrue? https://github.com/bitcoin/bitcoin/blob/7d27af98c7cf858b5ab5a02e64f89a857cc53172/test/functional/test_framework/script.py#L870

https://github.com/bitcoin/bitcoin/blob/7d27af98c7cf858b5ab5a02e64f89a857cc53172/test/functional/feature_taproot.py#L1683

Can you explain why this is insufficient for usage?

💬 l0rinc commented on pull request "test: set number of RPC server threads to 2":
(https://github.com/bitcoin/bitcoin/pull/33679#issuecomment-3433021242)
Similar to https://github.com/bitcoin/bitcoin/pull/33485, ran the tests locally, seems fine, change makes sense.
ACK e9cd45e3d3c7592265ebf67387090b3df1501df4