💬 andrewtoth commented on pull request "http: limit RPC server threads to available cores":
(https://github.com/bitcoin/bitcoin/pull/33678#issuecomment-3432813286)
Would it make sense to lower the default only on 32-bit systems? We have lower maximum settings for dbcache and maxmempool on these systems as well, since they are more memory constrained.

💬 Raimo33 commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3432829367)
I've removed some of the less impacting changes, considering @cedwies suggestions. It now shows a 9% improvement on CCoinsCache on my end (up from a 7.7% previously)

💬 Raimo33 commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3432859443)
> now the code paths depend on each other

That's not the case, at least not with the latest push:

- `vSolutions` is used regardless of the code path. It's used before branching.
- `witnessprogram` is used late, after a couple of branches, but this can't possibly impact performance since `std::vector` starts allocating only after first use.

> Wouldn't reserving the vectors help here instead?
This was my initial intuition, but it actually goes against your previous point. `.reserve()` w
...

✅ achow101 closed a pull request: "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/32645)

💬 achow101 commented on pull request "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32645#issuecomment-3432860468)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

cc @davidgumberg @vasild

💬 achow101 commented on pull request "[Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2":
(https://github.com/bitcoin/bitcoin/pull/32617#issuecomment-3432866273)
Are you still working on this?

💬 maflcko commented on pull request "Use subprocess library for notifications":
(https://github.com/bitcoin/bitcoin/pull/32566#issuecomment-3432873785)
> The main advantage of this is that file descriptor leaks are avoided (#32343).

For ref, this was reverted in https://github.com/bitcoin/bitcoin/pull/33063 (temporarily)

💬 laanwj commented on pull request "util: Revert "common: Close non-std fds before exec in RunCommandJSON"":
(https://github.com/bitcoin/bitcoin/pull/33063#issuecomment-3432883289)
Posthumous ACK

> After a fork() in a multithreaded program, the child can safely
> call only async-signal-safe functions (see [signal-safety(7)](https://www.man7.org/linux/man-pages/man7/signal-
> safety.7.html))
> until such time as it calls execv.

TIL

✅ achow101 closed a pull request: "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling"
(https://github.com/bitcoin/bitcoin/pull/29664)

💬 dergoegge commented on pull request "[POC] guix: produce a fully `-static-pie` bitcoind":
(https://github.com/bitcoin/bitcoin/pull/25573#issuecomment-3432902129)
Concept ACK

✅ achow101 closed a pull request: "Add -pruneduringinit option to temporarily use another prune target during IBD"
(https://github.com/bitcoin/bitcoin/pull/31845)

💬 achow101 commented on pull request "Add -pruneduringinit option to temporarily use another prune target during IBD":
(https://github.com/bitcoin/bitcoin/pull/31845#issuecomment-3432914260)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed a pull request: "wallet: re-activate "AmountWithFeeExceedsBalance" error"
(https://github.com/bitcoin/bitcoin/pull/25269)

💬 achow101 commented on pull request "wallet: re-activate "AmountWithFeeExceedsBalance" error":
(https://github.com/bitcoin/bitcoin/pull/25269#issuecomment-3432918501)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

Marking as up for grabs.

✅ achow101 closed a pull request: "assumeutxo state and locking cleanup"
(https://github.com/bitcoin/bitcoin/pull/28608)

✅ achow101 closed a pull request: "Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only"
(https://github.com/bitcoin/bitcoin/pull/26398)

💬 achow101 commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#issuecomment-3432934694)
Are you still working on this?

✅ achow101 closed a pull request: "test: Verify that a message is not in rpc errors raised (follow-up 31451)"
(https://github.com/bitcoin/bitcoin/pull/32174)

💬 achow101 commented on pull request "test: Verify that a message is not in rpc errors raised (follow-up 31451)":
(https://github.com/bitcoin/bitcoin/pull/32174#issuecomment-3432937021)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed a pull request: "OP_CHECKCONTRACTVERIFY"
(https://github.com/bitcoin/bitcoin/pull/32080)