💬 ryanofsky commented on pull request "init: Split file path handling out of -asmap option":
(https://github.com/bitcoin/bitcoin/pull/33631#issuecomment-3432763010)
@laanwj do you agree this PR would be unnecessary if the `ip_asn.map` file were loaded by default (or if asmap data were embedded in the binary and enabled by default)? Those seem like cleaner solutions to me.

Or if it is not safe to load asmap data be default, it would seem cleaner not to have a default'filename that is not actually used by default.

💬 achow101 commented on pull request "doc: improve NODE_NETWORK_LIMITED documentation per BIP159":
(https://github.com/bitcoin/bitcoin/pull/31805#issuecomment-3432765461)
Are you still working on this?

✅ furszy closed a pull request: "http: limit RPC server threads to available cores"
(https://github.com/bitcoin/bitcoin/pull/33678)

💬 andrewtoth commented on pull request "http: limit RPC server threads to available cores":
(https://github.com/bitcoin/bitcoin/pull/33678#issuecomment-3432772787)
> I think it makes sense to not exceed that number, as having more threads than cores doesn’t really help.

This would make sense if RPCs are purely CPU bound. Many RPCs are mainly IO bound, and the OS can suspend a thread while it waits on IO. Absent coroutines that can suspend execution on the same thread for IO, more threads than cores will be a benefit.

👍 andrewtoth approved a pull request: "test: set number of RPC server threads to 2"
(https://github.com/bitcoin/bitcoin/pull/33679#pullrequestreview-3366198055)
ACK e9cd45e3d3c7592265ebf67387090b3df1501df4

Makes sense, similar change to https://github.com/bitcoin/bitcoin/pull/33485.

✅ achow101 closed a pull request: "Prune locks"
(https://github.com/bitcoin/bitcoin/pull/19463)

💬 achow101 commented on pull request "Prune locks":
(https://github.com/bitcoin/bitcoin/pull/19463#issuecomment-3432790032)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

Marking as up for grabs.

cc @fjahr

💬 achow101 commented on pull request "Use subprocess library for notifications":
(https://github.com/bitcoin/bitcoin/pull/32566#issuecomment-3432794288)
Are you still working on this?

💬 achow101 commented on pull request "subprocess: Let shell parse command on non-Windows systems":
(https://github.com/bitcoin/bitcoin/pull/32577#issuecomment-3432804142)
Are you still working on this?

✅ achow101 closed a pull request: "Fix ASM ambiguity"
(https://github.com/bitcoin/bitcoin/pull/28824)

💬 achow101 commented on pull request "Fix ASM ambiguity":
(https://github.com/bitcoin/bitcoin/pull/28824#issuecomment-3432811399)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

cc @ajtowns

💬 andrewtoth commented on pull request "http: limit RPC server threads to available cores":
(https://github.com/bitcoin/bitcoin/pull/33678#issuecomment-3432813286)
Would it make sense to lower the default only on 32-bit systems? We have lower maximum settings for dbcache and maxmempool on these systems as well, since they are more memory constrained.

💬 Raimo33 commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3432829367)
I've removed some of the less impacting changes, considering @cedwies suggestions. It now shows a 9% improvement on CCoinsCache on my end (up from a 7.7% previously)

💬 Raimo33 commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3432859443)
> now the code paths depend on each other

That's not the case, at least not with the latest push:

- `vSolutions` is used regardless of the code path. It's used before branching.
- `witnessprogram` is used late, after a couple of branches, but this can't possibly impact performance since `std::vector` starts allocating only after first use.

> Wouldn't reserving the vectors help here instead?
This was my initial intuition, but it actually goes against your previous point. `.reserve()` w
...

✅ achow101 closed a pull request: "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/32645)

💬 achow101 commented on pull request "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32645#issuecomment-3432860468)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

cc @davidgumberg @vasild

💬 achow101 commented on pull request "[Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2":
(https://github.com/bitcoin/bitcoin/pull/32617#issuecomment-3432866273)
Are you still working on this?

💬 maflcko commented on pull request "Use subprocess library for notifications":
(https://github.com/bitcoin/bitcoin/pull/32566#issuecomment-3432873785)
> The main advantage of this is that file descriptor leaks are avoided (#32343).

For ref, this was reverted in https://github.com/bitcoin/bitcoin/pull/33063 (temporarily)

💬 laanwj commented on pull request "util: Revert "common: Close non-std fds before exec in RunCommandJSON"":
(https://github.com/bitcoin/bitcoin/pull/33063#issuecomment-3432883289)
Posthumous ACK

> After a fork() in a multithreaded program, the child can safely
> call only async-signal-safe functions (see [signal-safety(7)](https://www.man7.org/linux/man-pages/man7/signal-
> safety.7.html))
> until such time as it calls execv.

TIL

✅ achow101 closed a pull request: "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling"
(https://github.com/bitcoin/bitcoin/pull/29664)